Skip to content

Commit 14d354d

Browse files
committed
improve smoke diff output and make yarn smokes fail
1 parent c967290 commit 14d354d

File tree

2 files changed

+6
-14
lines changed

2 files changed

+6
-14
lines changed

.github/workflows/smoke.yaml

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,7 @@ jobs:
9292
- name: Clear Yarn Cache
9393
run: yarn cache clean
9494
- run: |
95-
for i in {1..3}; do
96-
bash ./__tests__/smoke/run-smoke.sh "yarn add ./redocly-cli.tgz" "yarn" && break || sleep 5
97-
done
95+
bash ./__tests__/smoke/run-smoke.sh "yarn add ./redocly-cli.tgz" "yarn"
9896
9997
run-smoke--yarn--node-22--redoc:
10098
needs: prepare-smoke
@@ -110,9 +108,7 @@ jobs:
110108
- name: Clear Yarn Cache
111109
run: yarn cache clean
112110
- run: |
113-
for i in {1..3}; do
114-
bash ./__tests__/smoke/run-smoke.sh "yarn add redoc ./redocly-cli.tgz" "yarn" && break || sleep 5
115-
done
111+
bash ./__tests__/smoke/run-smoke.sh "yarn add redoc ./redocly-cli.tgz" "yarn"
116112
117113
run-smoke--yarn--node-20:
118114
needs: prepare-smoke
@@ -128,9 +124,7 @@ jobs:
128124
- name: Clear Yarn Cache
129125
run: yarn cache clean
130126
- run: |
131-
for i in {1..3}; do
132-
bash ./__tests__/smoke/run-smoke.sh "yarn add ./redocly-cli.tgz" "yarn" && break || sleep 5
133-
done
127+
bash ./__tests__/smoke/run-smoke.sh "yarn add ./redocly-cli.tgz" "yarn"
134128
135129
run-smoke--yarn--node-20--redoc:
136130
needs: prepare-smoke
@@ -146,9 +140,7 @@ jobs:
146140
- name: Clear Yarn Cache
147141
run: yarn cache clean
148142
- run: |
149-
for i in {1..3}; do
150-
bash ./__tests__/smoke/run-smoke.sh "yarn add redoc ./redocly-cli.tgz" "yarn" && break || sleep 5
151-
done
143+
bash ./__tests__/smoke/run-smoke.sh "yarn add redoc ./redocly-cli.tgz" "yarn"
152144
153145
run-smoke--pnpm--node-22:
154146
needs: prepare-smoke

__tests__/smoke/run-smoke.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ $2 redocly-respect
2121

2222
# Check for broken styles when building docs (related issue: https://github.com/Redocly/redocly-cli/issues/1073)
2323
echo "Checking docs for issues..."
24-
diff pre-built/redoc.html redoc-static.html
24+
diff pre-built/redoc.html redoc-static.html -u
2525
echo "✅ Docs built correctly."
2626

2727
# Check for broken $refs (or other issues) in the split files, especially on Windows (it will fail on a difference)
2828
echo "Checking split files for issues..."
29-
diff -r pre-split output/split
29+
diff -r pre-split output/split -u
3030
echo "✅ Files split correctly."

0 commit comments

Comments
 (0)