Skip to content

Commit 3958181

Browse files
committed
chore: fix flaky smokes
1 parent 408ab96 commit 3958181

File tree

2 files changed

+40
-38
lines changed

2 files changed

+40
-38
lines changed

.github/workflows/smoke.yaml

Lines changed: 37 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -107,45 +107,44 @@ jobs:
107107
version: 10
108108
- run: bash ./tests/smoke/basic/run-smoke.sh "pnpm add ./redocly-cli.tgz" "pnpm run"
109109

110-
# Skipped due to a known Windows + NodeJS v24 issue: https://github.com/nodejs/node/issues/56645
111-
# run-smoke--npm--node-24--windows:
112-
# needs: prepare-smoke
113-
# runs-on: windows-latest
114-
# steps:
115-
# - uses: actions/cache@v3
116-
# with:
117-
# path: tests/smoke/basic/
118-
# key: cache-${{ github.run_id }}-${{ github.run_attempt }}
119-
# enableCrossOsArchive: true
120-
# - uses: actions/setup-node@v3
121-
# with:
122-
# node-version: 24
123-
# - run: bash ./tests/smoke/basic/run-smoke.sh "npm i redocly-cli.tgz" "npm run"
110+
run-smoke--npm--node-24--windows:
111+
needs: prepare-smoke
112+
runs-on: windows-latest
113+
steps:
114+
- uses: actions/cache@v3
115+
with:
116+
path: tests/smoke/basic/
117+
key: cache-${{ github.run_id }}-${{ github.run_attempt }}
118+
enableCrossOsArchive: true
119+
- uses: actions/setup-node@v3
120+
with:
121+
node-version: 24
122+
- run: bash ./tests/smoke/basic/run-smoke.sh "npm i redocly-cli.tgz" "npm run"
124123

125-
# run-smoke--yarn--node-24--windows:
126-
# needs: prepare-smoke
127-
# runs-on: windows-latest
128-
# steps:
129-
# - uses: actions/cache@v3
130-
# with:
131-
# path: tests/smoke/basic/
132-
# key: cache-${{ github.run_id }}-${{ github.run_attempt }}
133-
# enableCrossOsArchive: true
134-
# - uses: actions/setup-node@v3
135-
# with:
136-
# node-version: 24
137-
# - name: Run Smoke Tests
138-
# run: |
139-
# Start-Sleep -Seconds 20 # workaround for yarn cache issue
140-
# for ($i = 1; $i -le 3; $i++) {
141-
# try {
142-
# bash ./tests/smoke/basic/run-smoke.sh "yarn add ./redocly-cli.tgz --no-lockfile --network-timeout 100000" "yarn"
143-
# if ($LASTEXITCODE -eq 0) { break }
144-
# } catch {
145-
# if ($i -eq 3) { throw }
146-
# Start-Sleep -Seconds 5
147-
# }
148-
# }
124+
run-smoke--yarn--node-24--windows:
125+
needs: prepare-smoke
126+
runs-on: windows-latest
127+
steps:
128+
- uses: actions/cache@v3
129+
with:
130+
path: tests/smoke/basic/
131+
key: cache-${{ github.run_id }}-${{ github.run_attempt }}
132+
enableCrossOsArchive: true
133+
- uses: actions/setup-node@v3
134+
with:
135+
node-version: 24
136+
- name: Run Smoke Tests
137+
run: |
138+
Start-Sleep -Seconds 20 # workaround for yarn cache issue
139+
for ($i = 1; $i -le 3; $i++) {
140+
try {
141+
bash ./tests/smoke/basic/run-smoke.sh "yarn add ./redocly-cli.tgz --no-lockfile --network-timeout 100000" "yarn"
142+
if ($LASTEXITCODE -eq 0) { break }
143+
} catch {
144+
if ($i -eq 3) { throw }
145+
Start-Sleep -Seconds 5
146+
}
147+
}
149148
150149
run-smoke--npm--node-22:
151150
needs: prepare-smoke

packages/core/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,9 @@
5151
"contributors": [
5252
"Roman Hotsiy <[email protected]> (https://redocly.com/)"
5353
],
54+
"bundleDependencies": [
55+
"ajv-formats"
56+
],
5457
"dependencies": {
5558
"@redocly/ajv": "^8.17.1",
5659
"@redocly/config": "^0.41.1",

0 commit comments

Comments
 (0)