fix: make ignoreLastPathSegment option of the path-segment-plural rule work for any number of segments (#2079)

Author: tatomyr

.changeset/cyan-points-pull.md

@@ -0,0 +1,5 @@
+---
+"@redocly/openapi-core": patch
+---
+
+Fixed an issue where the `ignoreLastPathSegment` option of the `path-segment-plural` rule had no effect if the path contained only one segment, resulting in an error.

.github/workflows/smoke.yaml

@@ -92,8 +92,8 @@ jobs:
       - name: Clear Yarn Cache
         run: yarn cache clean
       - run: |
-          for i in {1..3}; do
-            bash ./__tests__/smoke/run-smoke.sh "yarn add ./redocly-cli.tgz" "yarn" && break || sleep 5
+          for i in {1..2}; do # workaround for yarn cache issue
+            sleep 5 && bash ./__tests__/smoke/run-smoke.sh "yarn add ./redocly-cli.tgz" "yarn" && break
           done
 
   run-smoke--yarn--node-22--redoc:
@@ -110,8 +110,8 @@ jobs:
       - name: Clear Yarn Cache
         run: yarn cache clean
       - run: |
-          for i in {1..3}; do
-            bash ./__tests__/smoke/run-smoke.sh "yarn add redoc ./redocly-cli.tgz" "yarn" && break || sleep 5
+          for i in {1..2}; do # workaround for yarn cache issue
+            sleep 5 && bash ./__tests__/smoke/run-smoke.sh "yarn add redoc ./redocly-cli.tgz" "yarn" && break
           done
 
   run-smoke--yarn--node-20:
@@ -128,8 +128,8 @@ jobs:
       - name: Clear Yarn Cache
         run: yarn cache clean
       - run: |
-          for i in {1..3}; do
-            bash ./__tests__/smoke/run-smoke.sh "yarn add ./redocly-cli.tgz" "yarn" && break || sleep 5
+          for i in {1..2}; do # workaround for yarn cache issue
+            sleep 5 && bash ./__tests__/smoke/run-smoke.sh "yarn add ./redocly-cli.tgz" "yarn" && break
           done
 
   run-smoke--yarn--node-20--redoc:
@@ -146,8 +146,8 @@ jobs:
       - name: Clear Yarn Cache
         run: yarn cache clean
       - run: |
-          for i in {1..3}; do
-            bash ./__tests__/smoke/run-smoke.sh "yarn add redoc ./redocly-cli.tgz" "yarn" && break || sleep 5
+          for i in {1..2}; do # workaround for yarn cache issue
+            sleep 5 && bash ./__tests__/smoke/run-smoke.sh "yarn add redoc ./redocly-cli.tgz" "yarn" && break
           done
 
   run-smoke--pnpm--node-22:
@@ -195,7 +195,7 @@ jobs:
           node-version: 22
       - name: Run Smoke Tests
         run: |
-          Start-Sleep -Seconds 20
+          Start-Sleep -Seconds 20 # workaround for yarn cache issue
           for ($i = 1; $i -le 3; $i++) {
             try {
               bash ./__tests__/smoke/run-smoke.sh "yarn add ./redocly-cli.tgz --no-lockfile --network-timeout 100000" "yarn"
@@ -234,7 +234,7 @@ jobs:
           node-version: 20
       - name: Run Smoke Tests
         run: |
-          Start-Sleep -Seconds 20
+          Start-Sleep -Seconds 20 # workaround for yarn cache issue
           for ($i = 1; $i -le 3; $i++) {
             try {
               bash ./__tests__/smoke/run-smoke.sh "yarn add ./redocly-cli.tgz --no-lockfile --network-timeout 100000" "yarn"

__tests__/lint/path-segment-plural/openapi.yaml

@@ -32,3 +32,7 @@ paths:
     get:
       operationId: status id
       summary: get first status
+  /health: # should be ignored as it's the last segment and the ignoreLastPathSegment option is set to true
+    get:
+      operationId: status
+      summary: get health status

__tests__/smoke-plugins/run-smoke.sh

@@ -16,4 +16,4 @@ npm i redocly-cli.tgz -g
 
 # Actual smoke test - executing the command provided as the second argument
 npm run redocly-version
-npm run  redocly-lint
+npm run  redocly-lint

__tests__/smoke/run-smoke.sh

@@ -21,10 +21,10 @@ $2 redocly-respect
 
 # Check for broken styles when building docs (related issue: https://github.com/Redocly/redocly-cli/issues/1073)
 echo "Checking docs for issues..."
-diff pre-built/redoc.html redoc-static.html 
+diff pre-built/redoc.html redoc-static.html -u
 echo "✅ Docs built correctly."
 
 # Check for broken $refs (or other issues) in the split files, especially on Windows (it will fail on a difference)
 echo "Checking split files for issues..."
-diff -r pre-split output/split
-echo "✅ Files split correctly."
+diff -r pre-split output/split -u
+echo "✅ Files split correctly."

packages/core/src/rules/common/path-segment-plural.ts

@@ -13,7 +13,7 @@ export const PathSegmentPlural: Oas3Rule | Oas2Rule = (opts) => {
         if (pathKey.startsWith('/')) {
           const pathSegments = pathKey.split('/');
           pathSegments.shift();
-          if (ignoreLastPathSegment && pathSegments.length > 1) {
+          if (ignoreLastPathSegment && pathSegments.length > 0) {
             pathSegments.pop();
           }