fix: return on invalid ref pointer in remove-unused-components for OAS2 (#2313)

Author: DmitryAnansky

.changeset/eager-things-train.md

@@ -1,5 +1,6 @@
 ---
 "@redocly/openapi-core": patch
+"@redocly/cli": patch
 ---
 
 Fixed undefined variable used in the `remove-unused-components` decorator, which prevented an invalid reference error from being reported.

packages/core/src/decorators/oas2/__tests__/fixtures/handle-invalid-ref/schemas.yaml

@@ -0,0 +1,2 @@
+Something:
+  type: string

packages/core/src/decorators/oas2/__tests__/fixtures/handle-invalid-ref/swagger.yaml

@@ -0,0 +1,14 @@
+swagger: '2.0'
+info:
+  title: API
+  version: '1.0.0'
+paths:
+  /pets:
+    get:
+      produces:
+        - application/json
+      responses:
+        '200':
+          description: Success
+          schema:
+            $ref: 'schemas.yaml#/Something.fail'

packages/core/src/decorators/oas2/__tests__/remove-unused-components.test.ts

@@ -1,6 +1,7 @@
+import * as path from 'node:path';
 import { outdent } from 'outdent';
 import { parseYamlToDocument } from '../../../../__tests__/utils.js';
-import { bundleDocument } from '../../../bundle.js';
+import { bundleDocument, bundle } from '../../../bundle.js';
 import { BaseResolver } from '../../../resolve.js';
 import { createConfig } from '../../../config/index.js';
 
@@ -226,4 +227,16 @@ describe('oas2 remove-unused-components', () => {
       },
     });
   });
+
+  it('should report invalid ref errors', async () => {
+    const { problems } = await bundle({
+      ref: path.join(__dirname, 'fixtures/handle-invalid-ref/swagger.yaml'),
+      config: await createConfig({}),
+      removeUnusedComponents: true,
+    });
+
+    expect(problems).toHaveLength(1);
+    expect(problems[0].ruleId).toEqual('bundler');
+    expect(problems[0].message).toEqual("Can't resolve $ref");
+  });
 });

packages/core/src/decorators/oas2/remove-unused-components.ts

@@ -61,6 +61,8 @@ export const RemoveUnusedComponents: Oas2Decorator = () => {
           if (!resolvedRef.location) return;
 
           const [fileLocation, localPointer] = resolvedRef.location.absolutePointer.split('#', 2);
+          if (!localPointer) return;
+
           const componentLevelLocalPointer = localPointer.split('/').slice(0, 3).join('/');
           const pointer = `${fileLocation}#${componentLevelLocalPointer}`;