chore: fix default failure action

RomanHotsiy · RomanHotsiy · commit 9a0f7f233947 · 2025-02-24T17:54:34.000+08:00
diff --git a/__tests__/respect/local-json-server/__snapshots__/local-json-server.test.ts.snap b/__tests__/respect/local-json-server/__snapshots__/local-json-server.test.ts.snap
@@ -26,23 +26,6 @@ exports[`local-json-server local-json-server test case 1`] = `
     ✓ content-type check
     ✓ schema check
 
-  ✓ GET /items/{id} - step get-item-by-id
-    ✓ success criteria check - $statusCode == 200
-    ✓ success criteria check - $response.body#/id == $steps.add-item.outputs.crea...
-    ✓ success criteria check - $response.body#/value == $steps.add-item.outputs.c...
-    ✓ status code check - $statusCode in [200, 404]
-    ✓ content-type check
-    ✓ schema check
-
-  ✓ DELETE /items/{id} - step drop-item
-    ✓ success criteria check - $statusCode == 200
-    ✓ status code check - $statusCode in [200]
-
-  ✓ GET /items/{id} - step get-after-deleting
-    ✓ success criteria check - $statusCode == 404
-    ✓ status code check - $statusCode in [200, 404]
-    ✓ content-type check
-
 ────────────────────────────────────────────────────────────────────────────────
 
   Running workflow local-json-server.yaml / auto-inherit
@@ -77,8 +60,8 @@ exports[`local-json-server local-json-server test case 1`] = `
   Summary for local-json-server.yaml
   
   Workflows: 2 passed, 1 failed, 3 total
-  Steps: 9 passed, 1 failed, 10 total
-  Checks: 31 passed, 1 failed, 32 total
+  Steps: 6 passed, 1 failed, 7 total
+  Checks: 20 passed, 1 failed, 21 total
   Time: <test>ms
 
 
diff --git a/__tests__/respect/local-json-server/fake-db.json b/__tests__/respect/local-json-server/fake-db.json
@@ -1,3 +1,20 @@
 {
-  "items": []
+  "items": [
+    {
+      "id": "a959",
+      "value": 9
+    },
+    {
+      "id": "1768",
+      "value": 6
+    },
+    {
+      "id": "6e43",
+      "value": 10
+    },
+    {
+      "id": "8cf3",
+      "value": 7
+    }
+  ]
 }
diff --git a/__tests__/respect/server-override-with-console-parameters/__snapshots__/server-override-with-console-parameters.test.ts.snap b/__tests__/respect/server-override-with-console-parameters/__snapshots__/server-override-with-console-parameters.test.ts.snap
@@ -14,6 +14,8 @@ exports[`should use server override from CLI and env 1`] = `
 
     ✗ failed network request
 
+  Running failure action continue for the step get-museum-hours
+
   Running child workflow for the step buy-ticket
   Running workflow museum-tickets.yaml / get-museum-tickets
 
@@ -33,6 +35,7 @@ exports[`should use server override from CLI and env 1`] = `
 
     ✗ failed network request
 
+
 ────────────────────────────────────────────────────────────────────────────────
 
   Running workflow server-override-with-console-parameters.yaml / events-crud
@@ -61,27 +64,11 @@ exports[`should use server override from CLI and env 1`] = `
     ✗ failed network request
       fetch failed
       
-    stepId - create-event
-    ✗ unexpected error
-    Reason: Error in resolving runtime expression '$steps.list-events.outputs.events.0.dates.0'. 
-    This could be because the expression references a value from a previous failed step, or is trying to reference a variable that hasn't been set.
-    stepId - get-event-by-id
-    ✗ unexpected error
-    Reason: Error in resolving runtime expression '$steps.create-event.outputs.createdEventId'. 
-    This could be because the expression references a value from a previous failed step, or is trying to reference a variable that hasn't been set.
-    stepId - update-event
-    ✗ unexpected error
-    Reason: Error in resolving runtime expression '$steps.create-event.outputs.createdEventId'. 
-    This could be because the expression references a value from a previous failed step, or is trying to reference a variable that hasn't been set.
-    stepId - delete-event
-    ✗ unexpected error
-    Reason: Error in resolving runtime expression '$steps.update-event.outputs.updatedEventId'. 
-    This could be because the expression references a value from a previous failed step, or is trying to reference a variable that hasn't been set.
   Summary for server-override-with-console-parameters.yaml
   
   Workflows: 2 failed, 2 total
-  Steps: 6 failed, 6 total
-  Checks: 6 failed, 6 total
+  Steps: 2 failed, 2 total
+  Checks: 2 failed, 2 total
   Time: <test>ms
 
 
diff --git a/__tests__/respect/server-override-with-console-parameters/server-override-with-console-parameters.yaml b/__tests__/respect/server-override-with-console-parameters/server-override-with-console-parameters.yaml
@@ -29,6 +29,10 @@ workflows:
         operationId: museum-api.getMuseumHours
         successCriteria:
           - condition: $statusCode == 200
+        onFailure:
+          - name: continue
+            type: goto
+            stepId: buy-ticket
         outputs:
           schedule: $response.body
       - stepId: buy-ticket
diff --git a/__tests__/respect/severity-error-level/__snapshots__/severity-error-level.test.ts.snap b/__tests__/respect/severity-error-level/__snapshots__/severity-error-level.test.ts.snap
@@ -73,41 +73,6 @@ exports[`should use error severity level 1`] = `
     ✓ success criteria check - $statusCode == 200
     ✗ status code check
 
-  Running child workflow for the step buy-ticket
-  Running workflow museum-tickets.yaml / get-museum-tickets
-
-  ✓ POST /tickets - step buy-tickets
-
-    Request URL: https://redocly.com/_mock/demo/openapi/museum-api/tickets
-    Request Headers:
-      content-type: application/json
-      accept: application/json, application/problem+json
-      authorization: Basic Og==
-    Request Body:
-      {
-        "ticketType": "general",
-        "ticketDate": "2023-09-07",
-        "email": "todd@example.com"
-      }
-
-
-    Response status code: 201
-    Response time: <test> ms
-    Response Body:
-      {
-        "message": "Museum general entry ticket purchased",
-        "ticketId": "382c0820-0530-4f4b-99af-13811ad0f17a",
-        "ticketType": "general",
-        "ticketDate": "2023-09-07",
-        "confirmationCode": "ticket-general-e5e5c6-dce78"
-      }
-
-    ✓ success criteria check - $statusCode == 201
-    ✓ status code check - $statusCode in [201, 400, 404]
-    ✓ content-type check
-    ✓ schema check
-
-
 ────────────────────────────────────────────────────────────────────────────────
 
   Running workflow severity-level.yaml / events-crud
@@ -354,22 +319,6 @@ exports[`should use error severity level 1`] = `
     ✓ status code check - $statusCode in [200, 400, 404]
     ✗ content-type check
 
-  ✗ DELETE /special-events/{eventId} - step delete-event
-
-    Request URL: https://redocly.com/_mock/demo/openapi/museum-api/special-events/dad4bce8-f5cb-4078-a211-995864315e39
-    Request Headers:
-      accept: application/problem+json
-      authorization: Basic Og==
-
-
-    Response status code: 204
-    Response time: <test> ms
-    Response Body:
-      {}
-
-    ✗ success criteria check - $statusCode == 200
-    ✗ status code check
-
 
   Failed tests info:
 
@@ -386,18 +335,11 @@ exports[`should use error severity level 1`] = `
       Content type application/json for 200 response is not described in the schema.
       Expected content types: json.
       
-    stepId - delete-event
-    ✗ success criteria check
-      Checking simple criteria: {"condition":"$statusCode == 200"}
-      
-    ✗ status code check
-      
-      
   Summary for severity-level.yaml
   
   Workflows: 2 failed, 2 total
-  Steps: 4 passed, 3 failed, 7 total
-  Checks: 20 passed, 4 failed, 24 total
+  Steps: 3 passed, 2 failed, 5 total
+  Checks: 16 passed, 2 failed, 18 total
   Time: <test>ms
 
 
diff --git a/__tests__/respect/severity-off-level/__snapshots__/severity-off-level.test.ts.snap b/__tests__/respect/severity-off-level/__snapshots__/severity-off-level.test.ts.snap
@@ -73,41 +73,6 @@ exports[`should use off severity level 1`] = `
     ✓ success criteria check - $statusCode == 200
     ✗ status code check
 
-  Running child workflow for the step buy-ticket
-  Running workflow museum-tickets.yaml / get-museum-tickets
-
-  ✓ POST /tickets - step buy-tickets
-
-    Request URL: https://redocly.com/_mock/demo/openapi/museum-api/tickets
-    Request Headers:
-      content-type: application/json
-      accept: application/json, application/problem+json
-      authorization: Basic Og==
-    Request Body:
-      {
-        "ticketType": "general",
-        "ticketDate": "2023-09-07",
-        "email": "todd@example.com"
-      }
-
-
-    Response status code: 201
-    Response time: <test> ms
-    Response Body:
-      {
-        "message": "Museum general entry ticket purchased",
-        "ticketId": "382c0820-0530-4f4b-99af-13811ad0f17a",
-        "ticketType": "general",
-        "ticketDate": "2023-09-07",
-        "confirmationCode": "ticket-general-e5e5c6-dce78"
-      }
-
-    ✓ success criteria check - $statusCode == 201
-    ✓ status code check - $statusCode in [201, 400, 404]
-    ✓ content-type check
-    ✓ schema check
-
-
 ────────────────────────────────────────────────────────────────────────────────
 
   Running workflow severity-level.yaml / events-crud
@@ -354,22 +319,6 @@ exports[`should use off severity level 1`] = `
     ✓ status code check - $statusCode in [200, 400, 404]
     ✗ content-type check
 
-  ✗ DELETE /special-events/{eventId} - step delete-event
-
-    Request URL: https://redocly.com/_mock/demo/openapi/museum-api/special-events/dad4bce8-f5cb-4078-a211-995864315e39
-    Request Headers:
-      accept: application/problem+json
-      authorization: Basic Og==
-
-
-    Response status code: 204
-    Response time: <test> ms
-    Response Body:
-      {}
-
-    ✗ success criteria check - $statusCode == 200
-    ✗ status code check
-
 
   Failed tests info:
 
@@ -386,18 +335,11 @@ exports[`should use off severity level 1`] = `
       Content type application/json for 200 response is not described in the schema.
       Expected content types: json.
       
-    stepId - delete-event
-    ○ success criteria check (skipped)
-      Checking simple criteria: {"condition":"$statusCode == 200"}
-      
-    ○ status code check (skipped)
-      
-      
   Summary for severity-level.yaml
   
   Workflows: 2 passed, 2 total
-  Steps: 7 passed, 3 ignored, 7 total
-  Checks: 24 passed, 4 ignored, 24 total
+  Steps: 5 passed, 2 ignored, 5 total
+  Checks: 18 passed, 2 ignored, 18 total
   Time: <test>ms
 
 
diff --git a/__tests__/respect/severity-warn-level/__snapshots__/severity-warn-level.test.ts.snap b/__tests__/respect/severity-warn-level/__snapshots__/severity-warn-level.test.ts.snap
@@ -73,41 +73,6 @@ exports[`should use warn severity level 1`] = `
     ✓ success criteria check - $statusCode == 200
     ⚠ status code check
 
-  Running child workflow for the step buy-ticket
-  Running workflow museum-tickets.yaml / get-museum-tickets
-
-  ✓ POST /tickets - step buy-tickets
-
-    Request URL: https://redocly.com/_mock/demo/openapi/museum-api/tickets
-    Request Headers:
-      content-type: application/json
-      accept: application/json, application/problem+json
-      authorization: Basic Og==
-    Request Body:
-      {
-        "ticketType": "general",
-        "ticketDate": "2023-09-07",
-        "email": "todd@example.com"
-      }
-
-
-    Response status code: 201
-    Response time: <test> ms
-    Response Body:
-      {
-        "message": "Museum general entry ticket purchased",
-        "ticketId": "382c0820-0530-4f4b-99af-13811ad0f17a",
-        "ticketType": "general",
-        "ticketDate": "2023-09-07",
-        "confirmationCode": "ticket-general-e5e5c6-dce78"
-      }
-
-    ✓ success criteria check - $statusCode == 201
-    ✓ status code check - $statusCode in [201, 400, 404]
-    ✓ content-type check
-    ✓ schema check
-
-
 ────────────────────────────────────────────────────────────────────────────────
 
   Running workflow severity-level.yaml / events-crud
@@ -354,22 +319,6 @@ exports[`should use warn severity level 1`] = `
     ✓ status code check - $statusCode in [200, 400, 404]
     ⚠ content-type check
 
-  ✗ DELETE /special-events/{eventId} - step delete-event
-
-    Request URL: https://redocly.com/_mock/demo/openapi/museum-api/special-events/dad4bce8-f5cb-4078-a211-995864315e39
-    Request Headers:
-      accept: application/problem+json
-      authorization: Basic Og==
-
-
-    Response status code: 204
-    Response time: <test> ms
-    Response Body:
-      {}
-
-    ⚠ success criteria check - $statusCode == 200
-    ⚠ status code check
-
 
   Failed tests info:
 
@@ -386,18 +335,11 @@ exports[`should use warn severity level 1`] = `
       Content type application/json for 200 response is not described in the schema.
       Expected content types: json.
       
-    stepId - delete-event
-    ⚠ success criteria check
-      Checking simple criteria: {"condition":"$statusCode == 200"}
-      
-    ⚠ status code check
-      
-      
   Summary for severity-level.yaml
   
   Workflows: 2 passed, 2 total
-  Steps: 7 passed, 3 warnings, 7 total
-  Checks: 24 passed, 4 warnings, 24 total
+  Steps: 5 passed, 2 warnings, 5 total
+  Checks: 18 passed, 2 warnings, 18 total
   Time: <test>ms
 
 
diff --git a/packages/respect-core/src/modules/flow-runner/run-step.ts b/packages/respect-core/src/modules/flow-runner/run-step.ts
diff --git a/packages/respect-core/src/modules/flow-runner/runner.ts b/packages/respect-core/src/modules/flow-runner/runner.ts
