-
Notifications
You must be signed in to change notification settings - Fork 197
fix(core): fix bug loading of .redocly.lint-ignore.yaml in browser environments
#2489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 0f7eb30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
📦 A new experimental 🧪 version v0.0.0-snapshot.1767804621 of Redocly CLI has been published for testing. Install with NPM: npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected] |
|
📦 A new experimental 🧪 version v0.0.0-snapshot.1767807792 of Redocly CLI has been published for testing. Install with NPM: npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected] |
|
📦 A new experimental 🧪 version v0.0.0-snapshot.1767866050 of Redocly CLI has been published for testing. Install with NPM: npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected] |
|
📦 A new experimental 🧪 version v0.0.0-snapshot.1767870619 of Redocly CLI has been published for testing. Install with NPM: npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected] |
|
📦 A new experimental 🧪 version v0.0.0-snapshot.1767871282 of Redocly CLI has been published for testing. Install with NPM: npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected] |
|
📦 A new experimental 🧪 version v0.0.0-snapshot.1767882364 of Redocly CLI has been published for testing. Install with NPM: npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected] |
.redocly.lint-ignore.yaml in browser environments
packages/core/src/config/load.ts
Outdated
| if (!configPath) return undefined; | ||
|
|
||
| const configDir = getDir(configPath); | ||
| const ignorePath = resolvePath(configDir, IGNORE_FILE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's no config file, then resolve the ignore file against CWD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated. Please check again
|
📦 A new experimental 🧪 version v0.0.0-snapshot.1768325315 of Redocly CLI has been published for testing. Install with NPM: npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected] |
packages/core/src/config/load.ts
Outdated
| configPath: string | undefined, | ||
| resolver: BaseResolver | ||
| ): Promise<Record<string, Record<string, Set<string>>> | undefined> { | ||
| const configDir = configPath ? getDir(configPath) : process.cwd(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested if it works in the browser env? Is there maybe a fallback needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a bug. Without redocly.yaml, language-server does not work. Not sure if this is related to changes in the core, or perhaps it could be in language-server. I am investigating this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed bug on language-server side
|
📦 A new experimental 🧪 version v0.0.0-snapshot.1768388635 of Redocly CLI has been published for testing. Install with NPM: npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected] |
|
📦 A new experimental 🧪 version v0.0.0-snapshot.1768392585 of Redocly CLI has been published for testing. Install with NPM: npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected] |
|
📦 A new experimental 🧪 version v0.0.0-snapshot.1768395566 of Redocly CLI has been published for testing. Install with NPM: npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected] |
|
📦 A new experimental 🧪 version v0.0.0-snapshot.1768415577 of Redocly CLI has been published for testing. Install with NPM: npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected] |
What/Why/How?
Fixed loading of
.redocly.lint-ignore.yamlin browser environments (Reunite).Reference
#86
Related PR
Testing
Screenshots (optional)
Check yourself
Security