Skip to content

Commit 1707882

Browse files
authored
feat: revised and added grid color variables (#1232)
1 parent 0633c6d commit 1707882

File tree

1 file changed

+54
-11
lines changed

1 file changed

+54
-11
lines changed

packages/ds-theme/src/variants/light/variables.less

Lines changed: 54 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -205,22 +205,71 @@
205205

206206

207207
// Table/Grid
208-
// TODO: Need to review
209208
@grid-border-color : @separator-color;
210209
@grid-header-text-color : @header-text-color;
211-
@grid-header-background-color : @header-background-color;
210+
@grid-header-background-color : @cont-color-common-container-surface-on-layer-1-subtle; // @header-background-color;
212211
@grid-header-border-color : @grid-header-background-color;
212+
@grid-header-hover-background-color : @cont-color-common-container-surface-on-layer-1-moderate; // Missing
213213
@grid-row-text-color : @global-text-color;
214214
@grid-row-background-color : @global-background-color;
215215
@grid-row-hover-text-color : @grid-row-text-color;
216-
@grid-row-hover-background-color : fade(mix(@scheme-color-primary, @grid-row-background-color, 15%), 50%);
216+
@grid-row-hover-background-color : @cont-color-common-container-surface-on-layer-3-minimal; // fade(mix(@scheme-color-primary, @grid-row-background-color, 15%), 50%);
217217
@grid-row-active-text-color : @grid-row-text-color;
218-
@grid-row-active-background-color : @grid-row-hover-background-color;
218+
@grid-row-active-background-color : @cont-color-common-container-surface-on-layer-3-subtle; // @grid-row-hover-background-color;
219219
@grid-row-active-border-width : @grid-border-width;
220220
@grid-row-active-border-color : @scheme-color-primary;
221-
@grid-row-focus-border-color : @scheme-color-primary;
221+
@grid-row-focus-border-color : @cont-color-common-container-misc-focus;
222222
@grid-row-focus-border : @grid-row-focus-border-width dotted @grid-row-focus-border-color;
223223

224+
// Grid
225+
@grid-text-color : @global-text-color;
226+
@grid-header-alt-background-color : @header-background-color;
227+
@grid-row-alternate-background-color : darken(@grid-row-background-color, 2%);
228+
229+
// Grid column
230+
// - Column selection
231+
@grid-column-active-title-border-color : invalidColor; // selected column title divider
232+
@grid-column-active-border-color : @cont-color-common-container-brand-base; // selection boundary, overrides global-focus-bordercolor
233+
234+
// - Column separator (between pined and unpined column)
235+
@grid-column-separator-background-color : darken(@separator-color, 1%);
236+
237+
// Grid row
238+
// - Row group header
239+
@grid-row-header-background-color : darken(@grid-row-background-color, 3%); // TBC
240+
@grid-expended-row-header-color : @cont-color-common-fg-generic-bold; // TBC
241+
242+
// - Row group tag
243+
@grid-tag-background-color : darken(@cont-color-common-fg-generic-moderate, 20%);
244+
@grid-expanded-tag-background-color : darken(@cont-color-common-fg-generic-moderate, 10%);
245+
246+
// Grid dragging UI
247+
@grid-guideline-background-color : @cont-color-common-fg-primary-moderate; // Placeholder guide
248+
@grid-drag-box-border-color : @control-border-color;
249+
@grid-drag-box-background-color : lighten(@grid-row-background-color, 5%);
250+
@grid-drag-indicator-border-color : dashed 1px lighten(@separator-color, 20%); // Border of dragging selected column
251+
252+
// Grid icons
253+
// - Filter icon, Stack icon
254+
@grid-title-icon-color : @cont-color-common-fg-primary-moderate;
255+
@grid-title-icon-active-color : @cont-color-common-fg-primary-on-primary-moderate; // active filtering
256+
@grid-title-icon-hover-color : @cont-color-common-fg-primary-bold;
257+
258+
// - Sort icon
259+
@grid-title-sort-icon-color : @cont-color-common-fg-primary-moderate;
260+
261+
// - Tiny filter icon
262+
@grid-title-dot-icon-color : @grid-header-text-color;
263+
264+
// - Row menu icon, column menu icon
265+
@grid-menu-icon-color : #ffffff;
266+
@grid-menu-icon-background-color : @cont-color-common-fg-brand-moderate;
267+
@grid-menu-icon-hover-background-color : @cont-color-common-fg-brand-bold;
268+
269+
// - Row more icon
270+
@grid-row-more-icon-color : @grid-header-text-color;
271+
@grid-row-more-icon-hover-color : @cont-color-common-fg-primary-bold;
272+
224273
// Tabs
225274
@tab-background-color : @header-level3-bg-color;
226275
@tab-text-color : @button-text-color;
@@ -252,12 +301,6 @@
252301
// Tab bar
253302
@tab-bar-background-color : @cont-color-common-container-surface-layer-2;
254303

255-
// Grid
256-
// TODO: Need to review
257-
@grid-text-color : @global-text-color;
258-
@grid-header-alt-background-color : @header-background-color;
259-
@grid-row-alternate-background-color : darken(@grid-row-background-color, 2%);
260-
261304
// Data viz
262305
@dataviz-color-primary : @scheme-color-primary;
263306
@dataviz-color-secondary : @scheme-color-secondary;

0 commit comments

Comments
 (0)