bug: unintended rtl::Record::create code flow path fixed.

Author: neeraj31285

RTLBenchmarkApp/src/ReflectedCall.cpp

@@ -21,9 +21,10 @@ namespace
     static rtl::RObject nodeObj = []() 
     {    
         auto Node = cxx::mirror().getRecord("Node").value();
-
-        rtl::RObject robj = Node.create<rtl::alloc::Stack>().rObject;
-
+        auto [err, robj] = Node.create<rtl::alloc::Stack>();
+        if (nodeObj.isEmpty()) {
+            std::cout << "[0] nodeObj empty! \n";
+        }
         return std::move(robj);
     }();
 }
@@ -36,17 +37,17 @@ namespace
         auto err = SendMessage(bm::g_longStr).err;
 
         if (err != rtl::error::None) {
-            std::cout << "[0] error: "<< rtl::to_string(err)<<"\n";
+            std::cout << "[1] error: "<< rtl::to_string(err)<<"\n";
         }
         return 0;
     };
 
     static auto _test1 = []()
     {
-        auto err = NodeSendMessage(nodeObj)(bm::g_longStr).err;
+        auto err = NodeSendMessage.bind(nodeObj).call(bm::g_longStr).err;
 
         if (err != rtl::error::None)  {
-            std::cout << "[1] error: " << rtl::to_string(err) << "\n";
+            std::cout << "[2] error: " << rtl::to_string(err) << "\n";
         }
         return 0;
     };
@@ -56,7 +57,7 @@ namespace
         auto err = GetMessage(bm::g_longStr).err;
 
         if (err != rtl::error::None) {
-            std::cout << "[2] error: " << rtl::to_string(err) << "\n";
+            std::cout << "[3] error: " << rtl::to_string(err) << "\n";
         }
         return 0;
     };
@@ -66,7 +67,7 @@ namespace
         auto err = NodeGetMessage(nodeObj)(bm::g_longStr).err;
 
         if (err != rtl::error::None) {
-            std::cout << "[3] error: " << rtl::to_string(err) << "\n";
+            std::cout << "[4] error: " << rtl::to_string(err) << "\n";
         }
         return 0;
     };

ReflectionTemplateLib/access/inc/Method.h

@@ -41,7 +41,7 @@ namespace rtl {
 
         //invokes the constructor associated with this 'Method'
         template<class ..._args>
-        Return invokeCtor(alloc&& pAllocType, std::size_t&& pClonerIndex, _args&&...params) const;
+        Return invokeCtor(alloc pAllocType, std::size_t pClonerIndex, _args&&...params) const;
 
     public:
 

ReflectionTemplateLib/access/inc/Method.hpp

@@ -34,11 +34,15 @@ namespace rtl
     @return: RStatus
     * calls the constructor with given arguments.
 */  template<class ..._args>
-    inline Return Method::invokeCtor(alloc&& pAllocType, std::size_t&& pClonerIndex, _args&& ...params) const
+    inline Return Method::invokeCtor(alloc pAllocType, std::size_t pClonerIndex, _args&& ...params) const
     {
-        return Function::bind().call<alloc, std::size_t, _args...>( std::forward<alloc>(pAllocType),
-                                                                    std::forward<std::size_t>(pClonerIndex),
-                                                                    std::forward<_args>(params)...);
+        using Container = detail::FunctorContainer<alloc, std::size_t, std::remove_reference_t<_args>...>;
+
+        std::size_t index = hasSignatureId(Container::getContainerId());
+        if (index != rtl::index_none) [[likely]] {
+            return Container::template forwardCall<_args...>(index, pAllocType, pClonerIndex, std::forward<_args>(params)...);
+        }
+        return { error::SignatureMismatch, RObject{} };
     }
 
 

ReflectionTemplateLib/access/inc/Record.h

@@ -95,9 +95,7 @@ namespace rtl {
             static_assert(_alloc != rtl::alloc::None, "Instance cannot be created with 'rtl::alloc::None' option.");
             const auto& method = m_methods.at(detail::ctor_name(m_recordName));
             std::size_t copyCtorIndex = method.getFunctorIds()[detail::Index::CopyCtor].getIndex();
-            return method.invokeCtor( _alloc,
-                                      std::move(copyCtorIndex),
-                                      std::forward<_ctorArgs>(params)...);
+            return method.invokeCtor(_alloc, copyCtorIndex, std::forward<_ctorArgs>(params)...);
         }
 
         //only class which can create objects of this class & manipulates 'm_methods'.