Merge pull request #193 from RehanSaeed/upgrade-fxcop

Bump Microsoft.CodeAnalysis.FxCopAnalyzers from 3.0.0 to 3.3.0

Author: Turnerj

Directory.Build.props

@@ -20,7 +20,7 @@
   </PropertyGroup>
 
   <ItemGroup Label="Package References">
-    <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" PrivateAssets="All" Version="3.0.0" />
+    <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" PrivateAssets="All" Version="3.3.0" />
     <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" PrivateAssets="All" Version="1.0.0" />
     <PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" PrivateAssets="All" Version="16.7.54" />
     <PackageReference Include="MinVer" PrivateAssets="All" Version="2.3.0" />

Source/Schema.NET/PropertyValueSpecification.Partial.cs

@@ -59,7 +59,7 @@ private static void AppendSpace(StringBuilder stringBuilder)
         {
             if (stringBuilder.Length > 0)
             {
-                stringBuilder.Append(" ");
+                stringBuilder.Append(' ');
             }
         }
     }

Tests/Schema.NET.Test/core/EventTest.cs

@@ -8,8 +8,10 @@ namespace Schema.NET.Test
     // https://developers.google.com/search/docs/data-types/events
     public class EventTest
     {
-        private static readonly string NullString = null;
-        private static readonly ItemAvailability? NullItemAvailability = null;
+#pragma warning disable CS0649 // Field is never assigned to and will always have its default value.
+        private static readonly string NullString;
+        private static readonly ItemAvailability? NullItemAvailability;
+#pragma warning restore CS0649 // Field is never assigned to and will always have its default value.
 
         private readonly Event @event = new Event()
         {

Tools/Schema.NET.Tool/ViewModels/Enumeration.cs

@@ -58,7 +58,7 @@ public override string ToString()
                     stringBuilder.AppendCommentSummary(8, value.Description);
                     stringBuilder.AppendIndentLine(8, $"[EnumMember(Value = \"{httpsValueUri}\")]");
                     stringBuilder.AppendIndent(8, value.Name);
-                    stringBuilder.Append(",");
+                    stringBuilder.Append(',');
                     if (!isLast)
                     {
                         stringBuilder.AppendLine();