Skip to content

Commit 74fa5d1

Browse files
RehanSaeedRehanSaeed
committed
Set AnalysisMode to AllEnabledByDefault
1 parent b9be136 commit 74fa5d1

22 files changed

+179
-15
lines changed

‎Directory.Build.props‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<PropertyGroup Label="Build">
44
<LangVersion>latest</LangVersion>
55
<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
6-
<AnalysisMode>Default</AnalysisMode>
6+
<AnalysisMode>AllEnabledByDefault</AnalysisMode>
77
<AnalysisLevel>latest</AnalysisLevel>
88
<NeutralLanguage>en-GB</NeutralLanguage>
99
<Nullable>enable</Nullable>

‎Source/Common/ContextJsonConverter.cs‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,11 @@ public override JsonLdContext ReadJson(JsonReader reader, Type objectType, JsonL
2323
throw new ArgumentNullException(nameof(objectType));
2424
}
2525

26+
if (hasExistingValue && existingValue is null)
27+
{
28+
throw new ArgumentNullException(nameof(existingValue));
29+
}
30+
2631
if (serializer is null)
2732
{
2833
throw new ArgumentNullException(nameof(serializer));
@@ -48,8 +53,10 @@ public override JsonLdContext ReadJson(JsonReader reader, Type objectType, JsonL
4853
language = languageProperty?.Value?.ToString();
4954
}
5055

56+
#pragma warning disable CA1062 // Validate arguments of public methods
5157
context.Name = name;
5258
context.Language = language;
59+
#pragma warning restore CA1062 // Validate arguments of public methods
5360
return context;
5461
}
5562

‎Source/Common/EnumHelper.cs‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,9 @@ public static bool TryParse(
3030
result = Enum.Parse(enumType, value);
3131
return true;
3232
}
33+
#pragma warning disable CA1031 // Do not catch general exception types
3334
catch
35+
#pragma warning restore CA1031 // Do not catch general exception types
3436
{
3537
result = null;
3638
return false;

‎Source/Common/OneOrMany{T}.cs‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,9 @@ public OneOrMany(IEnumerable<object> collection)
160160
/// <param name="list">The list of values.</param>
161161
/// <returns>The result of the conversion.</returns>
162162
#pragma warning disable CA2225 // Operator overloads have named alternates
163+
#pragma warning disable CA1002 // Do not expose generic lists
163164
public static implicit operator OneOrMany<T>(List<T> list) => new(list);
165+
#pragma warning restore CA1002 // Do not expose generic lists
164166
#pragma warning restore CA2225 // Operator overloads have named alternates
165167

166168
/// <summary>
@@ -193,7 +195,9 @@ public OneOrMany(IEnumerable<object> collection)
193195
/// The result of the conversion.
194196
/// </returns>
195197
#pragma warning disable CA2225 // Operator overloads have named alternates
198+
#pragma warning disable CA1002 // Do not expose generic lists
196199
public static implicit operator List<T>(OneOrMany<T> oneOrMany) => oneOrMany.ToList();
200+
#pragma warning restore CA1002 // Do not expose generic lists
197201
#pragma warning restore CA2225 // Operator overloads have named alternates
198202

199203
/// <summary>

‎Source/Common/Values{T1,T2,T3,T4,T5,T6,T7}.cs‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,9 @@ public Values(IEnumerable<object?> items)
494494
/// <param name="list">The list of values.</param>
495495
/// <returns>The result of the conversion.</returns>
496496
#pragma warning disable CA2225 // Operator overloads have named alternates
497+
#pragma warning disable CA1002 // Do not expose generic lists
497498
public static implicit operator Values<T1, T2, T3, T4, T5, T6, T7>(List<T1> list) => new(list);
499+
#pragma warning restore CA1002 // Do not expose generic lists
498500
#pragma warning restore CA2225 // Operator overloads have named alternates
499501

500502
/// <summary>
@@ -503,7 +505,9 @@ public Values(IEnumerable<object?> items)
503505
/// <param name="list">The list of values.</param>
504506
/// <returns>The result of the conversion.</returns>
505507
#pragma warning disable CA2225 // Operator overloads have named alternates
508+
#pragma warning disable CA1002 // Do not expose generic lists
506509
public static implicit operator Values<T1, T2, T3, T4, T5, T6, T7>(List<T2> list) => new(list);
510+
#pragma warning restore CA1002 // Do not expose generic lists
507511
#pragma warning restore CA2225 // Operator overloads have named alternates
508512

509513
/// <summary>
@@ -512,7 +516,9 @@ public Values(IEnumerable<object?> items)
512516
/// <param name="list">The list of values.</param>
513517
/// <returns>The result of the conversion.</returns>
514518
#pragma warning disable CA2225 // Operator overloads have named alternates
519+
#pragma warning disable CA1002 // Do not expose generic lists
515520
public static implicit operator Values<T1, T2, T3, T4, T5, T6, T7>(List<T3> list) => new(list);
521+
#pragma warning restore CA1002 // Do not expose generic lists
516522
#pragma warning restore CA2225 // Operator overloads have named alternates
517523

518524
/// <summary>
@@ -521,7 +527,9 @@ public Values(IEnumerable<object?> items)
521527
/// <param name="list">The list of values.</param>
522528
/// <returns>The result of the conversion.</returns>
523529
#pragma warning disable CA2225 // Operator overloads have named alternates
530+
#pragma warning disable CA1002 // Do not expose generic lists
524531
public static implicit operator Values<T1, T2, T3, T4, T5, T6, T7>(List<T4> list) => new(list);
532+
#pragma warning restore CA1002 // Do not expose generic lists
525533
#pragma warning restore CA2225 // Operator overloads have named alternates
526534

527535
/// <summary>
@@ -530,7 +538,9 @@ public Values(IEnumerable<object?> items)
530538
/// <param name="list">The list of values.</param>
531539
/// <returns>The result of the conversion.</returns>
532540
#pragma warning disable CA2225 // Operator overloads have named alternates
541+
#pragma warning disable CA1002 // Do not expose generic lists
533542
public static implicit operator Values<T1, T2, T3, T4, T5, T6, T7>(List<T5> list) => new(list);
543+
#pragma warning restore CA1002 // Do not expose generic lists
534544
#pragma warning restore CA2225 // Operator overloads have named alternates
535545

536546
/// <summary>
@@ -539,7 +549,9 @@ public Values(IEnumerable<object?> items)
539549
/// <param name="list">The list of values.</param>
540550
/// <returns>The result of the conversion.</returns>
541551
#pragma warning disable CA2225 // Operator overloads have named alternates
552+
#pragma warning disable CA1002 // Do not expose generic lists
542553
public static implicit operator Values<T1, T2, T3, T4, T5, T6, T7>(List<T6> list) => new(list);
554+
#pragma warning restore CA1002 // Do not expose generic lists
543555
#pragma warning restore CA2225 // Operator overloads have named alternates
544556

545557
/// <summary>
@@ -548,7 +560,9 @@ public Values(IEnumerable<object?> items)
548560
/// <param name="list">The list of values.</param>
549561
/// <returns>The result of the conversion.</returns>
550562
#pragma warning disable CA2225 // Operator overloads have named alternates
563+
#pragma warning disable CA1002 // Do not expose generic lists
551564
public static implicit operator Values<T1, T2, T3, T4, T5, T6, T7>(List<T7> list) => new(list);
565+
#pragma warning restore CA1002 // Do not expose generic lists
552566
#pragma warning restore CA2225 // Operator overloads have named alternates
553567

554568
/// <summary>
@@ -566,7 +580,9 @@ public Values(IEnumerable<object?> items)
566580
/// <param name="list">The list of values.</param>
567581
/// <returns>The result of the conversion.</returns>
568582
#pragma warning disable CA2225 // Operator overloads have named alternates
583+
#pragma warning disable CA1002 // Do not expose generic lists
569584
public static implicit operator Values<T1, T2, T3, T4, T5, T6, T7>(List<object> list) => new(list);
585+
#pragma warning restore CA1002 // Do not expose generic lists
570586
#pragma warning restore CA2225 // Operator overloads have named alternates
571587

572588
/// <summary>
@@ -665,7 +681,9 @@ public Values(IEnumerable<object?> items)
665681
/// The result of the conversion.
666682
/// </returns>
667683
#pragma warning disable CA2225 // Operator overloads have named alternates
684+
#pragma warning disable CA1002 // Do not expose generic lists
668685
public static implicit operator List<T1>(Values<T1, T2, T3, T4, T5, T6, T7> values) => values.Value1.ToList();
686+
#pragma warning restore CA1002 // Do not expose generic lists
669687
#pragma warning restore CA2225 // Operator overloads have named alternates
670688

671689
/// <summary>
@@ -687,7 +705,9 @@ public Values(IEnumerable<object?> items)
687705
/// The result of the conversion.
688706
/// </returns>
689707
#pragma warning disable CA2225 // Operator overloads have named alternates
708+
#pragma warning disable CA1002 // Do not expose generic lists
690709
public static implicit operator List<T2>(Values<T1, T2, T3, T4, T5, T6, T7> values) => values.Value2.ToList();
710+
#pragma warning restore CA1002 // Do not expose generic lists
691711
#pragma warning restore CA2225 // Operator overloads have named alternates
692712

693713
/// <summary>
@@ -709,7 +729,9 @@ public Values(IEnumerable<object?> items)
709729
/// The result of the conversion.
710730
/// </returns>
711731
#pragma warning disable CA2225 // Operator overloads have named alternates
732+
#pragma warning disable CA1002 // Do not expose generic lists
712733
public static implicit operator List<T3>(Values<T1, T2, T3, T4, T5, T6, T7> values) => values.Value3.ToList();
734+
#pragma warning restore CA1002 // Do not expose generic lists
713735
#pragma warning restore CA2225 // Operator overloads have named alternates
714736

715737
/// <summary>
@@ -731,7 +753,9 @@ public Values(IEnumerable<object?> items)
731753
/// The result of the conversion.
732754
/// </returns>
733755
#pragma warning disable CA2225 // Operator overloads have named alternates
756+
#pragma warning disable CA1002 // Do not expose generic lists
734757
public static implicit operator List<T4>(Values<T1, T2, T3, T4, T5, T6, T7> values) => values.Value4.ToList();
758+
#pragma warning restore CA1002 // Do not expose generic lists
735759
#pragma warning restore CA2225 // Operator overloads have named alternates
736760

737761
/// <summary>
@@ -753,7 +777,9 @@ public Values(IEnumerable<object?> items)
753777
/// The result of the conversion.
754778
/// </returns>
755779
#pragma warning disable CA2225 // Operator overloads have named alternates
780+
#pragma warning disable CA1002 // Do not expose generic lists
756781
public static implicit operator List<T5>(Values<T1, T2, T3, T4, T5, T6, T7> values) => values.Value5.ToList();
782+
#pragma warning restore CA1002 // Do not expose generic lists
757783
#pragma warning restore CA2225 // Operator overloads have named alternates
758784

759785
/// <summary>
@@ -775,7 +801,9 @@ public Values(IEnumerable<object?> items)
775801
/// The result of the conversion.
776802
/// </returns>
777803
#pragma warning disable CA2225 // Operator overloads have named alternates
804+
#pragma warning disable CA1002 // Do not expose generic lists
778805
public static implicit operator List<T6>(Values<T1, T2, T3, T4, T5, T6, T7> values) => values.Value6.ToList();
806+
#pragma warning restore CA1002 // Do not expose generic lists
779807
#pragma warning restore CA2225 // Operator overloads have named alternates
780808

781809
/// <summary>
@@ -797,7 +825,9 @@ public Values(IEnumerable<object?> items)
797825
/// The result of the conversion.
798826
/// </returns>
799827
#pragma warning disable CA2225 // Operator overloads have named alternates
828+
#pragma warning disable CA1002 // Do not expose generic lists
800829
public static implicit operator List<T7>(Values<T1, T2, T3, T4, T5, T6, T7> values) => values.Value7.ToList();
830+
#pragma warning restore CA1002 // Do not expose generic lists
801831
#pragma warning restore CA2225 // Operator overloads have named alternates
802832

803833
/// <summary>

‎Source/Common/Values{T1,T2,T3,T4,T5,T6}.cs‎

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,9 @@ public Values(IEnumerable<object?> items)
418418
/// <param name="list">The list of values.</param>
419419
/// <returns>The result of the conversion.</returns>
420420
#pragma warning disable CA2225 // Operator overloads have named alternates
421+
#pragma warning disable CA1002 // Do not expose generic lists
421422
public static implicit operator Values<T1, T2, T3, T4, T5, T6>(List<T1> list) => new(list);
423+
#pragma warning restore CA1002 // Do not expose generic lists
422424
#pragma warning restore CA2225 // Operator overloads have named alternates
423425

424426
/// <summary>
@@ -427,7 +429,9 @@ public Values(IEnumerable<object?> items)
427429
/// <param name="list">The list of values.</param>
428430
/// <returns>The result of the conversion.</returns>
429431
#pragma warning disable CA2225 // Operator overloads have named alternates
432+
#pragma warning disable CA1002 // Do not expose generic lists
430433
public static implicit operator Values<T1, T2, T3, T4, T5, T6>(List<T2> list) => new(list);
434+
#pragma warning restore CA1002 // Do not expose generic lists
431435
#pragma warning restore CA2225 // Operator overloads have named alternates
432436

433437
/// <summary>
@@ -436,7 +440,9 @@ public Values(IEnumerable<object?> items)
436440
/// <param name="list">The list of values.</param>
437441
/// <returns>The result of the conversion.</returns>
438442
#pragma warning disable CA2225 // Operator overloads have named alternates
443+
#pragma warning disable CA1002 // Do not expose generic lists
439444
public static implicit operator Values<T1, T2, T3, T4, T5, T6>(List<T3> list) => new(list);
445+
#pragma warning restore CA1002 // Do not expose generic lists
440446
#pragma warning restore CA2225 // Operator overloads have named alternates
441447

442448
/// <summary>
@@ -445,7 +451,9 @@ public Values(IEnumerable<object?> items)
445451
/// <param name="list">The list of values.</param>
446452
/// <returns>The result of the conversion.</returns>
447453
#pragma warning disable CA2225 // Operator overloads have named alternates
454+
#pragma warning disable CA1002 // Do not expose generic lists
448455
public static implicit operator Values<T1, T2, T3, T4, T5, T6>(List<T4> list) => new(list);
456+
#pragma warning restore CA1002 // Do not expose generic lists
449457
#pragma warning restore CA2225 // Operator overloads have named alternates
450458

451459
/// <summary>
@@ -454,7 +462,9 @@ public Values(IEnumerable<object?> items)
454462
/// <param name="list">The list of values.</param>
455463
/// <returns>The result of the conversion.</returns>
456464
#pragma warning disable CA2225 // Operator overloads have named alternates
465+
#pragma warning disable CA1002 // Do not expose generic lists
457466
public static implicit operator Values<T1, T2, T3, T4, T5, T6>(List<T5> list) => new(list);
467+
#pragma warning restore CA1002 // Do not expose generic lists
458468
#pragma warning restore CA2225 // Operator overloads have named alternates
459469

460470
/// <summary>
@@ -463,7 +473,9 @@ public Values(IEnumerable<object?> items)
463473
/// <param name="list">The list of values.</param>
464474
/// <returns>The result of the conversion.</returns>
465475
#pragma warning disable CA2225 // Operator overloads have named alternates
476+
#pragma warning disable CA1002 // Do not expose generic lists
466477
public static implicit operator Values<T1, T2, T3, T4, T5, T6>(List<T6> list) => new(list);
478+
#pragma warning restore CA1002 // Do not expose generic lists
467479
#pragma warning restore CA2225 // Operator overloads have named alternates
468480

469481
/// <summary>
@@ -481,7 +493,9 @@ public Values(IEnumerable<object?> items)
481493
/// <param name="list">The list of values.</param>
482494
/// <returns>The result of the conversion.</returns>
483495
#pragma warning disable CA2225 // Operator overloads have named alternates
496+
#pragma warning disable CA1002 // Do not expose generic lists
484497
public static implicit operator Values<T1, T2, T3, T4, T5, T6>(List<object> list) => new(list);
498+
#pragma warning restore CA1002 // Do not expose generic lists
485499
#pragma warning restore CA2225 // Operator overloads have named alternates
486500

487501
/// <summary>
@@ -569,7 +583,9 @@ public Values(IEnumerable<object?> items)
569583
/// The result of the conversion.
570584
/// </returns>
571585
#pragma warning disable CA2225 // Operator overloads have named alternates
586+
#pragma warning disable CA1002 // Do not expose generic lists
572587
public static implicit operator List<T1>(Values<T1, T2, T3, T4, T5, T6> values) => values.Value1.ToList();
588+
#pragma warning restore CA1002 // Do not expose generic lists
573589
#pragma warning restore CA2225 // Operator overloads have named alternates
574590

575591
/// <summary>
@@ -591,7 +607,9 @@ public Values(IEnumerable<object?> items)
591607
/// The result of the conversion.
592608
/// </returns>
593609
#pragma warning disable CA2225 // Operator overloads have named alternates
610+
#pragma warning disable CA1002 // Do not expose generic lists
594611
public static implicit operator List<T2>(Values<T1, T2, T3, T4, T5, T6> values) => values.Value2.ToList();
612+
#pragma warning restore CA1002 // Do not expose generic lists
595613
#pragma warning restore CA2225 // Operator overloads have named alternates
596614

597615
/// <summary>
@@ -613,7 +631,9 @@ public Values(IEnumerable<object?> items)
613631
/// The result of the conversion.
614632
/// </returns>
615633
#pragma warning disable CA2225 // Operator overloads have named alternates
634+
#pragma warning disable CA1002 // Do not expose generic lists
616635
public static implicit operator List<T3>(Values<T1, T2, T3, T4, T5, T6> values) => values.Value3.ToList();
636+
#pragma warning restore CA1002 // Do not expose generic lists
617637
#pragma warning restore CA2225 // Operator overloads have named alternates
618638

619639
/// <summary>
@@ -635,7 +655,9 @@ public Values(IEnumerable<object?> items)
635655
/// The result of the conversion.
636656
/// </returns>
637657
#pragma warning disable CA2225 // Operator overloads have named alternates
658+
#pragma warning disable CA1002 // Do not expose generic lists
638659
public static implicit operator List<T4>(Values<T1, T2, T3, T4, T5, T6> values) => values.Value4.ToList();
660+
#pragma warning restore CA1002 // Do not expose generic lists
639661
#pragma warning restore CA2225 // Operator overloads have named alternates
640662

641663
/// <summary>
@@ -657,7 +679,9 @@ public Values(IEnumerable<object?> items)
657679
/// The result of the conversion.
658680
/// </returns>
659681
#pragma warning disable CA2225 // Operator overloads have named alternates
682+
#pragma warning disable CA1002 // Do not expose generic lists
660683
public static implicit operator List<T5>(Values<T1, T2, T3, T4, T5, T6> values) => values.Value5.ToList();
684+
#pragma warning restore CA1002 // Do not expose generic lists
661685
#pragma warning restore CA2225 // Operator overloads have named alternates
662686

663687
/// <summary>
@@ -679,7 +703,9 @@ public Values(IEnumerable<object?> items)
679703
/// The result of the conversion.
680704
/// </returns>
681705
#pragma warning disable CA2225 // Operator overloads have named alternates
706+
#pragma warning disable CA1002 // Do not expose generic lists
682707
public static implicit operator List<T6>(Values<T1, T2, T3, T4, T5, T6> values) => values.Value6.ToList();
708+
#pragma warning restore CA1002 // Do not expose generic lists
683709
#pragma warning restore CA2225 // Operator overloads have named alternates
684710

685711
/// <summary>

0 commit comments

Comments
 (0)