Reverted ItemListElement to match schema.org type ordering; fixed up unit tests to reflect semantics.

Author: kirk-marple

Source/Schema.NET/core/ItemList.cs

@@ -14,7 +14,7 @@ public partial interface IItemList : IIntangible
         /// Text values are best if the elements in the list are plain strings. Existing entities are best for a simple, unordered list of existing things in your data. ListItem is used with ordered lists when you want to provide additional context about the element in that list or when the same item might be in different places in different lists.<br/><br/>
         /// Note: The order of elements in your mark-up is not sufficient for indicating the order or elements.  Use ListItem with a 'position' property in such cases.
         /// </summary>
-        Values<IThing, string, IListItem>? ItemListElement { get; set; }
+        Values<IListItem, string, IThing>? ItemListElement { get; set; }
 
         /// <summary>
         /// Type of ordering (e.g. Ascending, Descending, Unordered).
@@ -46,7 +46,7 @@ public partial class ItemList : Intangible, IItemList
         /// </summary>
         [DataMember(Name = "itemListElement", Order = 206)]
         [JsonConverter(typeof(ValuesJsonConverter))]
-        public Values<IThing, string, IListItem>? ItemListElement { get; set; }
+        public Values<IListItem, string, IThing>? ItemListElement { get; set; }
 
         /// <summary>
         /// Type of ordering (e.g. Ascending, Descending, Unordered).

Source/Schema.NET/core/combined/CreativeWorkAndItemListAndListItem.cs

@@ -389,7 +389,7 @@ public abstract partial class CreativeWorkAndItemListAndListItem : Intangible, I
         /// </summary>
         [DataMember(Name = "itemListElement", Order = 257)]
         [JsonConverter(typeof(ValuesJsonConverter))]
-        public Values<IThing, string, IListItem>? ItemListElement { get; set; }
+        public Values<IListItem, string, IThing>? ItemListElement { get; set; }
 
         /// <summary>
         /// Type of ordering (e.g. Ascending, Descending, Unordered).

Tests/Schema.NET.Test/core/BreadcrumbListTest.cs

@@ -79,10 +79,14 @@ public void Deserializing_BreadcrumbListJsonLd_ReturnsBreadcrumbList()
         {
             var breadcrumbList = JsonConvert.DeserializeObject<BreadcrumbList>(this.json, TestDefaults.DefaultJsonSerializerSettings);
 
+            List<IThing> things = breadcrumbList.ItemListElement;
             List<IListItem> listItems = breadcrumbList.ItemListElement;
-            Assert.Equal(2, listItems.Count);
-            var listItem1 = listItems.First();
-            var listItem2 = listItems.Last();
+            Assert.Equal(2, things.Count);
+            Assert.Empty(listItems);
+            var thing1 = things.First();
+            var thing2 = things.Last();
+            var listItem1 = (IListItem)thing1;
+            var listItem2 = (IListItem)thing2;
             Assert.Equal(1, listItem1.Position);
             Assert.Equal(2, listItem2.Position);
             var book = listItem1.Item.OfType<IBook>().FirstOrDefault();

Tests/Schema.NET.Test/core/ItemListTest.cs

@@ -195,10 +195,12 @@ public void Deserializing_ItemListJsonLd_ReturnsItemList()
             Assert.Equal(2, itemList.ItemListElement.Value.Count);
             var listItems = (List<IListItem>)itemList.ItemListElement.Value;
             var things = (List<IThing>)itemList.ItemListElement.Value;
-            Assert.Equal(2, listItems.Count);
-            Assert.Empty(things);
-            var listItem1 = listItems.First();
-            var listItem2 = listItems.Last();
+            Assert.Empty(listItems);
+            Assert.Equal(2, things.Count);
+            var thing1 = things.First();
+            var thing2 = things.Last();
+            var listItem1 = (IListItem)thing1;
+            var listItem2 = (IListItem)thing2;
             Assert.Equal(1, listItem1.Position);
             Assert.Equal(2, listItem2.Position);
             var recipe1 = Assert.IsType<Recipe>(listItem1.Item.Single());