Address feedback on TSL rules for React

Author: Rel1cx

packages/tsl-rules-of-react/src/rules/rules-of-keys.ts

@@ -55,25 +55,24 @@ export const rulesOfKeys = defineRule(() => {
         if (element.kind !== ts.SyntaxKind.JsxOpeningElement && element.kind !== ts.SyntaxKind.JsxSelfClosingElement) {
           return;
         }
-        const children: ts.Node[] = [];
-        ts.forEachChild(element.attributes, (n) => void children.push(n));
+        let index = -1;
         let firstSpreadAttrIndex: null | number = null;
-        for (const [index, attr] of children.entries()) {
+        ts.forEachChild(element.attributes, (attr) => {
+          index++;
           if (attr.kind === ts.SyntaxKind.JsxSpreadAttribute) {
             firstSpreadAttrIndex ??= index;
-            continue;
+            return;
           }
           if (firstSpreadAttrIndex == null) {
-            continue;
+            return;
           }
-          const name = attr.getChildAt(0);
-          if (name.getText() === "key" && index > firstSpreadAttrIndex) {
+          if (attr.getChildAt(0).getText() === "key" && index > firstSpreadAttrIndex) {
             ctx.report({
               message: messages[3],
               node: attr,
             });
           }
-        }
+        });
       },
     },
   };

packages/tsl-shared/package.json

@@ -36,6 +36,7 @@
     "dedent": "^1.7.1",
     "tsdown": "^0.20.3",
     "tsl": "^1.0.29",
+    "typescript": "*",
     "vitest": "^4.0.18"
   },
   "peerDependencies": {

pnpm-lock.yaml

@@ -15,4 +15,4 @@ overrides:
   "markdown-it": "^14.1.1"
   "tslib": "^2.8.1"
   "typescript": "^5.9.3"
-  "undici": "^7.18.2"
+  "undici": "^7.22.0"