fix: update noDuplicateImports rule to handle import defer statements without auto-fix suggestions

Author: Rel1cx

packages/tsl-module/src/rules/no-duplicate-imports.test.ts

@@ -48,22 +48,16 @@ test("no-duplicate-import", () => {
         ],
       },
       {
+        // invalid import defer syntax, but for test purpose
         code: tsx`
-          import defer { foo } from 'module';
-          import defer { foo } from 'module';
+          import defer { foo1 } from 'module';
+          import defer { foo2 } from 'module';
         `,
         errors: [
           {
             line: 2,
             message: messages.noDuplicateImports({ source: "'module'" }),
-            suggestions: [
-              {
-                message: "Merge duplicate imports",
-                output: tsx`
-                  import defer { foo } from 'module';\n
-                `,
-              },
-            ],
+            suggestions: [],
           },
         ],
       },
@@ -102,6 +96,19 @@ test("no-duplicate-import", () => {
           },
         ],
       },
+      {
+        code: tsx`
+           import defer * as ns1 from "mod";
+           import defer * as ns2 from "mod";
+        `,
+        errors: [
+          {
+            line: 2,
+            message: messages.noDuplicateImports({ source: '"mod"' }),
+            suggestions: [],
+          },
+        ],
+      },
     ],
     ruleFn: noDuplicateImports,
     tsx: true,
@@ -111,11 +118,15 @@ test("no-duplicate-import", () => {
         import { A } from 'module2';
         import { A } from 'module3';
       `,
+      // invalid import defer syntax, but for test purpose
       tsx`
         import { A } from 'module';
         import type { A } from 'module';
         import defer { A } from 'module';
       `,
+      tsx`
+        import defer * as ns from "mod";
+      `,
     ],
   });
   expect(ret).toBe(false);

packages/tsl-module/src/rules/no-duplicate-imports.ts

@@ -71,21 +71,23 @@ export const noDuplicateImports = defineRule(() => {
           ctx.report({
             node,
             message: messages.noDuplicateImports({ source: importInfo.source }),
-            suggestions: [
-              {
-                message: "Merge duplicate imports",
-                changes: [
-                  {
-                    node,
-                    newText: "",
-                  },
-                  {
-                    node: duplicateImport.node,
-                    newText: buildMergedImport(duplicateImport, importInfo),
-                  },
-                ],
-              },
-            ],
+            suggestions: importKind > 1
+              ? [] // no auto fix for two import defer statements
+              : [
+                {
+                  message: "Merge duplicate imports",
+                  changes: [
+                    {
+                      node,
+                      newText: "",
+                    },
+                    {
+                      node: duplicateImport.node,
+                      newText: buildMergedImport(duplicateImport, importInfo),
+                    },
+                  ],
+                },
+              ],
           });
           return;
         }