refactor: reorganize element hierarchy functions and remove unused code

Author: Rel1cx

packages/core/docs/README.md

@@ -61,7 +61,6 @@
 - [isChildrenForEachCall](functions/isChildrenForEachCall.md)
 - [isChildrenMap](functions/isChildrenMap.md)
 - [isChildrenMapCall](functions/isChildrenMapCall.md)
-- [isChildrenOfCreateElement](functions/isChildrenOfCreateElement.md)
 - [isChildrenOnly](functions/isChildrenOnly.md)
 - [isChildrenOnlyCall](functions/isChildrenOnlyCall.md)
 - [isChildrenToArray](functions/isChildrenToArray.md)
@@ -95,7 +94,6 @@
 - [isGetDerivedStateFromError](functions/isGetDerivedStateFromError.md)
 - [isGetDerivedStateFromProps](functions/isGetDerivedStateFromProps.md)
 - [isInitializedFromReact](functions/isInitializedFromReact.md)
-- [isInsideCreateElementProps](functions/isInsideCreateElementProps.md)
 - [isInsideReactHook](functions/isInsideReactHook.md)
 - [isInsideRenderMethod](functions/isInsideRenderMethod.md)
 - [isInversePhase](functions/isInversePhase.md)

packages/core/docs/functions/isChildrenOfCreateElement.md

@@ -4,7 +4,7 @@ import { type RuleContext } from "@eslint-react/shared";
 import type { TSESTree } from "@typescript-eslint/types";
 import { AST_NODE_TYPES as T } from "@typescript-eslint/types";
 
-import { isChildrenOfCreateElement } from "../element";
+import { isCreateElementCall } from "../utils";
 import { ERComponentHint } from "./component-collector-hint";
 import { isFunctionOfRenderMethod } from "./component-lifecycle";
 
@@ -38,6 +38,21 @@ export function hasValidHierarchy(context: RuleContext, node: AST.TSESTreeFuncti
   return boundaryNode == null || boundaryNode.type !== T.JSXExpressionContainer;
 }
 
+/**
+ * Determines whether inside `createElement`'s children.
+ * @param context The rule context
+ * @param node The AST node to check
+ * @returns `true` if the node is inside createElement's children
+ */
+function isChildrenOfCreateElement(context: RuleContext, node: TSESTree.Node) {
+  const parent = node.parent;
+  if (parent == null || parent.type !== T.CallExpression) return false;
+  if (!isCreateElementCall(context, parent)) return false;
+  return parent.arguments
+    .slice(2)
+    .some((arg) => arg === node);
+}
+
 function isFunctionOfClassMethod(node: TSESTree.Node): node is
   | TSESTree.ArrowFunctionExpression
   | TSESTree.FunctionExpression

packages/core/docs/functions/isInsideCreateElementProps.md

@@ -1,6 +1,5 @@
 export * from "./component";
 export * from "./effect";
-export * from "./element";
 export * from "./hook";
 export type * from "./semantic-entry";
 export type * from "./semantic-node";

packages/core/src/component/hierarchy.ts

@@ -1,16 +1,16 @@
 import * as AST from "@eslint-react/ast";
 import {
   ERComponentHint,
+  isCreateElementCall,
   isDeclaredInRenderPropLoose,
   isDirectValueOfRenderPropertyLoose,
-  isInsideCreateElementProps,
   isInsideRenderMethod,
   useComponentCollector,
   useComponentCollectorLegacy,
 } from "@eslint-react/core";
 import { _ } from "@eslint-react/eff";
 import * as JSX from "@eslint-react/jsx";
-import type { RuleFeature } from "@eslint-react/shared";
+import type { RuleContext, RuleFeature } from "@eslint-react/shared";
 import type { TSESTree } from "@typescript-eslint/types";
 import { AST_NODE_TYPES as T } from "@typescript-eslint/types";
 
@@ -156,3 +156,17 @@ export default createRule<[], MessageID>({
   },
   defaultOptions: [],
 });
+
+/**
+ * Determines whether inside `createElement`'s props.
+ * @param context The rule context
+ * @param node The AST node to check
+ * @returns `true` if the node is inside createElement's props
+ */
+function isInsideCreateElementProps(context: RuleContext, node: TSESTree.Node) {
+  const call = AST.findParentNode(node, isCreateElementCall(context));
+  if (call == null) return false;
+  const prop = AST.findParentNode(node, AST.is(T.ObjectExpression));
+  if (prop == null) return false;
+  return prop === call.arguments[1];
+}