perf(shared): replace micro-memoize and fast-equals with builtins

Rel1cx · Rel1cx · commit 146541df4643 · 2025-04-16T09:31:53.000+08:00
diff --git a/apps/website/content/docs/configuration/configure-analyzer.mdx b/apps/website/content/docs/configuration/configure-analyzer.mdx
@@ -32,7 +32,7 @@ export default [
 
 Defines the React version for semantic analysis.
 
-- `"detect"`: Auto-detects from project dependencies (defaults to `19.1.0` if undetectable)
+- `detect`: Auto-detects from project dependencies (defaults to `19.1.0` if undetectable)
 - `string`: Explicit version specification (e.g., `"18.3.1"`)
 
 ### `importSource`
@@ -73,10 +73,13 @@ Example with `polymorphicPropName` set to `as`:
 ### `additionalComponents` (Experimental)
 
 <Callout type="info">
-  Consider using `polymorphicPropName` instead when possible, as it's simpler and more efficient.
+  Consider using `polymorphicPropName` instead when possible, as it's simpler
+  and more efficient.
 </Callout>
 
-<Callout type="warn">Experimental feature that may lack stability and documentation.</Callout>
+<Callout type="warn">
+  Experimental feature that may lack stability and documentation.
+</Callout>
 
 Maps components and their attributes for comprehensive analysis. Supports default attribute values.
 
@@ -102,9 +105,10 @@ This makes `<EmbedContent src="https://eslint-react.xyz" />{:tsx}` evaluate as `
 ### `additionalHooks` (Experimental)
 
 <Callout type="warn">
-  Intended for edge cases. We suggest to use this option **very sparingly, if at all**. Generally saying, we recommend
-  most custom Hooks do not vary the built-in React Hooks, and instead provide a higher-level API that is more focused
-  around a specific use case.
+  Intended for edge cases. We suggest to use this option **very sparingly, if at
+  all**. Generally saying, we recommend most custom Hooks do not vary the
+  built-in React Hooks, and instead provide a higher-level API that is more
+  focused around a specific use case.
 </Callout>
 
 Alias variants to built-in React Hooks for rule compatibility:
diff --git a/apps/website/content/docs/presets.mdx b/apps/website/content/docs/presets.mdx
@@ -5,7 +5,8 @@ title: Presets
 The following presets are available in `@eslint-react/eslint-plugin`:
 
 <Callout type="info">
-  For ESLint Legacy Config (`.eslintrc.*`), add a `-legacy` suffix to the preset name (e.g. `recommended-legacy`).
+  For ESLint Legacy Config (`.eslintrc.*`), add a `-legacy` suffix to the preset
+  name (e.g. `recommended-legacy`).
 </Callout>
 
 ## Bare Bones
diff --git a/apps/website/package.json b/apps/website/package.json
@@ -13,12 +13,12 @@
     "@chevrotain/regexp-to-ast": "^11.0.3",
     "bsky-react-post": "^0.1.7",
     "clsx": "^2.1.1",
-    "fumadocs-core": "15.2.6",
+    "fumadocs-core": "15.2.7",
     "fumadocs-docgen": "2.0.0",
-    "fumadocs-mdx": "11.5.8",
-    "fumadocs-twoslash": "3.1.0",
+    "fumadocs-mdx": "11.6.0",
+    "fumadocs-twoslash": "3.1.1",
     "fumadocs-typescript": "4.0.2",
-    "fumadocs-ui": "15.2.6",
+    "fumadocs-ui": "15.2.7",
     "lucide-react": "^0.488.0",
     "next": "^15.3.0",
     "next-view-transitions": "^0.3.4",
diff --git a/apps/website/source.config.ts b/apps/website/source.config.ts
@@ -1,8 +1,8 @@
+import { remarkMermaid } from "@theguild/remark-mermaid";
 import { rehypeCodeDefaultOptions } from "fumadocs-core/mdx-plugins";
 import { remarkDocGen, remarkInstall } from "fumadocs-docgen";
 import { defineConfig, defineDocs } from "fumadocs-mdx/config";
 import { transformerTwoslash } from "fumadocs-twoslash";
-import { remarkMermaid } from "@theguild/remark-mermaid";
 
 export const docs = defineDocs({
   dir: "content/docs",
@@ -14,7 +14,25 @@ export default defineConfig({
     rehypeCodeOptions: {
       experimentalJSEngine: true,
       inline: "tailing-curly-colon",
-      langs: ["js", "ts", "jsx", "tsx", "html", "md", "mdx", "css", "json", "yaml"],
+      langs: [
+        "bash",
+        "css",
+        "html",
+        "js",
+        "json",
+        "jsx",
+        "lisp",
+        "log",
+        "md",
+        "mdx",
+        "regexp",
+        "sh",
+        "shell",
+        "ts",
+        "tsx",
+        "yaml",
+        "diff",
+      ],
       lazy: true,
       themes: {
         dark: "github-dark",
diff --git a/eslint.config.ts b/eslint.config.ts
@@ -3,7 +3,7 @@ import url from "node:url";
 import markdown from "@eslint/markdown";
 import * as configs from "@local/configs/eslint";
 import pluginLocal from "@local/eslint-plugin-local";
-import configFlatGitignore from "eslint-config-flat-gitignore";
+import gitIgnores from "eslint-config-flat-gitignore";
 import pluginVitest from "eslint-plugin-vitest";
 import { globalIgnores } from "eslint/config";
 import tseslint from "typescript-eslint";
@@ -22,7 +22,6 @@ const GLOB_TEST = [
 const GLOB_CONFIG = ["*.config.{ts,tsx,cts,mts}", "**/*.config.{ts,tsx,cts,mts}"];
 const GLOB_SCRIPT = ["scripts/**/*.{ts,cts,mts}"];
 const GLOB_IGNORES = [
-  ...configFlatGitignore().ignores,
   "apps",
   "docs",
   "test",
@@ -36,6 +35,7 @@ const packagesTsConfigs = [
 ];
 
 export default tseslint.config(
+  gitIgnores(),
   globalIgnores(GLOB_IGNORES),
   {
     extends: [
diff --git a/packages/core/src/hook/hook-is.ts b/packages/core/src/hook/hook-is.ts
@@ -3,7 +3,7 @@ import type { RuleContext } from "@eslint-react/kit";
 import type { TSESTree } from "@typescript-eslint/types";
 import * as AST from "@eslint-react/ast";
 import { constFalse, flip } from "@eslint-react/eff";
-import { unsafeDecodeSettings } from "@eslint-react/shared";
+import { coerceSettings } from "@eslint-react/shared";
 import { AST_NODE_TYPES as T } from "@typescript-eslint/types";
 
 import { DEFAULT_ESLINT_REACT_SETTINGS } from "../../../shared/src/schemas";
@@ -41,7 +41,7 @@ export function isReactHookCallWithName(context: RuleContext, node: TSESTree.Nod
   const {
     importSource = DEFAULT_ESLINT_REACT_SETTINGS.importSource,
     skipImportCheck = true,
-  } = unsafeDecodeSettings(context.settings);
+  } = coerceSettings(context.settings);
   const initialScope = context.sourceCode.getScope(node);
   return (name: string) => {
     switch (true) {
@@ -77,7 +77,7 @@ export function isReactHookCallWithNameAlias(context: RuleContext, name: string,
   const {
     importSource = DEFAULT_ESLINT_REACT_SETTINGS.importSource,
     skipImportCheck = true,
-  } = unsafeDecodeSettings(context.settings);
+  } = coerceSettings(context.settings);
   return (node: TSESTree.CallExpression) => {
     const initialScope = context.sourceCode.getScope(node);
     switch (true) {
diff --git a/packages/core/src/utils/is-from-react.ts b/packages/core/src/utils/is-from-react.ts
@@ -3,7 +3,7 @@ import type { RuleContext } from "@eslint-react/kit";
 import type { Scope } from "@typescript-eslint/scope-manager";
 import type { TSESTree } from "@typescript-eslint/types";
 import { type _, dual } from "@eslint-react/eff";
-import { DEFAULT_ESLINT_REACT_SETTINGS, unsafeDecodeSettings } from "@eslint-react/shared";
+import { coerceSettings, DEFAULT_ESLINT_REACT_SETTINGS } from "@eslint-react/shared";
 import { AST_NODE_TYPES as T } from "@typescript-eslint/types";
 
 import { isInitializedFromReact } from "./is-initialized-from-react";
@@ -59,7 +59,7 @@ export function isFromReact(name: string): isFromReact.ReturnType {
   // dprint-ignore
   return dual(2, (context: RuleContext, node: TSESTree.Node | _): node is TSESTree.Identifier | TSESTree.MemberExpression => {
     if (node == null) return false;
-    const { importSource = defaultImportSource, skipImportCheck = true } = unsafeDecodeSettings(context.settings);
+    const { importSource = defaultImportSource, skipImportCheck = true } = coerceSettings(context.settings);
     if (skipImportCheck) return isFromReactLoose(node, name);
     return isFromReactStrict(node, name, importSource, context.sourceCode.getScope(node));
   });
@@ -70,7 +70,7 @@ export function isFromReactObject(objectName: string, propertyName: string): isF
   // dprint-ignore
   return dual(2, (context: RuleContext, node: TSESTree.Node | _): node is TSESTree.Identifier | TSESTree.MemberExpression => {
     if (node?.type !== T.MemberExpression) return false;
-    const { importSource = defaultImportSource, skipImportCheck = true } = unsafeDecodeSettings(context.settings);
+    const { importSource = defaultImportSource, skipImportCheck = true } = coerceSettings(context.settings);
     const { object, property } = node;
     if (skipImportCheck) return isFromReactLoose(object, objectName) && isFromReactLoose(property, propertyName);
     return isFromReactStrict(
diff --git a/packages/plugins/eslint-plugin-react-x/src/rules/jsx-no-duplicate-props.md b/packages/plugins/eslint-plugin-react-x/src/rules/jsx-no-duplicate-props.md
@@ -28,13 +28,13 @@ Disallow duplicate props in JSX elements.
 ### Failing
 
 ```tsx
-<Hello name="John" name="Doe" />
+<Hello name="John" name="Doe" />;
 ```
 
 ### Passing
 
 ```tsx
-<Hello name="John" />
+<Hello name="John" />;
 ```
 
 ## Implementation
diff --git a/packages/plugins/eslint-plugin-react-x/src/rules/no-array-index-key.ts b/packages/plugins/eslint-plugin-react-x/src/rules/no-array-index-key.ts
@@ -5,7 +5,7 @@ import * as AST from "@eslint-react/ast";
 import * as ER from "@eslint-react/core";
 import { _ } from "@eslint-react/eff";
 import { Reporter as RPT, type RuleContext, type RuleFeature } from "@eslint-react/kit";
-import { unsafeDecodeSettings } from "@eslint-react/shared";
+import { coerceSettings } from "@eslint-react/shared";
 import { AST_NODE_TYPES as T } from "@typescript-eslint/types";
 import { isMatching } from "ts-pattern";
 
@@ -24,7 +24,7 @@ function isReactChildrenMethod(name: string): name is typeof reactChildrenMethod
 }
 
 function isUsingReactChildren(context: RuleContext, node: TSESTree.CallExpression) {
-  const { importSource = "react" } = unsafeDecodeSettings(context.settings);
+  const { importSource = "react" } = coerceSettings(context.settings);
   const { callee } = node;
   if (!("property" in callee) || !("object" in callee) || !("name" in callee.property)) {
     return false;
diff --git a/packages/shared/docs/README.md b/packages/shared/docs/README.md
@@ -30,6 +30,7 @@
 
 ## Functions
 
+- [coerceSettings](functions/coerceSettings.md)
 - [getId](functions/getId.md)
 - [getReactVersion](functions/getReactVersion.md)
 - [getSettingsFromContext](functions/getSettingsFromContext.md)
diff --git a/packages/shared/docs/functions/coerceSettings.md b/packages/shared/docs/functions/coerceSettings.md
@@ -0,0 +1,25 @@
+[**@eslint-react/shared**](../README.md)
+
+***
+
+[@eslint-react/shared](../README.md) / coerceSettings
+
+# Function: coerceSettings()
+
+> **coerceSettings**(`data`): `PartialObjectDeep`\<\{ `additionalComponents`: `object`[]; `additionalHooks`: \{ `use`: `string`[]; `useActionState`: `string`[]; `useCallback`: `string`[]; `useContext`: `string`[]; `useDebugValue`: `string`[]; `useDeferredValue`: `string`[]; `useEffect`: `string`[]; `useFormStatus`: `string`[]; `useId`: `string`[]; `useImperativeHandle`: `string`[]; `useInsertionEffect`: `string`[]; `useLayoutEffect`: `string`[]; `useMemo`: `string`[]; `useOptimistic`: `string`[]; `useReducer`: `string`[]; `useRef`: `string`[]; `useState`: `string`[]; `useSyncExternalStore`: `string`[]; `useTransition`: `string`[]; \}; `importSource`: `string`; `jsxPragma`: `string`; `jsxPragmaFrag`: `string`; `polymorphicPropName`: `string`; `skipImportCheck`: `boolean`; `strict`: `boolean`; `version`: `string`; \}\>
+
+A helper function to coerce settings from a data object.
+
+## Parameters
+
+### data
+
+`unknown`
+
+The data object.
+
+## Returns
+
+`PartialObjectDeep`\<\{ `additionalComponents`: `object`[]; `additionalHooks`: \{ `use`: `string`[]; `useActionState`: `string`[]; `useCallback`: `string`[]; `useContext`: `string`[]; `useDebugValue`: `string`[]; `useDeferredValue`: `string`[]; `useEffect`: `string`[]; `useFormStatus`: `string`[]; `useId`: `string`[]; `useImperativeHandle`: `string`[]; `useInsertionEffect`: `string`[]; `useLayoutEffect`: `string`[]; `useMemo`: `string`[]; `useOptimistic`: `string`[]; `useReducer`: `string`[]; `useRef`: `string`[]; `useState`: `string`[]; `useSyncExternalStore`: `string`[]; `useTransition`: `string`[]; \}; `importSource`: `string`; `jsxPragma`: `string`; `jsxPragmaFrag`: `string`; `polymorphicPropName`: `string`; `skipImportCheck`: `boolean`; `strict`: `boolean`; `version`: `string`; \}\>
+
+settings The settings.
diff --git a/packages/shared/package.json b/packages/shared/package.json
@@ -46,8 +46,6 @@
     "@eslint-react/kit": "workspace:*",
     "@typescript-eslint/utils": "^8.30.1",
     "@zod/mini": "^4.0.0-beta.0",
-    "fast-equals": "^5.2.2",
-    "micro-memoize": "^4.1.3",
     "ts-pattern": "^5.7.0"
   },
   "devDependencies": {
diff --git a/packages/shared/src/settings.ts b/packages/shared/src/settings.ts
@@ -1,12 +1,11 @@
+/* eslint-disable jsdoc/require-param */
 import type { _ } from "@eslint-react/eff";
 import type { SharedConfigurationSettings } from "@typescript-eslint/utils/ts-eslint"; // eslint-disable-line @typescript-eslint/no-unused-vars
 import type { PartialDeep } from "type-fest";
 import type { CustomHooks, ESLintReactSettings } from "./schemas";
-import { identity } from "@eslint-react/eff";
+import { getOrElseUpdate, identity } from "@eslint-react/eff";
 import { RegExp as RE } from "@eslint-react/kit";
 import * as z from "@zod/mini";
-import { shallowEqual } from "fast-equals";
-import memoize from "micro-memoize";
 
 import { match, P } from "ts-pattern";
 import { getReactVersion } from "./get-react-version";
@@ -42,46 +41,47 @@ export interface ESLintReactSettingsNormalized {
 }
 
 /**
- * Unsafely casts settings from a data object from `context.settings`.
- * @internal
+ * A helper function to coerce settings from a data object.
  * @param data The data object.
  * @returns settings The settings.
  */
-export function unsafeDecodeSettings(data: unknown): PartialDeep<ESLintReactSettings> {
+export const coerceSettings = (data: unknown): PartialDeep<ESLintReactSettings> => {
   // @ts-expect-error - skip type checking for unsafe cast
   return (data?.["react-x"] ?? {}) as PartialDeep<ESLintReactSettings>;
-}
+};
+
+const decodeCache = new Map<unknown, ESLintReactSettings>();
 
 /**
  * Decodes settings from a data object from `context.settings`.
  * @internal
  * @param data The data object.
  * @returns settings The settings.
  */
-export const decodeSettings = memoize((data: unknown): ESLintReactSettings => {
-  return {
+export const decodeSettings = (data: unknown): ESLintReactSettings => {
+  return getOrElseUpdate(decodeCache, data, () => ({
     ...DEFAULT_ESLINT_REACT_SETTINGS,
     ...z.parse(ESLintSettingsSchema, data)?.["react-x"] ?? {},
-  };
-}, { isEqual: (a, b) => a === b });
+  }));
+};
+
+const normalizeCache = new Map<ESLintReactSettings, ESLintReactSettingsNormalized>();
 
 /**
- * The memoized version of `ESLintReactSettings`.
- * @param settings The settings.
- * @returns The normalized settings.
  * @internal
  */
-export const toNormalizedSettings = memoize(
-  ({
-    additionalComponents = [],
-    additionalHooks = {},
-    importSource = "react",
-    polymorphicPropName = "as",
-    skipImportCheck = true,
-    // strict = false,
-    version,
-    ...rest
-  }: ESLintReactSettings): ESLintReactSettingsNormalized => {
+export const normalizeSettings = (settings: ESLintReactSettings): ESLintReactSettingsNormalized => {
+  return getOrElseUpdate(normalizeCache, settings, () => {
+    const {
+      additionalComponents = [],
+      additionalHooks = {},
+      importSource = "react",
+      polymorphicPropName = "as",
+      skipImportCheck = true,
+      // strict = false,
+      version,
+      ...rest
+    } = settings;
     return {
       ...rest,
       additionalComponents: additionalComponents.map(({
@@ -109,12 +109,17 @@ export const toNormalizedSettings = memoize(
         .with(P.union(P.nullish, "", "detect"), () => getReactVersion("19.1.0"))
         .otherwise(identity),
     };
-  },
-  { isEqual: shallowEqual },
-);
+  });
+};
+
+const settingsCache = new Map<unknown, ESLintReactSettingsNormalized>();
 
 export function getSettingsFromContext(context: { settings: unknown }): ESLintReactSettingsNormalized {
-  return toNormalizedSettings(decodeSettings(context.settings));
+  return getOrElseUpdate(
+    settingsCache,
+    context.settings,
+    () => normalizeSettings(decodeSettings(context.settings)),
+  );
 }
 
 /**
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
