Fix false positive for dom/no-missing-button-type when specifying non-trivial expression as value of type attribute, closes #1247 (#1250)

Rel1cx · web-flow · commit 1a403ef3efda · 2025-09-30T12:14:26.000+08:00
diff --git a/.pkgs/configs/package.json b/.pkgs/configs/package.json
@@ -21,13 +21,13 @@
   "dependencies": {
     "@eslint/js": "^9.36.0",
     "@stylistic/eslint-plugin": "^5.4.0",
-    "eslint-plugin-de-morgan": "^1.3.1",
+    "eslint-plugin-de-morgan": "^2.0.0",
     "eslint-plugin-function": "^0.0.31",
     "eslint-plugin-jsdoc": "^60.5.0",
     "eslint-plugin-perfectionist": "^4.15.0",
     "eslint-plugin-regexp": "^2.10.0",
     "eslint-plugin-unicorn": "^61.0.2",
-    "typescript-eslint": "^8.44.1"
+    "typescript-eslint": "^8.45.0"
   },
   "peerDependencies": {
     "eslint": "^9.36.0",
diff --git a/.pkgs/eslint-plugin-local/package.json b/.pkgs/eslint-plugin-local/package.json
@@ -28,11 +28,11 @@
     "@eslint-react/var": "workspace:*",
     "@eslint/js": "^9.36.0",
     "@stylistic/eslint-plugin": "^5.4.0",
-    "@typescript-eslint/scope-manager": "^8.44.1",
-    "@typescript-eslint/type-utils": "^8.44.1",
-    "@typescript-eslint/types": "^8.44.1",
-    "@typescript-eslint/utils": "^8.44.1",
-    "eslint-plugin-de-morgan": "^1.3.1",
+    "@typescript-eslint/scope-manager": "^8.45.0",
+    "@typescript-eslint/type-utils": "^8.45.0",
+    "@typescript-eslint/types": "^8.45.0",
+    "@typescript-eslint/utils": "^8.45.0",
+    "eslint-plugin-de-morgan": "^2.0.0",
     "eslint-plugin-jsdoc": "^60.5.0",
     "eslint-plugin-perfectionist": "^4.15.0",
     "eslint-plugin-regexp": "^2.10.0",
diff --git a/apps/website/package.json b/apps/website/package.json
@@ -10,11 +10,11 @@
     "start": "next start"
   },
   "dependencies": {
-    "@effect-atom/atom-react": "^0.2.0",
+    "@effect-atom/atom-react": "^0.3.0",
     "@eslint-react/eff": "workspace:*",
     "bsky-react-post": "^0.1.7",
     "clsx": "^2.1.1",
-    "effect": "^3.17.14",
+    "effect": "^3.18.0",
     "fumadocs-core": "15.8.1",
     "fumadocs-docgen": "3.0.1",
     "fumadocs-mdx": "12.0.1",
@@ -30,7 +30,7 @@
     "twoslash": "^0.3.4"
   },
   "devDependencies": {
-    "@effect/language-service": "^0.41.0",
+    "@effect/language-service": "^0.41.1",
     "@eslint-react/eslint-plugin": "workspace:*",
     "@eslint-react/kit": "workspace:*",
     "@eslint-react/shared": "workspace:*",
@@ -45,7 +45,7 @@
     "@tsconfig/strictest": "^2.0.6",
     "@types/hast": "^3.0.4",
     "@types/mdx": "^2.0.13",
-    "@types/node": "^24.5.2",
+    "@types/node": "^24.6.0",
     "@types/react": "^19.1.15",
     "@types/react-dom": "^19.1.9",
     "dedent": "^1.7.0",
@@ -58,6 +58,6 @@
     "tailwindcss": "^4.1.13",
     "tailwindcss-animated": "^2.0.0",
     "typescript": "^5.9.2",
-    "typescript-eslint": "^8.44.1"
+    "typescript-eslint": "^8.45.0"
   }
 }
diff --git a/examples/next/package.json b/examples/next/package.json
@@ -23,14 +23,14 @@
     "@tsconfig/next": "^2.0.3",
     "@tsconfig/node22": "^22.0.2",
     "@tsconfig/strictest": "^2.0.6",
-    "@types/node": "^24.5.2",
+    "@types/node": "^24.6.0",
     "@types/react": "^19.1.15",
     "@types/react-dom": "^19.1.9",
     "eslint": "^9.36.0",
     "eslint-plugin-react-hooks": "^5.2.0",
     "eslint-plugin-react-refresh": "^0.4.22",
     "typescript": "^5.9.2",
-    "typescript-eslint": "^8.44.1"
+    "typescript-eslint": "^8.45.0"
   },
   "engines": {
     "node": ">=20.19.0"
diff --git a/examples/react-dom/package.json b/examples/react-dom/package.json
@@ -28,7 +28,7 @@
     "eslint-plugin-react-hooks": "^5.2.0",
     "eslint-plugin-react-refresh": "^0.4.22",
     "typescript": "^5.9.2",
-    "typescript-eslint": "^8.44.1",
+    "typescript-eslint": "^8.45.0",
     "vite": "^7.1.7"
   },
   "engines": {
diff --git a/examples/with-ts-blank-eslint-parser/package.json b/examples/with-ts-blank-eslint-parser/package.json
@@ -32,7 +32,7 @@
     "globals": "^16.4.0",
     "ts-blank-eslint-parser": "^0.4.4",
     "typescript": "^5.9.2",
-    "typescript-eslint": "^8.44.1",
+    "typescript-eslint": "^8.45.0",
     "vite": "^7.1.7"
   },
   "engines": {
diff --git a/package.json b/package.json
@@ -52,27 +52,27 @@
     "update:website": "tsx ./scripts/update-website.ts"
   },
   "devDependencies": {
-    "@effect/language-service": "^0.41.0",
-    "@effect/platform": "^0.91.1",
-    "@effect/platform-node": "^0.97.1",
+    "@effect/language-service": "^0.41.1",
+    "@effect/platform": "^0.92.0",
+    "@effect/platform-node": "^0.98.0",
     "@eslint/config-inspector": "^1.3.0",
     "@eslint/markdown": "^7.3.0",
     "@local/configs": "workspace:*",
     "@local/eslint-plugin-local": "workspace:*",
     "@radix-ui/react-toast": "^1.2.15",
     "@tsconfig/node22": "^22.0.2",
     "@tsconfig/strictest": "^2.0.6",
-    "@types/node": "^24.5.2",
+    "@types/node": "^24.6.0",
     "@types/react": "^19.1.15",
     "@types/react-dom": "^19.1.9",
-    "@typescript-eslint/parser": "^8.44.1",
-    "@typescript-eslint/rule-tester": "^8.44.1",
-    "@typescript-eslint/types": "^8.44.1",
+    "@typescript-eslint/parser": "^8.45.0",
+    "@typescript-eslint/rule-tester": "^8.45.0",
+    "@typescript-eslint/types": "^8.45.0",
     "@eslint/compat": "^1.4.0",
     "ansis": "^4.2.0",
     "dedent": "^1.7.0",
     "dprint": "^0.50.2",
-    "effect": "^3.17.14",
+    "effect": "^3.18.0",
     "eslint": "^9.36.0",
     "eslint-plugin-fast-import": "^1.4.4",
     "eslint-plugin-vitest": "^0.5.4",
@@ -94,7 +94,7 @@
     "typedoc-plugin-markdown": "^4.9.0",
     "typedoc-plugin-mdn-links": "^5.0.9",
     "typescript": "^5.9.2",
-    "typescript-eslint": "^8.44.1",
+    "typescript-eslint": "^8.45.0",
     "vitest": "^3.2.4"
   },
   "packageManager": "pnpm@10.17.1",
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -39,9 +39,9 @@
     "@eslint-react/kit": "workspace:*",
     "@eslint-react/shared": "workspace:*",
     "@eslint-react/var": "workspace:*",
-    "@typescript-eslint/scope-manager": "^8.44.1",
-    "@typescript-eslint/types": "^8.44.1",
-    "@typescript-eslint/utils": "^8.44.1",
+    "@typescript-eslint/scope-manager": "^8.45.0",
+    "@typescript-eslint/types": "^8.45.0",
+    "@typescript-eslint/utils": "^8.45.0",
     "birecord": "^0.1.1",
     "ts-pattern": "^5.8.0"
   },
diff --git a/packages/plugins/eslint-plugin-react-debug/package.json b/packages/plugins/eslint-plugin-react-debug/package.json
@@ -47,10 +47,10 @@
     "@eslint-react/kit": "workspace:*",
     "@eslint-react/shared": "workspace:*",
     "@eslint-react/var": "workspace:*",
-    "@typescript-eslint/scope-manager": "^8.44.1",
-    "@typescript-eslint/type-utils": "^8.44.1",
-    "@typescript-eslint/types": "^8.44.1",
-    "@typescript-eslint/utils": "^8.44.1",
+    "@typescript-eslint/scope-manager": "^8.45.0",
+    "@typescript-eslint/type-utils": "^8.45.0",
+    "@typescript-eslint/types": "^8.45.0",
+    "@typescript-eslint/utils": "^8.45.0",
     "string-ts": "^2.2.1",
     "ts-pattern": "^5.8.0"
   },
diff --git a/packages/plugins/eslint-plugin-react-dom/package.json b/packages/plugins/eslint-plugin-react-dom/package.json
@@ -47,9 +47,9 @@
     "@eslint-react/kit": "workspace:*",
     "@eslint-react/shared": "workspace:*",
     "@eslint-react/var": "workspace:*",
-    "@typescript-eslint/scope-manager": "^8.44.1",
-    "@typescript-eslint/types": "^8.44.1",
-    "@typescript-eslint/utils": "^8.44.1",
+    "@typescript-eslint/scope-manager": "^8.45.0",
+    "@typescript-eslint/types": "^8.45.0",
+    "@typescript-eslint/utils": "^8.45.0",
     "compare-versions": "^6.1.1",
     "string-ts": "^2.2.1",
     "ts-pattern": "^5.8.0"
diff --git a/packages/plugins/eslint-plugin-react-dom/src/rules/no-missing-button-type.spec.ts b/packages/plugins/eslint-plugin-react-dom/src/rules/no-missing-button-type.spec.ts
@@ -30,31 +30,6 @@ ruleTester.run(RULE_NAME, rule, {
         },
       ],
     },
-    {
-      code: tsx`<button type />;`,
-      errors: [
-        {
-          messageId: "noMissingButtonType",
-          suggestions: [
-            {
-              messageId: "addButtonType",
-              data: { type: "button" },
-              output: tsx`<button type="button" />;`,
-            },
-            {
-              messageId: "addButtonType",
-              data: { type: "submit" },
-              output: tsx`<button type="submit" />;`,
-            },
-            {
-              messageId: "addButtonType",
-              data: { type: "reset" },
-              output: tsx`<button type="reset" />;`,
-            },
-          ],
-        },
-      ],
-    },
     {
       code: tsx`<button>Click me</button>;`,
       errors: [
@@ -136,5 +111,29 @@ ruleTester.run(RULE_NAME, rule, {
           return <button {...props}>Click me</button>;
       }
     `,
+    tsx`
+      const type = "button";
+
+      function App() {
+          return <button type={type}>Click me</button>;
+      }
+    `,
+    tsx`
+      function App({ type }: { type: string }) {
+          return <button type={type}>Click me</button>;
+      }
+    `,
+    tsx`
+      const defaultProps = { type: "button" };
+      function App(props = defaultProps) {
+          return <button type={props.type}>Click me</button>;
+      }
+    `,
+    tsx`
+      const buttonAttrs = { type: "button" };
+      function App() {
+          return <button {...buttonAttrs}>Click me</button>;
+      }
+    `,
   ],
 });
diff --git a/packages/plugins/eslint-plugin-react-dom/src/rules/no-missing-button-type.ts b/packages/plugins/eslint-plugin-react-dom/src/rules/no-missing-button-type.ts
@@ -1,4 +1,4 @@
-import { getAttribute, resolveAttributeValue } from "@eslint-react/core";
+import { getAttribute } from "@eslint-react/core";
 import type { RuleContext, RuleFeature, RuleSuggest } from "@eslint-react/kit";
 import type { RuleFixer, RuleListener } from "@typescript-eslint/utils/ts-eslint";
 import type { CamelCase } from "string-ts";
@@ -43,23 +43,12 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
       const { domElementType } = resolver.resolve(node);
       if (domElementType !== "button") return;
       const getAttributeEx = getAttribute(context, node.openingElement.attributes, context.sourceCode.getScope(node));
-      const typeAttribute = getAttributeEx("type");
-      if (typeAttribute == null) {
-        context.report({
-          messageId: "noMissingButtonType",
-          node: node.openingElement,
-          suggest: getSuggest((type) => (fixer: RuleFixer) => {
-            return fixer.insertTextAfter(node.openingElement.name, ` type="${type}"`);
-          }),
-        });
-        return;
-      }
-      if (typeof resolveAttributeValue(context, typeAttribute).toStatic("type") === "string") return;
+      if (getAttributeEx("type") != null) return;
       context.report({
         messageId: "noMissingButtonType",
-        node: typeAttribute,
+        node: node.openingElement,
         suggest: getSuggest((type) => (fixer: RuleFixer) => {
-          return fixer.replaceText(typeAttribute, `type="${type}"`);
+          return fixer.insertTextAfter(node.openingElement.name, ` type="${type}"`);
         }),
       });
     },
diff --git a/packages/plugins/eslint-plugin-react-hooks-extra/package.json b/packages/plugins/eslint-plugin-react-hooks-extra/package.json
@@ -48,10 +48,10 @@
     "@eslint-react/kit": "workspace:*",
     "@eslint-react/shared": "workspace:*",
     "@eslint-react/var": "workspace:*",
-    "@typescript-eslint/scope-manager": "^8.44.1",
-    "@typescript-eslint/type-utils": "^8.44.1",
-    "@typescript-eslint/types": "^8.44.1",
-    "@typescript-eslint/utils": "^8.44.1",
+    "@typescript-eslint/scope-manager": "^8.45.0",
+    "@typescript-eslint/type-utils": "^8.45.0",
+    "@typescript-eslint/types": "^8.45.0",
+    "@typescript-eslint/utils": "^8.45.0",
     "string-ts": "^2.2.1",
     "ts-pattern": "^5.8.0"
   },
diff --git a/packages/plugins/eslint-plugin-react-naming-convention/package.json b/packages/plugins/eslint-plugin-react-naming-convention/package.json
@@ -47,10 +47,10 @@
     "@eslint-react/kit": "workspace:*",
     "@eslint-react/shared": "workspace:*",
     "@eslint-react/var": "workspace:*",
-    "@typescript-eslint/scope-manager": "^8.44.1",
-    "@typescript-eslint/type-utils": "^8.44.1",
-    "@typescript-eslint/types": "^8.44.1",
-    "@typescript-eslint/utils": "^8.44.1",
+    "@typescript-eslint/scope-manager": "^8.45.0",
+    "@typescript-eslint/type-utils": "^8.45.0",
+    "@typescript-eslint/types": "^8.45.0",
+    "@typescript-eslint/utils": "^8.45.0",
     "string-ts": "^2.2.1",
     "ts-pattern": "^5.8.0"
   },
diff --git a/packages/plugins/eslint-plugin-react-web-api/package.json b/packages/plugins/eslint-plugin-react-web-api/package.json
@@ -47,9 +47,9 @@
     "@eslint-react/kit": "workspace:*",
     "@eslint-react/shared": "workspace:*",
     "@eslint-react/var": "workspace:*",
-    "@typescript-eslint/scope-manager": "^8.44.1",
-    "@typescript-eslint/types": "^8.44.1",
-    "@typescript-eslint/utils": "^8.44.1",
+    "@typescript-eslint/scope-manager": "^8.45.0",
+    "@typescript-eslint/types": "^8.45.0",
+    "@typescript-eslint/utils": "^8.45.0",
     "string-ts": "^2.2.1",
     "ts-pattern": "^5.8.0"
   },
diff --git a/packages/plugins/eslint-plugin-react-x/package.json b/packages/plugins/eslint-plugin-react-x/package.json
@@ -46,10 +46,10 @@
     "@eslint-react/kit": "workspace:*",
     "@eslint-react/shared": "workspace:*",
     "@eslint-react/var": "workspace:*",
-    "@typescript-eslint/scope-manager": "^8.44.1",
-    "@typescript-eslint/type-utils": "^8.44.1",
-    "@typescript-eslint/types": "^8.44.1",
-    "@typescript-eslint/utils": "^8.44.1",
+    "@typescript-eslint/scope-manager": "^8.45.0",
+    "@typescript-eslint/type-utils": "^8.45.0",
+    "@typescript-eslint/types": "^8.45.0",
+    "@typescript-eslint/utils": "^8.45.0",
     "compare-versions": "^6.1.1",
     "is-immutable-type": "^5.0.1",
     "string-ts": "^2.2.1",
diff --git a/packages/plugins/eslint-plugin/package.json b/packages/plugins/eslint-plugin/package.json
@@ -46,10 +46,10 @@
     "@eslint-react/eff": "workspace:*",
     "@eslint-react/kit": "workspace:*",
     "@eslint-react/shared": "workspace:*",
-    "@typescript-eslint/scope-manager": "^8.44.1",
-    "@typescript-eslint/type-utils": "^8.44.1",
-    "@typescript-eslint/types": "^8.44.1",
-    "@typescript-eslint/utils": "^8.44.1",
+    "@typescript-eslint/scope-manager": "^8.45.0",
+    "@typescript-eslint/type-utils": "^8.45.0",
+    "@typescript-eslint/types": "^8.45.0",
+    "@typescript-eslint/utils": "^8.45.0",
     "eslint-plugin-react-debug": "workspace:*",
     "eslint-plugin-react-dom": "workspace:*",
     "eslint-plugin-react-hooks-extra": "workspace:*",
diff --git a/packages/shared/package.json b/packages/shared/package.json
@@ -36,7 +36,7 @@
   "dependencies": {
     "@eslint-react/eff": "workspace:*",
     "@eslint-react/kit": "workspace:*",
-    "@typescript-eslint/utils": "^8.44.1",
+    "@typescript-eslint/utils": "^8.45.0",
     "ts-pattern": "^5.8.0",
     "zod": "^4.1.11"
   },
diff --git a/packages/utilities/ast/package.json b/packages/utilities/ast/package.json
@@ -34,9 +34,9 @@
   },
   "dependencies": {
     "@eslint-react/eff": "workspace:*",
-    "@typescript-eslint/types": "^8.44.1",
-    "@typescript-eslint/typescript-estree": "^8.44.1",
-    "@typescript-eslint/utils": "^8.44.1",
+    "@typescript-eslint/types": "^8.45.0",
+    "@typescript-eslint/typescript-estree": "^8.45.0",
+    "@typescript-eslint/utils": "^8.45.0",
     "string-ts": "^2.2.1"
   },
   "devDependencies": {
diff --git a/packages/utilities/kit/package.json b/packages/utilities/kit/package.json
@@ -35,7 +35,7 @@
   },
   "dependencies": {
     "@eslint-react/eff": "workspace:*",
-    "@typescript-eslint/utils": "^8.44.1"
+    "@typescript-eslint/utils": "^8.45.0"
   },
   "devDependencies": {
     "@local/configs": "workspace:*",
diff --git a/packages/utilities/var/package.json b/packages/utilities/var/package.json
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
