refactor: deprecate no-implicit-key and no-complicated-conditional-rendering

Author: Rel1cx

CHANGELOG.md

@@ -5,10 +5,14 @@
 - Rule `no-class-component` rule now allows class components with a `componentDidCatch` method (Thanks to [@christopher-buss](https://github.com/christopher-buss)).
 - Settings `reactOptions` now supports `importSource` to specify the import source for React (Thanks to [@christopher-buss](https://github.com/christopher-buss)).
 
+### 🗑️ Deprecations
+
+- Deprecate rule `no-implicit-key` because it is stylistic and opinionated.
+- Deprecate rule `no-complicated-conditional-rendering` because it is stylistic and opinionated.
+
 ### 🪄 Improvements
 
 - Refactor React pragma and import name retrieval utils to support custom import source.
-- Refactor rule `no-complicated-conditional-rendering`'s detection logic, make it more accurate.
 - Update `@typescript-eslint`'s packages to `7.8.0`.
 
 ## v1.5.10 (Sun 28 Apr 2024)

packages/plugins/eslint-plugin-react-core/src/rules/no-complicated-conditional-rendering.ts

@@ -10,6 +10,7 @@ export type MessageID = ConstantCase<typeof RULE_NAME>;
 export default createRule<[], MessageID>({
   meta: {
     type: "problem",
+    deprecated: true,
     docs: {
       description: "disallow complicated conditional rendering",
       requiresTypeChecking: true,

packages/plugins/eslint-plugin-react-core/src/rules/no-implicit-key.ts

@@ -14,6 +14,7 @@ export type MessageID = ConstantCase<typeof RULE_NAME>;
 export default createRule<[], MessageID>({
   meta: {
     type: "problem",
+    deprecated: true,
     docs: {
       description: "disallow spreading 'key' from objects.",
       recommended: "recommended",

website/pages/rules/no-complicated-conditional-rendering.mdx

@@ -1,4 +1,4 @@
-# no-complicated-conditional-rendering
+# no-complicated-conditional-rendering (Deprecated)
 
 ## Rule category
 

website/pages/rules/no-implicit-key.mdx

@@ -1,4 +1,4 @@
-# no-implicit-key
+# no-implicit-key (Deprecated)
 
 ## Rule category