Add line/column info to jsx-dollar test errors

Rel1cx · Rel1cx · commit 21c97215cd3e · 2025-11-02T16:03:09.000+08:00
diff --git a/packages/plugins/eslint-plugin-react-x/src/rules/jsx-dollar.spec.ts b/packages/plugins/eslint-plugin-react-x/src/rules/jsx-dollar.spec.ts
@@ -12,6 +12,10 @@ ruleTester.run(RULE_NAME, rule, {
       errors: [
         {
           messageId: "jsxDollar",
+          column: 35,
+          endColumn: 36,
+          endLine: 1,
+          line: 1,
           suggestions: [
             {
               messageId: "removeDollarSign",
@@ -32,6 +36,10 @@ ruleTester.run(RULE_NAME, rule, {
       errors: [
         {
           messageId: "jsxDollar",
+          column: 23,
+          endColumn: 24,
+          endLine: 2,
+          line: 2,
           suggestions: [
             {
               messageId: "removeDollarSign",
@@ -54,6 +62,10 @@ ruleTester.run(RULE_NAME, rule, {
       errors: [
         {
           messageId: "jsxDollar",
+          column: 17,
+          endColumn: 18,
+          endLine: 2,
+          line: 2,
           suggestions: [
             {
               messageId: "removeDollarSign",
@@ -76,6 +88,10 @@ ruleTester.run(RULE_NAME, rule, {
       errors: [
         {
           messageId: "jsxDollar",
+          column: 23,
+          endColumn: 24,
+          endLine: 2,
+          line: 2,
           suggestions: [
             {
               messageId: "removeDollarSign",
diff --git a/packages/plugins/eslint-plugin-react-x/src/rules/jsx-dollar.ts b/packages/plugins/eslint-plugin-react-x/src/rules/jsx-dollar.ts
@@ -56,7 +56,7 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
             line: pos.line,
           },
           start: {
-            column: child.loc.start.column + child.value.length - 1,
+            column: pos.column - 1,
             line: pos.line,
           },
         },

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,10 @@ ruleTester.run(RULE_NAME, rule, {`
`12`	`12`	`errors: [`
`13`	`13`	`{`
`14`	`14`	`messageId: "jsxDollar",`
	`15`	`+ column: 35,`
	`16`	`+ endColumn: 36,`
	`17`	`+ endLine: 1,`
	`18`	`+ line: 1,`
`15`	`19`	`suggestions: [`
`16`	`20`	`{`
`17`	`21`	`messageId: "removeDollarSign",`
`@@ -32,6 +36,10 @@ ruleTester.run(RULE_NAME, rule, {`
`32`	`36`	`errors: [`
`33`	`37`	`{`
`34`	`38`	`messageId: "jsxDollar",`
	`39`	`+ column: 23,`
	`40`	`+ endColumn: 24,`
	`41`	`+ endLine: 2,`
	`42`	`+ line: 2,`
`35`	`43`	`suggestions: [`
`36`	`44`	`{`
`37`	`45`	`messageId: "removeDollarSign",`
`@@ -54,6 +62,10 @@ ruleTester.run(RULE_NAME, rule, {`
`54`	`62`	`errors: [`
`55`	`63`	`{`
`56`	`64`	`messageId: "jsxDollar",`
	`65`	`+ column: 17,`
	`66`	`+ endColumn: 18,`
	`67`	`+ endLine: 2,`
	`68`	`+ line: 2,`
`57`	`69`	`suggestions: [`
`58`	`70`	`{`
`59`	`71`	`messageId: "removeDollarSign",`
`@@ -76,6 +88,10 @@ ruleTester.run(RULE_NAME, rule, {`
`76`	`88`	`errors: [`
`77`	`89`	`{`
`78`	`90`	`messageId: "jsxDollar",`
	`91`	`+ column: 23,`
	`92`	`+ endColumn: 24,`
	`93`	`+ endLine: 2,`
	`94`	`+ line: 2,`
`79`	`95`	`suggestions: [`
`80`	`96`	`{`
`81`	`97`	`messageId: "removeDollarSign",`