fix(plugins/x): 'no-leaked-conditional-rendering' report empty string, closes #853 (#857)

Author: Rel1cx

package.json

@@ -78,7 +78,7 @@
     "eslint-import-resolver-oxc": "^0.4.0",
     "eslint-plugin-better-mutation": "^1.5.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
-    "eslint-plugin-eslint-plugin": "^6.3.1",
+    "eslint-plugin-eslint-plugin": "^6.3.2",
     "eslint-plugin-import-x": "^4.4.2",
     "eslint-plugin-jsdoc": "^50.5.0",
     "eslint-plugin-perfectionist": "^3.9.1",

packages/plugins/eslint-plugin-react-x/src/rules/no-leaked-conditional-rendering.spec.ts

@@ -3,6 +3,29 @@ import rule, { RULE_NAME } from "./no-leaked-conditional-rendering";
 
 ruleTesterWithTypes.run(RULE_NAME, rule, {
   invalid: [
+    {
+      code: /* tsx */ `
+        /// <reference types="react" />
+        /// <reference types="react-dom" />
+
+        const a = <>{"" && <Something />}</>;
+      `,
+      errors: [
+        { messageId: "noLeakedConditionalRendering" },
+      ],
+    },
+    {
+      code: /* tsx */ `
+        /// <reference types="react" />
+        /// <reference types="react-dom" />
+
+        const someString = "";
+        const a = <>{someString && <Something />}</>;
+      `,
+      errors: [
+        { messageId: "noLeakedConditionalRendering" },
+      ],
+    },
     {
       code: /* tsx */ `
         /// <reference types="react" />
@@ -400,7 +423,7 @@ ruleTesterWithTypes.run(RULE_NAME, rule, {
 
       const a = <>
                 {0 ? <Foo /> : null}
-                {'' && <Foo />}
+                {'0' && <Foo />}
                 {NaN ? <Foo /> : null}
                 </>
     `,

packages/plugins/eslint-plugin-react-x/src/rules/no-leaked-conditional-rendering.ts

@@ -55,7 +55,6 @@ const allowedVariants = [
   "nullish",
   "object",
   "string",
-  "falsy string",
   "falsy boolean",
   "truthy bigint",
   "truthy boolean",