refactor: replace returnTrue/returnFalse with constTrue/constFalse for consistency

Author: Rel1cx

packages/core/src/hook/is.ts

@@ -1,5 +1,5 @@
 import * as AST from "@eslint-react/ast";
-import { _, flip, returnFalse } from "@eslint-react/eff";
+import { _, constFalse, flip } from "@eslint-react/eff";
 import type { RuleContext } from "@eslint-react/shared";
 import { unsafeDecodeSettings } from "@eslint-react/shared";
 import type { TSESTree } from "@typescript-eslint/types";
@@ -34,7 +34,7 @@ export function isReactHookCall(node: TSESTree.Node | _) {
 }
 
 export function isReactHookCallWithName(node: TSESTree.CallExpression | _, context: RuleContext) {
-  if (node == null) return returnFalse;
+  if (node == null) return constFalse;
   const settings = unsafeDecodeSettings(context.settings);
   const importSource = settings.importSource ?? "react";
   const initialScope = context.sourceCode.getScope(node);
@@ -59,7 +59,7 @@ export function isReactHookCallWithName(node: TSESTree.CallExpression | _, conte
 }
 
 export function isReactHookCallWithNameLoose(node: TSESTree.CallExpression | _) {
-  if (node == null) return returnFalse;
+  if (node == null) return constFalse;
   return (name: string) => {
     switch (node.callee.type) {
       case T.Identifier:

packages/plugins/eslint-plugin-react-hooks-extra/src/utils/is-from-hook-call.ts

@@ -1,5 +1,5 @@
 import { isReactHookCallWithNameAlias } from "@eslint-react/core";
-import { returnTrue } from "@eslint-react/eff";
+import { constTrue } from "@eslint-react/eff";
 import type { ESLintReactSettingsNormalized, REACT_BUILD_IN_HOOKS, RuleContext } from "@eslint-react/shared";
 import * as VAR from "@eslint-react/var";
 import type { TSESTree } from "@typescript-eslint/types";
@@ -9,7 +9,7 @@ export function isFromHookCall(
   name: (typeof REACT_BUILD_IN_HOOKS)[number],
   context: RuleContext,
   settings: ESLintReactSettingsNormalized,
-  predicate: (topLevelId: TSESTree.Identifier, call: TSESTree.CallExpression) => boolean = returnTrue,
+  predicate: (topLevelId: TSESTree.Identifier, call: TSESTree.CallExpression) => boolean = constTrue,
 ) {
   const hookAlias = settings.additionalHooks[name] ?? [];
   return (topLevelId: TSESTree.Identifier) => {

packages/plugins/eslint-plugin-react-naming-convention/src/rules/component-name.ts

@@ -1,7 +1,7 @@
 import * as AST from "@eslint-react/ast";
 import { useComponentCollector, useComponentCollectorLegacy } from "@eslint-react/core";
 import type { _ } from "@eslint-react/eff";
-import { returnFalse } from "@eslint-react/eff";
+import { constFalse } from "@eslint-react/eff";
 import * as JSX from "@eslint-react/jsx";
 import type { RuleFeature } from "@eslint-react/shared";
 import { RE_CONSTANT_CASE, RE_PASCAL_CASE } from "@eslint-react/shared";
@@ -113,7 +113,7 @@ function validate(name: string | _, options: ReturnType<typeof normalizeOptions>
       }
       return RE_PASCAL_CASE.test(normalized);
     })
-    .otherwise(returnFalse);
+    .otherwise(constFalse);
 }
 
 export default createRule<Options, MessageID>({

packages/utilities/ast/src/is-key-literal.ts

@@ -1,4 +1,4 @@
-import { returnFalse, returnTrue } from "@eslint-react/eff";
+import { constFalse, constTrue } from "@eslint-react/eff";
 import type { TSESTree } from "@typescript-eslint/types";
 import { AST_NODE_TYPES as T } from "@typescript-eslint/types";
 import { match } from "ts-pattern";
@@ -8,8 +8,8 @@ export function isKeyLiteralLike(
   property: TSESTree.Node,
 ) {
   return match(property)
-    .with({ type: T.Literal }, returnTrue)
-    .with({ type: T.TemplateLiteral, expressions: [] }, returnTrue)
+    .with({ type: T.Literal }, constTrue)
+    .with({ type: T.TemplateLiteral, expressions: [] }, constTrue)
     .with({ type: T.Identifier }, () => !node.computed)
-    .otherwise(returnFalse);
+    .otherwise(constFalse);
 }

packages/utilities/eff/src/index.ts

@@ -38,28 +38,17 @@ export function identity<T>(x: T): T {
 /**
  * Do nothing and return void
  */
-export function returnVoid(): void {}
+export const constVoid = () => {};
 
 /**
  * Do nothing and return true
  */
-export function returnTrue(): true {
-  return true;
-}
+export const constTrue = () => true as const;
 
 /**
  * Do nothing and return false
  */
-export function returnFalse(): false {
-  return false;
-}
-
-/**
- * Do nothing and return undefined
- */
-export function returnUndefined(): undefined {
-  return undefined;
-}
+export const constFalse = () => false as const;
 
 // Ported from https://github.com/Effect-TS/effect/blob/main/packages/effect/src/Function.ts
 /**

packages/utilities/jsx/src/find-parent-attribute.ts

@@ -1,6 +1,6 @@
 import * as AST from "@eslint-react/ast";
 import type { _ } from "@eslint-react/eff";
-import { returnTrue } from "@eslint-react/eff";
+import { constTrue } from "@eslint-react/eff";
 import type { TSESTree } from "@typescript-eslint/types";
 import { AST_NODE_TYPES as T } from "@typescript-eslint/types";
 
@@ -12,7 +12,7 @@ import { AST_NODE_TYPES as T } from "@typescript-eslint/types";
  */
 export function findParentAttribute(
   node: TSESTree.Node,
-  test: (node: TSESTree.JSXAttribute) => boolean = returnTrue,
+  test: (node: TSESTree.JSXAttribute) => boolean = constTrue,
 ): TSESTree.JSXAttribute | _ {
   const guard = (node: TSESTree.Node): node is TSESTree.JSXAttribute => {
     return node.type === T.JSXAttribute && test(node);