refactor(ast): reorganize array method utilities

Author: Rel1cx

packages/core/src/component/component-definition.ts

@@ -39,7 +39,7 @@ export function isValidComponentDefinition(context: RuleContext, node: AST.TSEST
   if (hint & ComponentDetectionHint.SkipClassProperty && isFunctionOfClassProperty(node.parent)) {
     return false;
   }
-  if (hint & ComponentDetectionHint.SkipArrayMapArgument && AST.isArrayMapCallLoose(node.parent)) {
+  if (hint & ComponentDetectionHint.SkipArrayMapArgument && AST.isArrayMapCall(node.parent)) {
     return false;
   }
   const boundaryNode = AST.findParentNode(

packages/plugins/eslint-plugin-react-x/src/rules/no-array-index-key.ts

@@ -51,7 +51,8 @@ function getMapIndexParamName(context: RuleContext, node: TSESTree.CallExpressio
     return _;
   }
   const { name } = callee.property;
-  if (!AST.ITERATOR_FUNCTION_INDEX_PARAM_POSITION.has(name)) {
+  const indexPosition = AST.getArrayMethodIndexParamPosition(name);
+  if (indexPosition === -1) {
     return _;
   }
   const callbackArg = node.arguments[isUsingReactChildren(context, node) ? 1 : 0];
@@ -62,14 +63,10 @@ function getMapIndexParamName(context: RuleContext, node: TSESTree.CallExpressio
     return _;
   }
   const { params } = callbackArg;
-  const indexParamPosition = AST.ITERATOR_FUNCTION_INDEX_PARAM_POSITION.get(name);
-  if (indexParamPosition == null) {
+  if (params.length < indexPosition + 1) {
     return _;
   }
-  if (params.length < indexParamPosition + 1) {
-    return _;
-  }
-  const param = params.at(indexParamPosition);
+  const param = params.at(indexPosition);
 
   return param != null && "name" in param
     ? param.name

packages/plugins/eslint-plugin-react-x/src/rules/no-duplicate-key.ts

@@ -69,7 +69,7 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
           break;
         }
         default: {
-          const call = AST.findParentNode(jsxElement, AST.isArrayMapCallLoose);
+          const call = AST.findParentNode(jsxElement, AST.isArrayMapCall);
           const iter = AST.findParentNode(jsxElement, (n) => n === call || AST.isFunction(n));
           if (!AST.isFunction(iter)) return;
           const arg0 = call?.arguments[0];

packages/plugins/eslint-plugin-react-x/src/rules/no-missing-key.ts

@@ -115,7 +115,7 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
       if (state.isWithinChildrenToArray) {
         return;
       }
-      const isMapCall = AST.isArrayMapCallLoose(node);
+      const isMapCall = AST.isArrayMapCall(node);
       if (!isMapCall && !isArrayFromCall(node)) {
         return;
       }

packages/utilities/ast/src/array-methods.ts

@@ -0,0 +1,29 @@
+import type { TSESTree } from "@typescript-eslint/types";
+import { AST_NODE_TYPES as T } from "@typescript-eslint/types";
+
+const indexParamPosition = new Map<string, number>([
+  ["every", 1],
+  ["filter", 1],
+  ["find", 1],
+  ["findIndex", 1],
+  ["findLast", 1],
+  ["findLastIndex", 1],
+  ["flatMap", 1],
+  ["forEach", 1],
+  ["map", 1],
+  ["reduce", 2],
+  ["reduceRight", 2],
+  ["some", 1],
+]);
+
+export function getArrayMethodIndexParamPosition(methodName: string) {
+  return indexParamPosition.get(methodName) ?? -1;
+}
+
+export function isArrayMapCall(node: TSESTree.Node): node is TSESTree.CallExpression {
+  if (node.type !== T.CallExpression) return false;
+  if (node.callee.type !== T.MemberExpression) return false;
+  if (node.callee.property.type !== T.Identifier) return false;
+  const { name } = node.callee.property;
+  return name === "map" || name.endsWith("Map");
+}

packages/utilities/ast/src/constants.ts

@@ -1,4 +1,4 @@
-export * from "./constants";
+export * from "./array-methods";
 export * from "./find-parent-node";
 export * from "./function-init-path";
 export * from "./get-class-identifier";
@@ -11,7 +11,6 @@ export * from "./get-nested-return-statements";
 export * from "./get-property-name";
 export * from "./get-top-level-identifier";
 export * from "./is";
-export * from "./is-array-map-call";
 export * from "./is-empty-function";
 export * from "./is-line-break";
 export * from "./is-literal";