chore: add eslint-plugin-de-morgan and update linting scripts

Author: Rel1cx

apps/website/eslint.config.mjs

@@ -1,11 +1,12 @@
 import eslintJs from "@eslint/js";
 import eslintReact from "@eslint-react/eslint-plugin";
 import eslintMarkdown from "@eslint/markdown";
+import eslintPluginDeMorgan from "eslint-plugin-de-morgan";
 import eslintPluginMdx from "eslint-plugin-mdx";
 import eslintPluginNext from "@next/eslint-plugin-next";
+import eslintPluginPerfectionist from "eslint-plugin-perfectionist";
 import eslintPluginReactHooks from "eslint-plugin-react-hooks";
 import eslintPluginReactRefresh from "eslint-plugin-react-refresh";
-import eslintPluginPerfectionist from "eslint-plugin-perfectionist";
 import eslintPluginSimpleImportSort from "eslint-plugin-simple-import-sort";
 import eslintPluginUnicorn from "eslint-plugin-unicorn";
 import tseslint from "typescript-eslint";
@@ -72,6 +73,7 @@ export default tseslint.config(
     extends: [
       eslintJs.configs.recommended,
       tseslint.configs.recommended,
+      eslintPluginDeMorgan.configs.recommended,
       eslintPluginPerfectionist.configs["recommended-natural"],
     ],
     plugins: {

apps/website/package.json

@@ -5,9 +5,11 @@
   "scripts": {
     "build": "next build",
     "dev": "next dev",
+    "lint": "pnpm run lint:ts && pnpm run lint:type",
     "lint:markup": "markuplint \"**/*.{jsx,tsx}\"",
     "lint:ts": "eslint .",
-    "prepare": "fumadocs-mdx",
+    "lint:type": "tsc --noEmit",
+    "prepare": "fumadocs-mdx && pnpm run build",
     "start": "next start"
   },
   "dependencies": {
@@ -45,6 +47,7 @@
     "autoprefixer": "^10.4.20",
     "dedent": "^1.5.3",
     "eslint": "^9.20.1",
+    "eslint-plugin-de-morgan": "^1.0.0",
     "eslint-plugin-import-x": "^4.6.1",
     "eslint-plugin-mdx": "^3.1.5",
     "eslint-plugin-perfectionist": "^4.8.0",

eslint.config.ts

@@ -5,14 +5,15 @@ import url from "node:url";
 import eslintJs from "@eslint/js";
 import eslintMarkdown from "@eslint/markdown";
 import eslintStylistic from "@stylistic/eslint-plugin";
+import eslintConfigFlatGitignore from "eslint-config-flat-gitignore";
+import eslintPluginDeMorgan from "eslint-plugin-de-morgan";
 import eslintPluginJsdoc from "eslint-plugin-jsdoc";
 import eslintPluginLocal from "@local/eslint-plugin-local";
 import eslintPluginPerfectionist from "eslint-plugin-perfectionist";
 import eslintPluginRegexp from "eslint-plugin-regexp";
 import eslintPluginSimpleImportSort from "eslint-plugin-simple-import-sort";
 import eslintPluginUnicorn from "eslint-plugin-unicorn";
 import eslintPluginVitest from "eslint-plugin-vitest";
-import eslintConfigFlatGitignore from "eslint-config-flat-gitignore";
 import tseslint from "typescript-eslint";
 
 const dirname = url.fileURLToPath(new URL(".", import.meta.url));
@@ -28,6 +29,13 @@ const GLOB_TEST = [
 // const GLOB_YAML = ["*.{yaml,yml}", "**/*.{yaml,yml}"];
 const GLOB_CONFIG = ["*.config.{ts,tsx,cts,mts}", "**/*.config.{ts,tsx,cts,mts}"];
 const GLOB_SCRIPT = ["scripts/**/*.{ts,cts,mts}"];
+const GLOB_IGNORES = [
+  ...eslintConfigFlatGitignore().ignores,
+  "apps",
+  "docs",
+  "test",
+  "examples",
+];
 
 const templateIndentAnnotations = [
   "outdent",
@@ -83,7 +91,10 @@ const enableTypeCheckedRules = {
 const disableTypeCheckedRules = Object.fromEntries(Object.keys(enableTypeCheckedRules).map((x) => [x, "off"]));
 
 export default tseslint.config(
-  eslintConfigFlatGitignore(),
+  {
+    name: "global-ignores",
+    ignores: GLOB_IGNORES,
+  },
   {
     extends: [
       eslintMarkdown.configs.recommended,
@@ -98,20 +109,12 @@ export default tseslint.config(
       "markdown/no-missing-label-refs": "off",
     },
   },
-  {
-    name: "global-ignores",
-    ignores: [
-      "apps",
-      "docs",
-      "test",
-      "examples",
-    ],
-  },
   {
     files: [...GLOB_JS, ...GLOB_TS],
     extends: [
       eslintJs.configs.recommended,
       ...tseslint.configs.strict,
+      eslintPluginDeMorgan.configs.recommended,
       eslintPluginPerfectionist.configs["recommended-natural"],
       eslintPluginRegexp.configs["flat/recommended"],
       eslintPluginJsdoc.configs["flat/recommended-typescript-error"],

package.json

@@ -78,6 +78,7 @@
     "esbuild": "^0.25.0",
     "eslint": "^9.20.1",
     "eslint-config-flat-gitignore": "^2.0.0",
+    "eslint-plugin-de-morgan": "^1.0.0",
     "eslint-plugin-jsdoc": "^50.6.3",
     "eslint-plugin-perfectionist": "^4.8.0",
     "eslint-plugin-regexp": "^2.7.0",

packages/plugins/eslint-plugin-react-hooks-extra/src/utils/is-from-use-state-call.ts

@@ -7,7 +7,7 @@ import { isFromHookCall } from "./is-from-hook-call";
 export function isFromUseStateCall(context: RuleContext, settings: ESLintReactSettingsNormalized) {
   const predicate = (topLevelId: TSESTree.Identifier, call: TSESTree.CallExpression) => {
     const { parent } = call;
-    if (!("id" in parent && parent.id?.type === T.ArrayPattern)) {
+    if (!("id" in parent) || parent.id?.type !== T.ArrayPattern) {
       return true;
     }
     return parent.id.elements.findIndex((e) => e?.type === T.Identifier && e.name === topLevelId.name) === 1;

packages/plugins/eslint-plugin-react-x/src/rules/no-access-state-in-setstate.ts

@@ -134,7 +134,7 @@ export default createRule<[], MessageID>({
           return;
         }
         // detect `{ foo, state: baz } = this`
-        if (!(node.init != null && AST.isThisExpression(node.init) && node.id.type === T.ObjectPattern)) {
+        if (node.init == null || !AST.isThisExpression(node.init) || node.id.type !== T.ObjectPattern) {
           return;
         }
         const hasState = node

packages/plugins/eslint-plugin-react-x/src/rules/no-unused-state.ts

@@ -175,7 +175,7 @@ export default createRule<[], MessageID>({
           return;
         }
         // detect `{ foo, state: baz } = this`
-        if (!(node.init != null && AST.isThisExpression(node.init) && node.id.type === T.ObjectPattern)) {
+        if (node.init == null || !AST.isThisExpression(node.init) || node.id.type !== T.ObjectPattern) {
           return;
         }
         const hasState = node.id.properties.some((prop) => {

packages/plugins/eslint-plugin-react-x/src/rules/no-useless-fragment.ts

@@ -44,7 +44,7 @@ function checkAndReport(
 ) {
   function fix(fixer: RuleFixer) {
     // Not safe to fix fragments without a jsx parent.
-    if (!(node.parent.type === T.JSXElement || node.parent.type === T.JSXFragment)) {
+    if (node.parent.type !== T.JSXElement && node.parent.type !== T.JSXFragment) {
       // const a = <></>
       if (node.children.length === 0) {
         return null;

packages/utilities/var/src/value-construction.ts

@@ -81,7 +81,7 @@ export function getValueConstruction(
       return getValueConstruction(node.alternate, initialScope, hint);
     }
     case T.Identifier: {
-      if (!("name" in node && typeof node.name === "string")) {
+      if (!("name" in node) || typeof node.name !== "string") {
         return _;
       }
       const variable = initialScope.set.get(node.name);
@@ -95,7 +95,7 @@ export function getValueConstruction(
       return _;
     }
     default: {
-      if (!("expression" in node && typeof node.expression === "object")) {
+      if (!("expression" in node) || typeof node.expression !== "object") {
         return _;
       }
       return getValueConstruction(node.expression, initialScope, hint);