fix: improve the error marker range of 'hooks-extra/no-unnecessary-use-prefix' rule

Rel1cx · Rel1cx · commit 3ea5d14b4cbc · 2025-07-02T08:23:05.000+08:00
diff --git a/.pkgs/configs/package.json b/.pkgs/configs/package.json
@@ -19,7 +19,7 @@
     "lint:ts": "tsc --noEmit"
   },
   "dependencies": {
-    "@eslint/js": "^9.30.0",
+    "@eslint/js": "^9.30.1",
     "@stylistic/eslint-plugin": "^5.1.0",
     "eslint-plugin-de-morgan": "^1.3.0",
     "eslint-plugin-function": "^0.0.22",
diff --git a/.pkgs/eslint-plugin-local/package.json b/.pkgs/eslint-plugin-local/package.json
@@ -26,7 +26,7 @@
     "@eslint-react/kit": "workspace:*",
     "@eslint-react/shared": "workspace:*",
     "@eslint-react/var": "workspace:*",
-    "@eslint/js": "^9.30.0",
+    "@eslint/js": "^9.30.1",
     "@stylistic/eslint-plugin": "^5.1.0",
     "@typescript-eslint/scope-manager": "^8.35.1",
     "@typescript-eslint/type-utils": "^8.35.1",
diff --git a/apps/website/package.json b/apps/website/package.json
@@ -33,7 +33,7 @@
     "@eslint-react/eslint-plugin": "workspace:*",
     "@eslint-react/kit": "workspace:*",
     "@eslint-react/shared": "workspace:*",
-    "@eslint/js": "^9.30.0",
+    "@eslint/js": "^9.30.1",
     "@eslint/markdown": "^6.6.0",
     "@local/configs": "workspace:*",
     "@mdx-js/mdx": "^3.1.0",
@@ -44,12 +44,12 @@
     "@tsconfig/strictest": "^2.0.5",
     "@types/hast": "^3.0.4",
     "@types/mdx": "^2.0.13",
-    "@types/node": "^24.0.8",
+    "@types/node": "^24.0.10",
     "@types/react": "^19.1.8",
     "@types/react-dom": "^19.1.6",
     "autoprefixer": "^10.4.21",
     "dedent": "^1.6.0",
-    "eslint": "^9.30.0",
+    "eslint": "^9.30.1",
     "eslint-plugin-de-morgan": "^1.3.0",
     "eslint-plugin-import-x": "^4.16.1",
     "eslint-plugin-perfectionist": "^4.15.0",
diff --git a/examples/next-app/package.json b/examples/next-app/package.json
@@ -16,15 +16,15 @@
   "devDependencies": {
     "@eslint-react/eslint-plugin": "workspace:*",
     "@eslint/config-inspector": "^1.1.0",
-    "@eslint/js": "^9.30.0",
+    "@eslint/js": "^9.30.1",
     "@next/eslint-plugin-next": "^15.3.4",
     "@tsconfig/next": "^2.0.3",
     "@tsconfig/node22": "^22.0.2",
     "@tsconfig/strictest": "^2.0.5",
-    "@types/node": "^24.0.8",
+    "@types/node": "^24.0.10",
     "@types/react": "^19.1.8",
     "@types/react-dom": "^19.1.6",
-    "eslint": "^9.30.0",
+    "eslint": "^9.30.1",
     "eslint-config-flat-gitignore": "^2.1.0",
     "eslint-plugin-react-hooks": "^5.2.0",
     "eslint-plugin-react-refresh": "^0.4.20",
diff --git a/examples/vite-react-dom-app/package.json b/examples/vite-react-dom-app/package.json
@@ -17,14 +17,14 @@
   "devDependencies": {
     "@eslint-react/eslint-plugin": "workspace:*",
     "@eslint/config-inspector": "^1.1.0",
-    "@eslint/js": "^9.30.0",
+    "@eslint/js": "^9.30.1",
     "@tsconfig/node22": "^22.0.2",
     "@tsconfig/strictest": "^2.0.5",
     "@tsconfig/vite-react": "^6.3.6",
     "@types/react": "^19.1.8",
     "@types/react-dom": "^19.1.6",
     "@vitejs/plugin-react": "^4.6.0",
-    "eslint": "^9.30.0",
+    "eslint": "^9.30.1",
     "eslint-plugin-react-hooks": "^5.2.0",
     "eslint-plugin-react-refresh": "^0.4.20",
     "typescript": "^5.8.3",
diff --git a/examples/vite-react-dom-js-app/package.json b/examples/vite-react-dom-js-app/package.json
@@ -17,11 +17,11 @@
   "devDependencies": {
     "@eslint-react/eslint-plugin": "workspace:*",
     "@eslint/config-inspector": "^1.1.0",
-    "@eslint/js": "^9.30.0",
+    "@eslint/js": "^9.30.1",
     "@types/react": "^19.1.8",
     "@types/react-dom": "^19.1.6",
     "@vitejs/plugin-react": "^4.6.0",
-    "eslint": "^9.30.0",
+    "eslint": "^9.30.1",
     "eslint-plugin-react-hooks": "^5.2.0",
     "eslint-plugin-react-refresh": "^0.4.20",
     "globals": "^16.3.0",
diff --git a/examples/vite-react-dom-js-with-babel-eslint-parser-app/package.json b/examples/vite-react-dom-js-with-babel-eslint-parser-app/package.json
@@ -20,13 +20,13 @@
     "@babel/preset-env": "^7.27.2",
     "@babel/preset-react": "^7.27.1",
     "@eslint/config-inspector": "^1.1.0",
-    "@eslint/js": "^9.30.0",
+    "@eslint/js": "^9.30.1",
     "@types/babel__core": "~7.20.5",
     "@types/babel__preset-env": "~7.10.0",
     "@types/react": "^19.1.8",
     "@types/react-dom": "^19.1.6",
     "@vitejs/plugin-react": "^4.6.0",
-    "eslint": "^9.30.0",
+    "eslint": "^9.30.1",
     "eslint-plugin-react-debug": "workspace:*",
     "eslint-plugin-react-dom": "workspace:*",
     "eslint-plugin-react-hooks": "^5.2.0",
diff --git a/examples/vite-react-dom-with-ts-blank-eslint-parser-app/package.json b/examples/vite-react-dom-with-ts-blank-eslint-parser-app/package.json
@@ -19,14 +19,14 @@
     "@eslint-react/kit": "workspace:*",
     "@eslint-react/shared": "workspace:*",
     "@eslint/config-inspector": "^1.1.0",
-    "@eslint/js": "^9.30.0",
+    "@eslint/js": "^9.30.1",
     "@tsconfig/node22": "^22.0.2",
     "@tsconfig/strictest": "^2.0.5",
     "@tsconfig/vite-react": "^6.3.6",
     "@types/react": "^19.1.8",
     "@types/react-dom": "^19.1.6",
     "@vitejs/plugin-react": "^4.6.0",
-    "eslint": "^9.30.0",
+    "eslint": "^9.30.1",
     "eslint-plugin-react-hooks": "^5.2.0",
     "eslint-plugin-react-refresh": "^0.4.20",
     "globals": "^16.3.0",
diff --git a/package.json b/package.json
@@ -59,7 +59,7 @@
     "@swc/core": "^1.12.9",
     "@tsconfig/node22": "^22.0.2",
     "@tsconfig/strictest": "^2.0.5",
-    "@types/node": "^24.0.8",
+    "@types/node": "^24.0.10",
     "@types/react": "^19.1.8",
     "@types/react-dom": "^19.1.6",
     "@typescript-eslint/parser": "^8.35.1",
@@ -70,7 +70,7 @@
     "dedent": "^1.6.0",
     "dprint": "^0.50.1",
     "esbuild": "^0.25.5",
-    "eslint": "^9.30.0",
+    "eslint": "^9.30.1",
     "eslint-config-flat-gitignore": "^2.1.0",
     "eslint-plugin-fast-import": "^1.2.0",
     "eslint-plugin-vitest": "^0.5.4",
diff --git a/packages/plugins/eslint-plugin-react-hooks-extra/src/rules/no-unnecessary-use-prefix.ts b/packages/plugins/eslint-plugin-react-hooks-extra/src/rules/no-unnecessary-use-prefix.ts
@@ -64,19 +64,9 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
         if (containsUseComments(context, node)) {
           continue;
         }
-        if (id != null) {
-          context.report({
-            messageId: "noUnnecessaryUsePrefix",
-            data: {
-              name,
-            },
-            loc: getPreferredLoc(context, id),
-          });
-          continue;
-        }
         context.report({
           messageId: "noUnnecessaryUsePrefix",
-          node,
+          node: id ?? node,
           data: {
             name,
           },
@@ -85,18 +75,3 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
     },
   };
 }
-
-function getPreferredLoc(context: RuleContext, id: TSESTree.Identifier) {
-  if (AST.isMultiLine(id)) return id.loc;
-  if (!context.sourceCode.getText(id).startsWith("use")) return id.loc;
-  return {
-    end: {
-      column: id.loc.start.column + 3,
-      line: id.loc.start.line,
-    },
-    start: {
-      column: id.loc.start.column,
-      line: id.loc.start.line,
-    },
-  };
-}
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
