Fix remove redundant code in isClassOrInterfaceReadonlyLoose function, closes #1326 (#1330)

Rel1cx · web-flow · commit 47d34e7f8b75 · 2025-12-01T17:51:22.000+08:00
diff --git a/packages/plugins/eslint-plugin-react-x/src/rules/prefer-read-only-props.ts b/packages/plugins/eslint-plugin-react-x/src/rules/prefer-read-only-props.ts
@@ -87,9 +87,7 @@ function isClassOrInterfaceReadonlyLoose(checker: ts.TypeChecker, type: ts.Type)
   for (const property of properties) {
     const propertyName = property.getEscapedName();
     if (isPropertyReadonlyInType(type, propertyName, checker)) continue;
-    else if (baseTypes.length > 0) {
-      return baseTypes.every((heritageType) => isPropertyReadonlyInType(heritageType, propertyName, checker));
-    }
+    else return baseTypes.every((heritageType) => isPropertyReadonlyInType(heritageType, propertyName, checker));
   }
   return true;
 }

Original file line number	Diff line number	Diff line change
`@@ -87,9 +87,7 @@ function isClassOrInterfaceReadonlyLoose(checker: ts.TypeChecker, type: ts.Type)`
`87`	`87`	`for (const property of properties) {`
`88`	`88`	`const propertyName = property.getEscapedName();`
`89`	`89`	`if (isPropertyReadonlyInType(type, propertyName, checker)) continue;`
`90`		`- else if (baseTypes.length > 0) {`
`91`		`- return baseTypes.every((heritageType) => isPropertyReadonlyInType(heritageType, propertyName, checker));`
`92`		`- }`
	`90`	`+ else return baseTypes.every((heritageType) => isPropertyReadonlyInType(heritageType, propertyName, checker));`
`93`	`91`	`}`
`94`	`92`	`return true;`
`95`	`93`	`}`