feat: add react-x/no-nested-lazy-component-declarations rule to plugins and presets

Author: Rel1cx

apps/website/content/docs/rules/meta.json

@@ -34,6 +34,7 @@
     "no-missing-key",
     "no-misused-capture-owner-stack",
     "no-nested-component-definitions",
+    "no-nested-lazy-component-declarations",
     "no-prop-types",
     "no-redundant-should-component-update",
     "no-set-state-in-component-did-mount",

apps/website/content/docs/rules/overview.mdx

@@ -57,6 +57,7 @@ Linter rules can have false positives, false negatives, and some rules are depen
 | [`no-missing-key`](./no-missing-key)                                                 | 2️⃣  |          | Disallow missing `key` on items in list rendering                                                    |           |
 | [`no-misused-capture-owner-stack`](./no-misused-capture-owner-stack)                 | 0️⃣  |   `🧪`   | Prevents incorrect usage of `captureOwnerStack`                                                      |           |
 | [`no-nested-component-definitions`](./no-nested-component-definitions)               | 2️⃣  |          | Disallow nesting component definitions inside other components                                       |           |
+| [`no-nested-lazy-component-declarations`](./no-nested-lazy-component-declarations)   | 2️⃣  |          | Disallow nesting lazy component declarations inside other components                                 |           |
 | [`no-prop-types`](./no-prop-types)                                                   | 2️⃣  |          | Disallow `propTypes` in favor of TypeScript or another type-checking solution                        |           |
 | [`no-redundant-should-component-update`](./no-redundant-should-component-update)     | 2️⃣  |          | Disallow `shouldComponentUpdate` when extending `React.PureComponent`                                |           |
 | [`no-set-state-in-component-did-mount`](./no-set-state-in-component-did-mount)       | 1️⃣  |          | Disallow calling `this.setState` in `componentDidMount` outside of functions, such as callbacks      |           |

packages/plugins/eslint-plugin-react-hooks-extra/src/rules/no-unnecessary-use-callback.md

@@ -20,7 +20,7 @@ react-hooks-extra/no-unnecessary-use-callback
 
 ## Description
 
-Disallows unnecessary usage of `useCallback`.
+Disallow unnecessary usage of `useCallback`.
 
 React Hooks `useCallback` has empty dependencies array like what's in the examples, are unnecessary. The hook can be removed and it's value can be created in the component body or hoisted to the outer scope of the component.
 

packages/plugins/eslint-plugin-react-x/src/configs/recommended.ts

@@ -29,6 +29,7 @@ export const rules = {
   "react-x/no-missing-key": "error",
   "react-x/no-misused-capture-owner-stack": "error",
   "react-x/no-nested-component-definitions": "error",
+  "react-x/no-nested-lazy-component-declarations": "warn",
   "react-x/no-prop-types": "error",
   "react-x/no-redundant-should-component-update": "error",
   "react-x/no-set-state-in-component-did-mount": "warn",

packages/plugins/eslint-plugin-react-x/src/plugin.ts

@@ -33,6 +33,7 @@ import noMissingContextDisplayName from "./rules/no-missing-context-display-name
 import noMissingKey from "./rules/no-missing-key";
 import noMisusedCaptureOwnerStack from "./rules/no-misused-capture-owner-stack";
 import noNestedComponentDefinitions from "./rules/no-nested-component-definitions";
+import noNestedLazyComponentDeclarations from "./rules/no-nested-lazy-component-declarations";
 import noPropTypes from "./rules/no-prop-types";
 import noRedundantShouldComponentUpdate from "./rules/no-redundant-should-component-update";
 import noSetStateInComponentDidMount from "./rules/no-set-state-in-component-did-mount";
@@ -91,6 +92,7 @@ export const plugin = {
     "no-missing-key": noMissingKey,
     "no-misused-capture-owner-stack": noMisusedCaptureOwnerStack,
     "no-nested-component-definitions": noNestedComponentDefinitions,
+    "no-nested-lazy-component-declarations": noNestedLazyComponentDeclarations,
     "no-prop-types": noPropTypes,
     "no-redundant-should-component-update": noRedundantShouldComponentUpdate,
     "no-set-state-in-component-did-mount": noSetStateInComponentDidMount,

packages/plugins/eslint-plugin-react-x/src/rules/no-access-state-in-setstate.md

@@ -23,7 +23,7 @@ react-x/no-access-state-in-setstate
 
 ## Description
 
-Disallows accessing `this.state` inside `setState` calls.
+Disallow accessing `this.state` inside `setState` calls.
 
 Usage of `this.state` inside `setState` calls might result in errors when two state calls are called in batch and thus referencing old state and not the current state.
 

packages/plugins/eslint-plugin-react-x/src/rules/no-nested-lazy-component-declarations.md

@@ -2,13 +2,13 @@
 title: no-nested-lazy-component-declarations
 ---
 
-**Full Name in `eslint-plugin-react-x`**
+**Full Name in `eslint-plugin-react-x@beta`**
 
 ```plain copy
 react-x/no-nested-lazy-component-declarations
 ```
 
-**Full Name in `@eslint-react/eslint-plugin`**
+**Full Name in `@eslint-react/eslint-plugin@beta`**
 
 ```plain copy
 @eslint-react/no-nested-lazy-component-declarations
@@ -23,7 +23,7 @@ react-x/no-nested-lazy-component-declarations
 
 ## Description
 
-Disallows nesting lazy component declarations inside other components.
+Disallow nesting lazy component declarations inside other components.
 
 When a lazy component is declared inside another component, it will be re-created on every render of the parent component. This can lead to unexpected behavior, such as resetting the state of the lazy component.
 

packages/plugins/eslint-plugin-react-x/src/rules/no-set-state-in-component-did-update.md

@@ -23,7 +23,7 @@ react-x/no-set-state-in-component-did-update
 
 ## Description
 
-Disallows calling `this.setState` in `componentDidUpdate` outside of functions, such as callbacks.
+Disallow calling `this.setState` in `componentDidUpdate` outside of functions, such as callbacks.
 
 Updating the state after a component mount will trigger a second `render()` call and can lead to property/layout thrashing.
 

packages/plugins/eslint-plugin-react-x/src/rules/no-set-state-in-component-will-update.md

@@ -23,7 +23,7 @@ react-x/no-set-state-in-component-will-update
 
 ## Description
 
-Disallows calling `this.setState` in `componentWillUpdate` outside of functions, such as callbacks.
+Disallow calling `this.setState` in `componentWillUpdate` outside of functions, such as callbacks.
 
 Updating the state after a component mount will trigger a second `render()` call and can lead to property/layout thrashing.
 

packages/plugins/eslint-plugin/src/configs/x.ts

@@ -30,6 +30,7 @@ export const rules = {
   "@eslint-react/no-missing-key": "error",
   "@eslint-react/no-misused-capture-owner-stack": "error",
   "@eslint-react/no-nested-component-definitions": "error",
+  "@eslint-react/no-nested-lazy-component-declarations": "warn",
   "@eslint-react/no-prop-types": "error",
   "@eslint-react/no-redundant-should-component-update": "error",
   "@eslint-react/no-set-state-in-component-did-mount": "warn",