refactor: minor improvements

Author: Rel1cx

packages/core/src/hook/hook-collector.ts

@@ -15,23 +15,22 @@ export function useHookCollector() {
   const onFunctionEnter = (node: AST.TSESTreeFunction) => {
     const id = AST.getFunctionIdentifier(node);
     const name = O.flatMapNullable(id, (id) => id.name);
-    const isHook = O.isSome(id) && O.isSome(name) && isReactHookName(name.value);
-    if (!isHook) {
-      fStack.push([node, O.none()]);
+    if (O.isSome(id) && O.isSome(name) && isReactHookName(name.value)) {
+      const key = uid.rnd();
+      fStack.push([node, O.some(key)]);
+      hooks.set(key, {
+        _: key,
+        id,
+        kind: "function",
+        name,
+        node,
+        flag: 0n,
+        hint: 0n,
+        hookCalls: [],
+      });
       return;
     }
-    const key = uid.rnd();
-    fStack.push([node, O.some(key)]);
-    hooks.set(key, {
-      _: key,
-      id,
-      kind: "function",
-      name,
-      node,
-      flag: 0n,
-      hint: 0n,
-      hookCalls: [],
-    });
+    fStack.push([node, O.none()]);
   };
   const onFunctionExit = () => {
     fStack.pop();

packages/core/src/render-prop/is.ts

@@ -19,17 +19,17 @@ import { AST_NODE_TYPES } from "@typescript-eslint/types";
  */
 export function isRenderFunctionLoose(node: AST.TSESTreeFunction, context: RuleContext) {
   const { body, parent } = node;
-  const maybeId = AST.getFunctionIdentifier(node);
-  if (O.isSome(maybeId) && !maybeId.value.name.startsWith("render")) {
+  if (O.exists(AST.getFunctionIdentifier(node), (id) => id.name.startsWith("render"))) {
     return parent.type === AST_NODE_TYPES.JSXExpressionContainer
       && parent.parent.type === AST_NODE_TYPES.JSXAttribute
       && parent.parent.name.type === AST_NODE_TYPES.JSXIdentifier
       && parent.parent.name.name.startsWith("render");
   }
-  const jsxCtx = { getScope: (node: TSESTree.Node) => context.sourceCode.getScope(node) } as const;
   return JSX.isJSXValue(
     body,
-    jsxCtx,
+    {
+      getScope: (node: TSESTree.Node) => context.sourceCode.getScope(node),
+    },
     JSX.JSXValueHint.SkipNullLiteral
       | JSX.JSXValueHint.SkipUndefinedLiteral
       | JSX.JSXValueHint.StrictLogical