Update local function rules

Author: Rel1cx

.pkgs/function-rules/rules/nullish-comparison.ts

@@ -9,60 +9,59 @@ export interface nullishComparisonOptions {
 
 // TODO: Implement different enforce options
 export function nullishComparison(options?: nullishComparisonOptions) {
-  return (context: Rule.RuleContext) =>
-    defineRuleListener({
-      BinaryExpression(node): void {
-        if (node.operator === "===" || node.operator === "!==") {
-          const offendingChild = [node.left, node.right].find(
-            (child) =>
-              (child.type === "Identifier"
-                && child.name === "undefined")
-              || (child.type === "Literal" && child.raw === "null"),
-          );
+  return (context: Rule.RuleContext): Rule.RuleListener => ({
+    BinaryExpression(node): void {
+      if (node.operator === "===" || node.operator === "!==") {
+        const offendingChild = [node.left, node.right].find(
+          (child) =>
+            (child.type === "Identifier"
+              && child.name === "undefined")
+            || (child.type === "Literal" && child.raw === "null"),
+        );
 
-          if (offendingChild == null) {
-            return;
-          }
+        if (offendingChild == null) {
+          return;
+        }
 
-          const operatorToken = context.sourceCode.getFirstTokenBetween(
-            node.left,
-            node.right,
-            (token) => token.value === node.operator,
-          );
+        const operatorToken = context.sourceCode.getFirstTokenBetween(
+          node.left,
+          node.right,
+          (token) => token.value === node.operator,
+        );
 
-          if (operatorToken == null) throw new Error("Can't get operator token");
+        if (operatorToken == null) throw new Error("Can't get operator token");
 
-          const wasLeft = node.left === offendingChild;
+        const wasLeft = node.left === offendingChild;
 
-          const nullishKind = offendingChild.type === "Identifier"
-            ? "undefined"
-            : "null";
+        const nullishKind = offendingChild.type === "Identifier"
+          ? "undefined"
+          : "null";
 
-          const looseOperator = node.operator === "===" ? "==" : "!=";
+        const looseOperator = node.operator === "===" ? "==" : "!=";
 
-          context.report({
-            loc: wasLeft
-              ? {
-                end: operatorToken.loc.end,
-                start: node.left.loc!.start,
-              }
-              : {
-                end: node.right.loc!.end,
-                start: operatorToken.loc.start,
-              },
-            message:
-              `Unexpected strict comparison ('${node.operator}') with '${nullishKind}'. In this codebase, we prefer to use loose equality as a general-purpose nullish check when possible.`,
-            suggest: [
-              {
-                desc: `Use loose comparison ('${looseOperator} null') instead, to check both nullish values.`,
-                fix: (fixer) => [
-                  fixer.replaceText(offendingChild, "null"),
-                  fixer.replaceText(operatorToken, looseOperator),
-                ],
-              },
-            ],
-          });
-        }
-      },
-    });
+        context.report({
+          loc: wasLeft
+            ? {
+              end: operatorToken.loc.end,
+              start: node.left.loc!.start,
+            }
+            : {
+              end: node.right.loc!.end,
+              start: operatorToken.loc.start,
+            },
+          message:
+            `Unexpected strict comparison ('${node.operator}') with '${nullishKind}'. In this codebase, we prefer to use loose equality as a general-purpose nullish check when possible.`,
+          suggest: [
+            {
+              desc: `Use loose comparison ('${looseOperator} null') instead, to check both nullish values.`,
+              fix: (fixer) => [
+                fixer.replaceText(offendingChild, "null"),
+                fixer.replaceText(operatorToken, looseOperator),
+              ],
+            },
+          ],
+        });
+      }
+    },
+  });
 }

.pkgs/function-rules/rules/template-expression.ts

@@ -1,21 +1,19 @@
 import type { Rule } from "eslint";
-import { defineRuleListener } from "eslint-plugin-function-rule";
 
 export interface templateExpressionOptions {
   allowMultiline: boolean;
 }
 
 export function templateExpression(options?: templateExpressionOptions) {
   const allowMultiline = options?.allowMultiline ?? false;
-  return (context: Rule.RuleContext) =>
-    defineRuleListener({
-      TemplateLiteral(node) {
-        if (!allowMultiline && node.loc?.start.line !== node.loc?.end.line) {
-          context.report({
-            node,
-            message: "Avoid multiline template expressions.",
-          });
-        }
-      },
-    });
+  return (context: Rule.RuleContext): Rule.RuleListener => ({
+    TemplateLiteral(node) {
+      if (!allowMultiline && node.loc?.start.line !== node.loc?.end.line) {
+        context.report({
+          node,
+          message: "Avoid multiline template expressions.",
+        });
+      }
+    },
+  });
 }

eslint.config.ts

@@ -55,16 +55,17 @@ export default defineConfig([
     plugins: {
       "function-rule-1": defineRule(templateExpression()),
       "function-rule-2": defineRule(nullishComparison()),
-      // custom: defineRule((context) => ({
-      //   TemplateLiteral(node) {
-      //     if (node.loc?.start.line !== node.loc?.end.line) {
-      //       context.report({
-      //         node,
-      //         message: "Avoid multiline template expressions.",
-      //       });
-      //     }
-      //   },
-      // })),
+
+      custom: defineRule((context) => ({
+        CallExpression(node) {
+          if (context.sourceCode.getText(node.callee) === "Date.now") {
+            context.report({
+              node,
+              message: "Don't use 'Date.now()'.",
+            });
+          }
+        },
+      })),
     },
     rules: {
       "fast-import/no-unused-exports": "off",

package.json

@@ -52,7 +52,7 @@
     "update:website": "tsx ./scripts/update-website.ts"
   },
   "devDependencies": {
-    "@effect/language-service": "^0.55.2",
+    "@effect/language-service": "^0.55.3",
     "@effect/platform": "^0.93.0",
     "@effect/platform-node": "^0.100.0",
     "@eslint/compat": "^1.4.1",