release: 1.48.3-next.0

Author: Rel1cx

VERSION

@@ -1 +1 @@
-1.48.2
+1.48.3-next.0

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/monorepo",
-  "version": "1.48.2",
+  "version": "1.48.3-next.0",
   "private": true,
   "description": "Monorepo for eslint-plugin-react-[x, dom, web-api, hooks-extra, naming-convention].",
   "keywords": [
@@ -66,7 +66,7 @@
     "@typescript-eslint/rule-tester": "^8.30.1",
     "@typescript-eslint/types": "^8.30.1",
     "ansis": "^3.17.0",
-    "cspell": "^8.18.1",
+    "cspell": "^8.19.0",
     "dedent": "^1.5.3",
     "dprint": "^0.49.1",
     "esbuild": "^0.25.2",

packages/core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/core",
-  "version": "1.48.2",
+  "version": "1.48.3-next.0",
   "description": "ESLint React's ESLint utility module for static analysis of React core APIs and patterns.",
   "homepage": "https://github.com/Rel1cx/eslint-react",
   "bugs": {

packages/core/src/hook/hook-hierarchy.ts

@@ -16,8 +16,8 @@ export function isFunctionOfUseEffectSetup(node: TSESTree.Node | _) {
 export function isFunctionOfUseEffectCleanup(node: TSESTree.Node | _) {
   if (node == null) return false;
   const pReturn = AST.findParentNode(node, AST.is(T.ReturnStatement));
-  const pFaunction = AST.findParentNode(node, AST.isFunction);
+  const pFunction = AST.findParentNode(node, AST.isFunction); // Correctly named variable
   const pFunctionOfReturn = AST.findParentNode(pReturn, AST.isFunction);
-  if (pFaunction !== pFunctionOfReturn) return false;
-  return isFunctionOfUseEffectSetup(pFaunction);
+  if (pFunction !== pFunctionOfReturn) return false; // Ensure consistent variable naming
+  return isFunctionOfUseEffectSetup(pFunction);
 }

packages/plugins/eslint-plugin-react-debug/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-debug",
-  "version": "1.48.2",
+  "version": "1.48.3-next.0",
   "description": "ESLint React's ESLint plugin for debugging related rules.",
   "keywords": [
     "react",

packages/plugins/eslint-plugin-react-dom/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-dom",
-  "version": "1.48.2",
+  "version": "1.48.3-next.0",
   "description": "ESLint React's ESLint plugin for React DOM related rules.",
   "keywords": [
     "react",

packages/plugins/eslint-plugin-react-hooks-extra/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-hooks-extra",
-  "version": "1.48.2",
+  "version": "1.48.3-next.0",
   "description": "ESLint React's ESLint plugin for React Hooks related rules.",
   "keywords": [
     "react",

packages/plugins/eslint-plugin-react-hooks-extra/src/hooks/use-no-direct-set-state-in-use-effect.ts

@@ -47,6 +47,7 @@ export function useNoDirectSetStateInUseEffect<Ctx extends RuleContext>(
   const { onViolation, useEffectKind } = options;
   const settings = getSettingsFromContext(context);
   const additionalHooks = settings.additionalHooks;
+  const getText = (n: TSESTree.Node) => context.sourceCode.getText(n);
   const isUseEffectLikeCall = ER.isReactHookCallWithNameAlias(context, useEffectKind, additionalHooks[useEffectKind]);
   const isUseStateCall = ER.isReactHookCallWithNameAlias(context, "useState", additionalHooks.useState);
   const isUseMemoCall = ER.isReactHookCallWithNameAlias(context, "useMemo", additionalHooks.useMemo);
@@ -80,6 +81,13 @@ export function useNoDirectSetStateInUseEffect<Ctx extends RuleContext>(
       && isUseEffectLikeCall(node.parent);
   }
 
+  function getCallName(node: TSESTree.Node) {
+    if (node.type === T.CallExpression) {
+      return AST.toString(node.callee, getText);
+    }
+    return AST.toString(node, getText);
+  }
+
   function getCallKind(node: TSESTree.CallExpression) {
     return match<TSESTree.CallExpression, CallKind>(node)
       .when(isUseStateCall, () => "useState")
@@ -221,15 +229,15 @@ export function useNoDirectSetStateInUseEffect<Ctx extends RuleContext>(
         const setStateCalls = getSetStateCalls(name, context.sourceCode.getScope(callee));
         for (const setStateCall of setStateCalls) {
           onViolation(context, setStateCall, {
-            name: AST.toString(setStateCall, (n) => context.sourceCode.getText(n)),
+            name: getCallName(setStateCall),
           });
         }
       }
       for (const id of setupFunctionIdentifiers) {
         const setStateCalls = getSetStateCalls(id.name, context.sourceCode.getScope(id));
         for (const setStateCall of setStateCalls) {
           onViolation(context, setStateCall, {
-            name: AST.toString(setStateCall, (n) => context.sourceCode.getText(n)),
+            name: getCallName(setStateCall),
           });
         }
       }