refactor: minor improvements

Author: Rel1cx

packages/core/docs/README.md

@@ -41,7 +41,7 @@
 ## Functions
 
 - [getComponentNameFromIdentifier](functions/getComponentNameFromIdentifier.md)
-- [getElementType](functions/getElementType.md)
+- [getElementRepresentName](functions/getElementRepresentName.md)
 - [getFunctionComponentIdentifier](functions/getFunctionComponentIdentifier.md)
 - [hasNoneOrValidComponentName](functions/hasNoneOrValidComponentName.md)
 - [isCallFromReact](functions/isCallFromReact.md)

packages/core/docs/functions/getElementType.md renamed to packages/core/docs/functions/getElementRepresentName.md

@@ -2,11 +2,11 @@
 
 ***
 
-[@eslint-react/core](../README.md) / getElementType
+[@eslint-react/core](../README.md) / getElementRepresentName
 
-# Function: getElementType()
+# Function: getElementRepresentName()
 
-> **getElementType**(`node`, `context`): `string`
+> **getElementRepresentName**(`node`, `context`): `string`
 
 ## Parameters
 

packages/core/src/element/get-element-type.ts renamed to packages/core/src/element/get-element-represent-name.ts

@@ -4,17 +4,17 @@ import { F, isString, O } from "@eslint-react/tools";
 import type { RuleContext } from "@eslint-react/types";
 import type { TSESTree } from "@typescript-eslint/types";
 
-export function getElementType(node: TSESTree.JSXOpeningElement, context: RuleContext) {
-  const elementName = JSX.getElementName(node);
-  if (elementName === elementName.toLowerCase()) return elementName;
+export function getElementRepresentName(node: TSESTree.JSXOpeningElement, context: RuleContext) {
+  const rawElementName = JSX.getElementName(node);
+  if (rawElementName === rawElementName.toLowerCase()) return rawElementName;
   const { components, polymorphicPropName } = normalizeSettings(decodeSettings(context.settings));
-  const asElementName = components.get(elementName);
+  const asElementName = components.get(rawElementName);
   if (isString(asElementName)) return asElementName;
   return F.pipe(
     O.fromNullable(polymorphicPropName),
     O.flatMap(JSX.findPropInAttributes(node.attributes, context.sourceCode.getScope(node))),
     O.flatMap(attr => JSX.getPropValue(attr, context.sourceCode.getScope(attr))),
     O.filter(isString),
-    O.getOrElse(() => elementName),
+    O.getOrElse(() => rawElementName),
   );
 }

packages/core/src/element/index.ts

@@ -1,3 +1,3 @@
-export * from "./get-element-type";
+export * from "./get-element-represent-name";
 export * from "./hierarchy";
 export * from "./misc";

packages/plugins/eslint-plugin-react-dom/src/rules/no-children-in-void-dom-elements.ts

@@ -1,4 +1,4 @@
-import { getElementType } from "@eslint-react/core";
+import { getElementRepresentName } from "@eslint-react/core";
 import * as JSX from "@eslint-react/jsx";
 import { O } from "@eslint-react/tools";
 import type { CamelCase } from "string-ts";
@@ -44,14 +44,14 @@ export default createRule<[], MessageID>({
   create(context) {
     return {
       JSXElement(node) {
-        const elementType = getElementType(node.openingElement, context);
-        if (!elementType || !voidElements.has(elementType)) return;
+        const elementName = getElementRepresentName(node.openingElement, context);
+        if (!elementName || !voidElements.has(elementName)) return;
         if (node.children.length > 0) {
           context.report({
             messageId: "noChildrenInVoidDomElements",
             node,
             data: {
-              element: elementType,
+              element: elementName,
             },
           });
         }
@@ -65,7 +65,7 @@ export default createRule<[], MessageID>({
             messageId: "noChildrenInVoidDomElements",
             node,
             data: {
-              element: elementType,
+              element: elementName,
             },
           });
         }

packages/plugins/eslint-plugin-react-dom/src/rules/no-missing-button-type.ts

@@ -1,4 +1,4 @@
-import { getElementType } from "@eslint-react/core";
+import { getElementRepresentName } from "@eslint-react/core";
 import * as JSX from "@eslint-react/jsx";
 import { O } from "@eslint-react/tools";
 import type { CamelCase } from "string-ts";
@@ -25,8 +25,8 @@ export default createRule<[], MessageID>({
   create(context) {
     return {
       JSXElement(node) {
-        const elementType = getElementType(node.openingElement, context);
-        if (elementType !== "button") return;
+        const elementName = getElementRepresentName(node.openingElement, context);
+        if (elementName !== "button") return;
         const { attributes } = node.openingElement;
         const initialScope = context.sourceCode.getScope(node);
         const maybeTypeAttribute = JSX.findPropInAttributes(attributes, initialScope)("type");

packages/plugins/eslint-plugin-react-dom/src/rules/no-missing-iframe-sandbox.ts

@@ -1,11 +1,9 @@
 import * as JSX from "@eslint-react/jsx";
-import { decodeSettings, normalizeSettings } from "@eslint-react/shared";
 import { F, isString, O } from "@eslint-react/tools";
-import type { TSESTree } from "@typescript-eslint/utils";
 import type { CamelCase } from "string-ts";
 
 import { createRule } from "../utils";
-import { getElementType } from "@eslint-react/core";
+import { getElementRepresentName } from "@eslint-react/core";
 
 export const RULE_NAME = "no-missing-iframe-sandbox";
 
@@ -46,8 +44,8 @@ export default createRule<[], MessageID>({
   create(context) {
     return {
       JSXElement(node) {
-        const elementType = getElementType(node.openingElement, context);
-        if (elementType !== "iframe") return;
+        const elementName = getElementRepresentName(node.openingElement, context);
+        if (elementName !== "iframe") return;
         const { attributes } = node.openingElement;
         const initialScope = context.sourceCode.getScope(node);
         const maybeSandboxAttribute = JSX.findPropInAttributes(attributes, initialScope)("sandbox");

packages/plugins/eslint-plugin-react-dom/src/rules/no-unsafe-iframe-sandbox.ts

@@ -1,12 +1,10 @@
 import * as JSX from "@eslint-react/jsx";
-import { decodeSettings, normalizeSettings } from "@eslint-react/shared";
 import { F, isString, O } from "@eslint-react/tools";
-import type { TSESTree } from "@typescript-eslint/utils";
 import type { CamelCase } from "string-ts";
 import { match, P } from "ts-pattern";
 
 import { createRule } from "../utils";
-import { getElementType } from "@eslint-react/core";
+import { getElementRepresentName } from "@eslint-react/core";
 
 export const RULE_NAME = "no-unsafe-iframe-sandbox";
 
@@ -33,8 +31,8 @@ export default createRule<[], MessageID>({
   create(context) {
     return {
       JSXElement(node) {
-        const elementType = getElementType(node.openingElement, context);
-        if (elementType !== "iframe") return;
+        const elementName = getElementRepresentName(node.openingElement, context);
+        if (elementName !== "iframe") return;
         const { attributes } = node.openingElement;
         const initialScope = context.sourceCode.getScope(node);
         const maybeSandboxAttribute = JSX.findPropInAttributes(attributes, initialScope)("sandbox");

packages/plugins/eslint-plugin-react-dom/src/rules/no-unsafe-target-blank.ts

@@ -1,4 +1,4 @@
-import { getElementType } from "@eslint-react/core";
+import { getElementRepresentName } from "@eslint-react/core";
 import * as JSX from "@eslint-react/jsx";
 import { decodeSettings, normalizeSettings } from "@eslint-react/shared";
 import { F, isString, O } from "@eslint-react/tools";
@@ -42,8 +42,8 @@ export default createRule<[], MessageID>({
     const additionalComponents = settings.additionalComponents.filter(c => c.as === "a");
     function getReportDescriptor(node: TSESTree.JSXElement): O.Option<ReportDescriptor<MessageID>> {
       const name = JSX.getElementName(node.openingElement);
-      const elementType = getElementType(node.openingElement, context);
-      if (elementType !== "a" && !additionalComponents.some(c => c.re.test(name))) return O.none();
+      const elementName = getElementRepresentName(node.openingElement, context);
+      if (elementName !== "a" && !additionalComponents.some(c => c.re.test(name))) return O.none();
       const { attributes } = node.openingElement;
       const initialScope = context.sourceCode.getScope(node);
       const additionalAttributes = additionalComponents