Skip to content

Commit 64607ad

Browse files
authored
feat(react-debug): use json for rule diagnostic output format (#1058)
1 parent 3b9837f commit 64607ad

File tree

10 files changed

+1116
-549
lines changed

10 files changed

+1116
-549
lines changed

packages/plugins/eslint-plugin-react-debug/src/rules/class-component.spec.ts

Lines changed: 70 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,12 @@ ruleTester.run(RULE_NAME, rule, {
1313
}
1414
}
1515
`,
16-
errors: [{ messageId: "classComponent" }],
16+
errors: [
17+
{
18+
messageId: "classComponent",
19+
data: { json: JSON.stringify({ name: "ParentComponent" }) },
20+
},
21+
],
1722
},
1823
{
1924
code: tsx`
@@ -23,7 +28,12 @@ ruleTester.run(RULE_NAME, rule, {
2328
}
2429
};
2530
`,
26-
errors: [{ messageId: "classComponent" }],
31+
errors: [
32+
{
33+
messageId: "classComponent",
34+
data: { json: JSON.stringify({ name: "ClassComponent" }) },
35+
},
36+
],
2737
},
2838
{
2939
code: tsx`
@@ -41,7 +51,12 @@ ruleTester.run(RULE_NAME, rule, {
4151
);
4252
}
4353
`,
44-
errors: [{ messageId: "classComponent" }],
54+
errors: [
55+
{
56+
messageId: "classComponent",
57+
data: { json: JSON.stringify({ name: "UnstableNestedClassComponent" }) },
58+
},
59+
],
4560
},
4661
{
4762
code: tsx`
@@ -62,8 +77,14 @@ ruleTester.run(RULE_NAME, rule, {
6277
}
6378
`,
6479
errors: [
65-
{ messageId: "classComponent" },
66-
{ messageId: "classComponent" },
80+
{
81+
messageId: "classComponent",
82+
data: { json: JSON.stringify({ name: "ParentComponent" }) },
83+
},
84+
{
85+
messageId: "classComponent",
86+
data: { json: JSON.stringify({ name: "UnstableNestedClassComponent" }) },
87+
},
6788
],
6889
},
6990
{
@@ -85,8 +106,14 @@ ruleTester.run(RULE_NAME, rule, {
85106
}
86107
`,
87108
errors: [
88-
{ messageId: "classComponent" },
89-
{ messageId: "classComponent" },
109+
{
110+
messageId: "classComponent",
111+
data: { json: JSON.stringify({ name: "ParentComponent" }) },
112+
},
113+
{
114+
messageId: "classComponent",
115+
data: { json: JSON.stringify({ name: "UnstableNestedClassComponent" }) },
116+
},
90117
],
91118
},
92119
{
@@ -105,7 +132,12 @@ ruleTester.run(RULE_NAME, rule, {
105132
}
106133
}
107134
`,
108-
errors: [{ messageId: "classComponent" }],
135+
errors: [
136+
{
137+
messageId: "classComponent",
138+
data: { json: JSON.stringify({ name: "ParentComponent" }) },
139+
},
140+
],
109141
},
110142
{
111143
code: tsx`
@@ -123,7 +155,12 @@ ruleTester.run(RULE_NAME, rule, {
123155
}
124156
}
125157
`,
126-
errors: [{ messageId: "classComponent" }],
158+
errors: [
159+
{
160+
messageId: "classComponent",
161+
data: { json: JSON.stringify({ name: "ParentComponent" }) },
162+
},
163+
],
127164
},
128165
{
129166
code: tsx`
@@ -141,7 +178,12 @@ ruleTester.run(RULE_NAME, rule, {
141178
}
142179
}
143180
`,
144-
errors: [{ messageId: "classComponent" }],
181+
errors: [
182+
{
183+
messageId: "classComponent",
184+
data: { json: JSON.stringify({ name: "ParentComponent" }) },
185+
},
186+
],
145187
},
146188
{
147189
code: tsx`
@@ -159,7 +201,12 @@ ruleTester.run(RULE_NAME, rule, {
159201
}
160202
}
161203
`,
162-
errors: [{ messageId: "classComponent" }],
204+
errors: [
205+
{
206+
messageId: "classComponent",
207+
data: { json: JSON.stringify({ name: "ParentComponent" }) },
208+
},
209+
],
163210
},
164211
{
165212
code: tsx`
@@ -173,7 +220,12 @@ ruleTester.run(RULE_NAME, rule, {
173220
}
174221
}
175222
`,
176-
errors: [{ messageId: "classComponent" }],
223+
errors: [
224+
{
225+
messageId: "classComponent",
226+
data: { json: JSON.stringify({ name: "ParentComponent" }) },
227+
},
228+
],
177229
},
178230
{
179231
code: tsx`
@@ -194,7 +246,12 @@ ruleTester.run(RULE_NAME, rule, {
194246
}
195247
}
196248
`,
197-
errors: [{ messageId: "classComponent" }],
249+
errors: [
250+
{
251+
messageId: "classComponent",
252+
data: { json: JSON.stringify({ name: "ParentComponent" }) },
253+
},
254+
],
198255
},
199256
],
200257
valid: [

packages/plugins/eslint-plugin-react-debug/src/rules/class-component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export default createRule<[], MessageID>({
2121
[Symbol.for("rule_features")]: RULE_FEATURES,
2222
},
2323
messages: {
24-
classComponent: "[class component] name: {{name}}.",
24+
classComponent: "{{json}}",
2525
},
2626
schema: [],
2727
},
@@ -41,7 +41,7 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
4141
messageId: "classComponent",
4242
node: component,
4343
data: {
44-
name,
44+
json: JSON.stringify({ name }),
4545
},
4646
});
4747
}

0 commit comments

Comments
 (0)