chore: cleanup

Rel1cx · Rel1cx · commit 64823ca3f1eb · 2025-09-26T05:53:16.000+08:00
diff --git a/packages/core/docs/README.md b/packages/core/docs/README.md
@@ -121,6 +121,7 @@
 - [getFunctionComponentId](functions/getFunctionComponentId.md)
 - [getJsxConfigFromAnnotation](functions/getJsxConfigFromAnnotation.md)
 - [getJsxConfigFromContext](functions/getJsxConfigFromContext.md)
+- [getPhaseKindOfFunction](functions/getPhaseKindOfFunction.md)
 - [hasAnyAttribute](functions/hasAnyAttribute.md)
 - [hasAttribute](functions/hasAttribute.md)
 - [hasEveryAttribute](functions/hasEveryAttribute.md)
@@ -135,7 +136,11 @@
 - [isComponentWrapperCallLoose](functions/isComponentWrapperCallLoose.md)
 - [isDeclaredInRenderPropLoose](functions/isDeclaredInRenderPropLoose.md)
 - [isFragmentElement](functions/isFragmentElement.md)
+- [isFunctionOfComponentDidMount](functions/isFunctionOfComponentDidMount.md)
+- [isFunctionOfComponentWillUnmount](functions/isFunctionOfComponentWillUnmount.md)
 - [isFunctionOfRenderMethod](functions/isFunctionOfRenderMethod.md)
+- [isFunctionOfUseEffectCleanup](functions/isFunctionOfUseEffectCleanup.md)
+- [isFunctionOfUseEffectSetup](functions/isFunctionOfUseEffectSetup.md)
 - [isHostElement](functions/isHostElement.md)
 - [isJsxLike](functions/isJsxLike.md)
 - [isJsxText](functions/isJsxText.md)
diff --git a/packages/core/docs/functions/getPhaseKindOfFunction.md b/packages/core/docs/functions/getPhaseKindOfFunction.md
@@ -0,0 +1,19 @@
+[**@eslint-react/core**](../README.md)
+
+***
+
+[@eslint-react/core](../README.md) / getPhaseKindOfFunction
+
+# Function: getPhaseKindOfFunction()
+
+> **getPhaseKindOfFunction**(`node`): `null` \| [`ComponentPhaseKind`](../type-aliases/ComponentPhaseKind.md)
+
+## Parameters
+
+### node
+
+`TSESTreeFunction`
+
+## Returns
+
+`null` \| [`ComponentPhaseKind`](../type-aliases/ComponentPhaseKind.md)
diff --git a/packages/core/docs/functions/isFunctionOfComponentDidMount.md b/packages/core/docs/functions/isFunctionOfComponentDidMount.md
@@ -0,0 +1,19 @@
+[**@eslint-react/core**](../README.md)
+
+***
+
+[@eslint-react/core](../README.md) / isFunctionOfComponentDidMount
+
+# Function: isFunctionOfComponentDidMount()
+
+> **isFunctionOfComponentDidMount**(`node`): `boolean`
+
+## Parameters
+
+### node
+
+`Node`
+
+## Returns
+
+`boolean`
diff --git a/packages/core/docs/functions/isFunctionOfComponentWillUnmount.md b/packages/core/docs/functions/isFunctionOfComponentWillUnmount.md
@@ -0,0 +1,19 @@
+[**@eslint-react/core**](../README.md)
+
+***
+
+[@eslint-react/core](../README.md) / isFunctionOfComponentWillUnmount
+
+# Function: isFunctionOfComponentWillUnmount()
+
+> **isFunctionOfComponentWillUnmount**(`node`): `boolean`
+
+## Parameters
+
+### node
+
+`Node`
+
+## Returns
+
+`boolean`
diff --git a/packages/core/docs/functions/isFunctionOfUseEffectCleanup.md b/packages/core/docs/functions/isFunctionOfUseEffectCleanup.md
@@ -0,0 +1,19 @@
+[**@eslint-react/core**](../README.md)
+
+***
+
+[@eslint-react/core](../README.md) / isFunctionOfUseEffectCleanup
+
+# Function: isFunctionOfUseEffectCleanup()
+
+> **isFunctionOfUseEffectCleanup**(`node`): `boolean`
+
+## Parameters
+
+### node
+
+`undefined` | `Node`
+
+## Returns
+
+`boolean`
diff --git a/packages/core/docs/functions/isFunctionOfUseEffectSetup.md b/packages/core/docs/functions/isFunctionOfUseEffectSetup.md
@@ -0,0 +1,19 @@
+[**@eslint-react/core**](../README.md)
+
+***
+
+[@eslint-react/core](../README.md) / isFunctionOfUseEffectSetup
+
+# Function: isFunctionOfUseEffectSetup()
+
+> **isFunctionOfUseEffectSetup**(`node`): `boolean`
+
+## Parameters
+
+### node
+
+`undefined` | `Node`
+
+## Returns
+
+`boolean`
diff --git a/packages/core/src/component/component-method-parts.ts b/packages/core/src/component/component-method-parts.ts
@@ -0,0 +1,16 @@
+import * as AST from "@eslint-react/ast";
+import type { TSESTree } from "@typescript-eslint/types";
+
+import { isComponentDidMount, isComponentWillUnmount } from "./component-method";
+
+export function isFunctionOfComponentDidMount(node: TSESTree.Node) {
+  return AST.isFunction(node)
+    && isComponentDidMount(node.parent)
+    && node.parent.value === node;
+}
+
+export function isFunctionOfComponentWillUnmount(node: TSESTree.Node) {
+  return AST.isFunction(node)
+    && isComponentWillUnmount(node.parent)
+    && node.parent.value === node;
+}
diff --git a/packages/core/src/component/component-phase-helpers.ts b/packages/core/src/component/component-phase-helpers.ts
@@ -0,0 +1,21 @@
+import type * as AST from "@eslint-react/ast";
+import { dual } from "@eslint-react/eff";
+import { match } from "ts-pattern";
+
+import { isFunctionOfUseEffectCleanup, isFunctionOfUseEffectSetup } from "../hook/hook-parts";
+import { isFunctionOfComponentDidMount, isFunctionOfComponentWillUnmount } from "./component-method-parts";
+import { type ComponentPhaseKind, ComponentPhaseRelevance } from "./component-phase";
+
+export const isInversePhase: {
+  (a: ComponentPhaseKind): (b: ComponentPhaseKind) => boolean;
+  (a: ComponentPhaseKind, b: ComponentPhaseKind): boolean;
+} = dual(2, (a: ComponentPhaseKind, b: ComponentPhaseKind) => ComponentPhaseRelevance.get(a) === b);
+
+export function getPhaseKindOfFunction(node: AST.TSESTreeFunction) {
+  return match<AST.TSESTreeFunction, ComponentPhaseKind | null>(node)
+    .when(isFunctionOfUseEffectSetup, () => "setup")
+    .when(isFunctionOfUseEffectCleanup, () => "cleanup")
+    .when(isFunctionOfComponentDidMount, () => "mount")
+    .when(isFunctionOfComponentWillUnmount, () => "unmount")
+    .otherwise(() => null);
+}
diff --git a/packages/core/src/component/component-phase.ts b/packages/core/src/component/component-phase.ts
@@ -1,4 +1,3 @@
-import { dual } from "@eslint-react/eff";
 import birecord from "birecord";
 
 export type ComponentEffectPhaseKind = "cleanup" | "setup";
@@ -9,8 +8,3 @@ export const ComponentPhaseRelevance = birecord({
   mount: "unmount",
   setup: "cleanup",
 });
-
-export const isInversePhase: {
-  (a: ComponentPhaseKind): (b: ComponentPhaseKind) => boolean;
-  (a: ComponentPhaseKind, b: ComponentPhaseKind): boolean;
-} = dual(2, (a: ComponentPhaseKind, b: ComponentPhaseKind) => ComponentPhaseRelevance.get(a) === b);
diff --git a/packages/core/src/component/index.ts b/packages/core/src/component/index.ts
@@ -9,8 +9,10 @@ export * from "./component-init-path";
 export * from "./component-is";
 export type * from "./component-kind";
 export * from "./component-method";
+export * from "./component-method-parts";
 export * from "./component-name";
 export * from "./component-phase";
+export * from "./component-phase-helpers";
 export * from "./component-render-method";
 export * from "./component-render-prop";
 export type * from "./component-semantic-node";
diff --git a/packages/core/src/hook/hook-parts.ts b/packages/core/src/hook/hook-parts.ts
@@ -2,37 +2,21 @@ import * as AST from "@eslint-react/ast";
 import type { unit } from "@eslint-react/eff";
 import type { TSESTree } from "@typescript-eslint/types";
 import { AST_NODE_TYPES as T } from "@typescript-eslint/types";
+
 import { isUseEffectLikeCall } from "./hook-is";
 
-/**
- * Determines if the node is the setup function of a useEffect hook
- * (the first argument passed to useEffect)
- * @param node The node to check
- */
 export function isFunctionOfUseEffectSetup(node: TSESTree.Node | unit) {
   if (node == null) return false;
   return node.parent?.type === T.CallExpression
-    && node.parent.callee !== node
-    && node.parent.callee.type === T.Identifier
     && node.parent.arguments.at(0) === node
     && isUseEffectLikeCall(node.parent);
 }
 
-/**
- * Determines if the node is part of a useEffect cleanup function
- * (the function returned by the setup function of useEffect)
- * @param node The node to check
- */
 export function isFunctionOfUseEffectCleanup(node: TSESTree.Node | unit) {
   if (node == null) return false;
-  // Find the parent return statement
   const pReturn = AST.findParentNode(node, AST.is(T.ReturnStatement));
-  // Find the nearest parent function
-  const pFunction = AST.findParentNode(node, AST.isFunction);
-  // Find the function containing the return statement
+  const pFunction = AST.findParentNode(node, AST.isFunction); // Correctly named variable
   const pFunctionOfReturn = AST.findParentNode(pReturn, AST.isFunction);
-  // Ensure the node is in the same function as the return statement
-  if (pFunction !== pFunctionOfReturn) return false;
-  // Check if this function is a useEffect setup function
+  if (pFunction !== pFunctionOfReturn) return false; // Ensure consistent variable naming
   return isFunctionOfUseEffectSetup(pFunction);
 }
diff --git a/packages/core/src/hook/index.ts b/packages/core/src/hook/index.ts
@@ -2,4 +2,5 @@ export * from "./hook-collector";
 export * from "./hook-id";
 export * from "./hook-is";
 export * from "./hook-name";
+export * from "./hook-parts";
 export type * from "./hook-semantic-node";
diff --git a/packages/plugins/eslint-plugin-react-web-api/src/rules/no-leaked-event-listener.ts b/packages/plugins/eslint-plugin-react-web-api/src/rules/no-leaked-event-listener.ts
@@ -11,7 +11,7 @@ import type { EventListenerEntry } from "../types";
 
 import { getStaticValue } from "@typescript-eslint/utils/ast-utils";
 import { P, isMatching, match } from "ts-pattern";
-import { createRule, getPhaseKindOfFunction } from "../utils";
+import { createRule } from "../utils";
 
 // #region Rule Metadata
 
@@ -67,7 +67,7 @@ function getCallKind(node: TSESTree.CallExpression): CallKind {
 }
 
 function getFunctionKind(node: AST.TSESTreeFunction): FunctionKind {
-  return getPhaseKindOfFunction(node) ?? "other";
+  return ER.getPhaseKindOfFunction(node) ?? "other";
 }
 
 function getSignalValueExpression(node: TSESTree.Node | unit, initialScope: Scope): TSESTree.Node | unit {
diff --git a/packages/plugins/eslint-plugin-react-web-api/src/rules/no-leaked-interval.ts b/packages/plugins/eslint-plugin-react-web-api/src/rules/no-leaked-interval.ts
@@ -8,7 +8,7 @@ import type { RuleListener } from "@typescript-eslint/utils/ts-eslint";
 import type { TimerEntry } from "../types";
 
 import { P, isMatching } from "ts-pattern";
-import { createRule, getPhaseKindOfFunction } from "../utils";
+import { createRule } from "../utils";
 
 // #region Rule Metadata
 
@@ -86,7 +86,7 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
   }
   return {
     [":function"](node: AST.TSESTreeFunction) {
-      const kind = getPhaseKindOfFunction(node) ?? "other";
+      const kind = ER.getPhaseKindOfFunction(node) ?? "other";
       fEntries.push({ kind, node });
     },
     [":function:exit"]() {
diff --git a/packages/plugins/eslint-plugin-react-web-api/src/rules/no-leaked-resize-observer.ts b/packages/plugins/eslint-plugin-react-web-api/src/rules/no-leaked-resize-observer.ts
@@ -10,7 +10,7 @@ import type { RuleListener } from "@typescript-eslint/utils/ts-eslint";
 import type { ObserverEntry, ObserverMethod } from "../types";
 
 import { P, isMatching, match } from "ts-pattern";
-import { createRule, getPhaseKindOfFunction, isConditional } from "../utils";
+import { createRule, isConditional } from "../utils";
 
 // #region Rule Metadata
 
@@ -76,7 +76,7 @@ function getCallKind(context: RuleContext, node: TSESTree.CallExpression): CallK
 }
 
 function getFunctionKind(node: AST.TSESTreeFunction): FunctionKind {
-  return getPhaseKindOfFunction(node) ?? "other";
+  return ER.getPhaseKindOfFunction(node) ?? "other";
 }
 
 // #endregion
diff --git a/packages/plugins/eslint-plugin-react-web-api/src/rules/no-leaked-timeout.ts b/packages/plugins/eslint-plugin-react-web-api/src/rules/no-leaked-timeout.ts
@@ -5,10 +5,10 @@ import * as VAR from "@eslint-react/var";
 import type { TSESTree } from "@typescript-eslint/utils";
 import { AST_NODE_TYPES as T } from "@typescript-eslint/utils";
 import type { RuleListener } from "@typescript-eslint/utils/ts-eslint";
-import type { TimerEntry } from "../types";
-
 import { P, isMatching } from "ts-pattern";
-import { createRule, getPhaseKindOfFunction } from "../utils";
+
+import type { TimerEntry } from "../types";
+import { createRule } from "../utils";
 
 // #region Rule Metadata
 
@@ -86,7 +86,7 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
   }
   return {
     [":function"](node: AST.TSESTreeFunction) {
-      const kind = getPhaseKindOfFunction(node) ?? "other";
+      const kind = ER.getPhaseKindOfFunction(node) ?? "other";
       fEntries.push({ kind, node });
     },
     [":function:exit"]() {
diff --git a/packages/plugins/eslint-plugin-react-web-api/src/utils/get-phase-kind-of-function.ts b/packages/plugins/eslint-plugin-react-web-api/src/utils/get-phase-kind-of-function.ts
diff --git a/packages/plugins/eslint-plugin-react-web-api/src/utils/index.ts b/packages/plugins/eslint-plugin-react-web-api/src/utils/index.ts
@@ -1,3 +1,2 @@
 export * from "./create-rule";
-export * from "./get-phase-kind-of-function";
 export * from "./is-conditional";
