Skip to content

Commit 69e89ca

Browse files
committed
Update local function rules
1 parent 3db42e5 commit 69e89ca

File tree

9 files changed

+32
-33
lines changed

9 files changed

+32
-33
lines changed

.pkgs/configs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"@stylistic/eslint-plugin": "^5.5.0",
2424
"eslint-plugin-de-morgan": "^2.0.0",
2525
"eslint-plugin-function": "^0.0.33",
26-
"eslint-plugin-function-rule": "^0.0.10",
26+
"eslint-plugin-function-rule": "^0.0.11",
2727
"eslint-plugin-jsdoc": "^61.1.12",
2828
"eslint-plugin-perfectionist": "^4.15.1",
2929
"eslint-plugin-regexp": "^2.10.0",

.pkgs/function-rules/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"lint:ts": "tsc --noEmit"
2222
},
2323
"dependencies": {
24-
"eslint-plugin-function-rule": "^0.0.10"
24+
"eslint-plugin-function-rule": "^0.0.11"
2525
},
2626
"devDependencies": {
2727
"eslint": "^9.39.1",

eslint.config.ts

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -53,24 +53,23 @@ export default defineConfig([
5353
},
5454
},
5555
plugins: {
56-
"nullish-comparison": defineRule("v1", nullishComparison()),
57-
"template-expression": defineRule("v1", templateExpression()),
58-
59-
custom: defineRule("v1", (context) => ({
60-
TemplateLiteral(node) {
61-
if (node.loc?.start.line !== node.loc?.end.line) {
62-
context.report({
63-
node,
64-
message: "Avoid multiline template expressions.",
65-
});
66-
}
67-
},
68-
})),
56+
"function-rule-1": defineRule(templateExpression()),
57+
"function-rule-2": defineRule(nullishComparison()),
58+
// custom: defineRule((context) => ({
59+
// TemplateLiteral(node) {
60+
// if (node.loc?.start.line !== node.loc?.end.line) {
61+
// context.report({
62+
// node,
63+
// message: "Avoid multiline template expressions.",
64+
// });
65+
// }
66+
// },
67+
// })),
6968
},
7069
rules: {
7170
"fast-import/no-unused-exports": "off",
72-
"nullish-comparison/v1": "error",
73-
"template-expression/v1": "warn",
71+
"function-rule-1/function-rule": "warn",
72+
"function-rule-2/function-rule": "error",
7473
},
7574
},
7675
{
@@ -108,8 +107,8 @@ export default defineConfig([
108107
},
109108
rules: {
110109
"@typescript-eslint/no-empty-function": ["error", { allow: ["arrowFunctions"] }],
111-
"nullish-comparison/v1": "off",
112-
"template-expression/v1": "off",
110+
"function-rule-1/function-rule": "off",
111+
"function-rule-2/function-rule": "off",
113112
},
114113
},
115114
disableProblematicEslintJsRules,

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474
"effect": "^3.19.3",
7575
"eslint": "^9.39.1",
7676
"eslint-plugin-fast-import": "^1.5.3",
77-
"eslint-plugin-function-rule": "^0.0.10",
77+
"eslint-plugin-function-rule": "^0.0.11",
7878
"eslint-plugin-vitest": "^0.5.4",
7979
"mdxlint": "^1.0.0",
8080
"publint": "^0.3.15",

packages/plugins/eslint-plugin-react-x/src/rules/jsx-shorthand-boolean.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ export function create(context: RuleContext<MessageID, Options>): RuleListener {
7575
}
7676
// Enforce explicit `={true}` for boolean attributes (e.g., `prop={true}` instead of `prop`)
7777
case policy === -1
78-
// eslint-disable-next-line nullish-comparison/v1
78+
// eslint-disable-next-line function-rule-2/function-rule
7979
&& value === null: {
8080
context.report({
8181
messageId: "jsxShorthandBoolean",

packages/utilities/ast/src/literal.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export function isLiteral(node: TSESTree.Node, type?: LiteralType) {
2121
case "boolean":
2222
return typeof node.value === "boolean";
2323
case "null":
24-
// eslint-disable-next-line nullish-comparison/v1
24+
// eslint-disable-next-line function-rule-2/function-rule
2525
return node.value === null;
2626
case "number":
2727
return typeof node.value === "number";

packages/utilities/ast/src/node-format.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { delimiterCase, replace, toLowerCase } from "string-ts";
66
import { isJSX } from "./node-is";
77

88
function getLiteralValueType(input: bigint | boolean | null | number | string | symbol) {
9-
// eslint-disable-next-line nullish-comparison/v1
9+
// eslint-disable-next-line function-rule-2/function-rule
1010
if (input === null) return "null";
1111
return typeof input;
1212
}

packages/utilities/eff/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ export function isArray<T>(data: ArrayLike<unknown> | T): data is NarrowedTo<T,
144144
* @returns The input type, narrowed to only objects.
145145
*/
146146
export function isObject<T>(data: T | object): data is NarrowedTo<T, object> {
147-
// eslint-disable-next-line nullish-comparison/v1
147+
// eslint-disable-next-line function-rule-2/function-rule
148148
return typeof data === "object" && data !== null;
149149
}
150150

pnpm-lock.yaml

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)