chore: update project eslint config

Rel1cx · Rel1cx · commit 6c980e8c1568 · 2025-01-03T07:49:25.000+08:00
diff --git a/eslint.config.ts b/eslint.config.ts
@@ -1,7 +1,6 @@
 /* eslint-disable simple-import-sort/imports */
 import url from "node:url";
 
-import { Record } from "effect";
 import eslintJs from "@eslint/js";
 import eslintMarkdown from "@eslint/markdown";
 import eslintPluginImport from "eslint-plugin-import-x";
@@ -70,27 +69,16 @@ const p11tGroups = {
   groups: ["id", "type", "meta", "alias", "rules", "unknown"],
 };
 
-const disableTypeCheckedRules = {
-  ...tseslint.configs.disableTypeChecked.rules,
-  "@susisu/safe-typescript/no-object-assign": "off",
-  "@susisu/safe-typescript/no-type-assertion": "off",
-  "@susisu/safe-typescript/no-unsafe-object-enum-method": "off",
+const enableTypeCheckedRules = {
+  ...tseslint.configs.strictTypeCheckedOnly.map(x => x.rules).reduce((a, b) => ({ ...a, ...b }), {}),
+  ...eslintPluginSafeTypeScript.configs.recommended.rules,
   "@susisu/safe-typescript/no-unsafe-object-property-check": "off",
   "@susisu/safe-typescript/no-unsafe-object-property-overwrite": "off",
-} as const;
-
-const typeCheckedRules = {
-  ...Record.map(disableTypeCheckedRules, () => "warn"),
-  "@susisu/safe-typescript/no-unsafe-object-property-check": "off",
-  "@susisu/safe-typescript/no-unsafe-object-property-overwrite": "off",
-  "@typescript-eslint/naming-convention": "off",
-  "@typescript-eslint/no-confusing-void-expression": "off",
-  "@typescript-eslint/prefer-destructuring": "off",
-  "@typescript-eslint/prefer-readonly-parameter-types": "off",
   "@typescript-eslint/strict-boolean-expressions": ["warn", { allowNullableBoolean: true, allowNullableString: true }],
-  "@typescript-eslint/switch-exhaustiveness-check": "off",
 } as const;
 
+const disableTypeCheckedRules = Object.fromEntries(Object.keys(enableTypeCheckedRules).map(x => [x, "off"]));
+
 export default tseslint.config(
   eslintConfigFlatGitignore(),
   {
@@ -193,9 +181,7 @@ export default tseslint.config(
           varsIgnorePattern: "^_",
         },
       ],
-      ...typeCheckedRules,
-      // Part: functional rules
-      "functional/no-return-void": "off",
+      ...enableTypeCheckedRules,
       // Part: jsdoc rules
       "jsdoc/check-param-names": "warn",
       "jsdoc/check-tag-names": "warn",
diff --git a/examples/dual-react-dom-lib/package.json b/examples/dual-react-dom-lib/package.json
@@ -29,7 +29,7 @@
     "prepare": "pnpm run build"
   },
   "devDependencies": {
-    "@eslint-react/eslint-plugin": "^1.23.0",
+    "@eslint-react/eslint-plugin": "^1.23.1",
     "@eslint/js": "^9.17.0",
     "@tsconfig/node22": "^22.0.0",
     "@tsconfig/strictest": "^2.0.5",
diff --git a/examples/next-app/package.json b/examples/next-app/package.json
@@ -16,7 +16,7 @@
     "react-dom": "latest"
   },
   "devDependencies": {
-    "@eslint-react/eslint-plugin": "^1.23.0",
+    "@eslint-react/eslint-plugin": "^1.23.1",
     "@eslint/config-inspector": "^0.6.0",
     "@eslint/js": "^9.17.0",
     "@next/eslint-plugin-next": "^15.1.3",
diff --git a/examples/vite-react-dom-app/package.json b/examples/vite-react-dom-app/package.json
@@ -15,7 +15,7 @@
     "react-dom": "^19.0.0"
   },
   "devDependencies": {
-    "@eslint-react/eslint-plugin": "^1.23.0",
+    "@eslint-react/eslint-plugin": "^1.23.1",
     "@eslint/config-inspector": "^0.6.0",
     "@eslint/js": "^9.17.0",
     "@tsconfig/node22": "^22.0.0",
diff --git a/examples/vite-react-dom-js-app/package.json b/examples/vite-react-dom-js-app/package.json
@@ -15,7 +15,7 @@
     "react-dom": "^19.0.0"
   },
   "devDependencies": {
-    "@eslint-react/eslint-plugin": "^1.23.0",
+    "@eslint-react/eslint-plugin": "^1.23.1",
     "@eslint/config-inspector": "^0.6.0",
     "@eslint/js": "^9.17.0",
     "@types/react": "^19.0.2",
diff --git a/examples/vite-react-dom-js-with-babel-app/package.json b/examples/vite-react-dom-js-with-babel-app/package.json
@@ -19,7 +19,7 @@
     "@babel/eslint-parser": "^7.25.9",
     "@babel/preset-env": "^7.26.0",
     "@babel/preset-react": "^7.26.3",
-    "@eslint-react/eslint-plugin": "^1.23.0",
+    "@eslint-react/eslint-plugin": "^1.23.1",
     "@eslint/config-inspector": "^0.6.0",
     "@eslint/js": "^9.17.0",
     "@types/babel__core": "~7.20.5",
diff --git a/packages/plugins/eslint-plugin-react-x/src/rules/no-useless-fragment.ts b/packages/plugins/eslint-plugin-react-x/src/rules/no-useless-fragment.ts
@@ -38,7 +38,10 @@ function checkAndReport(
   // report if the fragment is placed inside a built-in component (e.g. <div><></></div>)
   if (JSX.isBuiltInElement(node.parent)) context.report({ messageId: "noUselessFragmentInBuiltIn", node });
   // report and return if the fragment has no children (e.g. <></>)
-  if (node.children.length === 0) return context.report({ messageId: "noUselessFragment", node });
+  if (node.children.length === 0) {
+    context.report({ messageId: "noUselessFragment", node });
+    return;
+  }
   const isChildElement = AST.isOneOf([AST_NODE_TYPES.JSXElement, AST_NODE_TYPES.JSXFragment])(node.parent);
   switch (true) {
     // <Foo content={<>ee eeee eeee ...</>} />
@@ -51,14 +54,16 @@ function checkAndReport(
     // <Foo><>hello, world</></Foo>
     case !allowExpressions
       && isChildElement: {
-      return context.report({ messageId: "noUselessFragment", node });
+      context.report({ messageId: "noUselessFragment", node });
+      return;
     }
     case !allowExpressions
       && !isChildElement
       && node.children.length === 1: {
       // const foo = <>{children}</>;
       // return <>{children}</>;
-      return context.report({ messageId: "noUselessFragment", node });
+      context.report({ messageId: "noUselessFragment", node });
+      return;
     }
   }
   const nonPaddingChildren = node.children.filter((child) => !JSX.isPaddingSpaces(child));
@@ -67,7 +72,8 @@ function checkAndReport(
     case nonPaddingChildren.length === 0:
     case nonPaddingChildren.length === 1
       && firstNonPaddingChild?.type !== AST_NODE_TYPES.JSXExpressionContainer: {
-      return context.report({ messageId: "noUselessFragment", node });
+      context.report({ messageId: "noUselessFragment", node });
+      return;
     }
   }
   return;
diff --git a/packages/plugins/eslint-plugin/src/utils/pad-keys-left.ts b/packages/plugins/eslint-plugin/src/utils/pad-keys-left.ts
@@ -7,6 +7,6 @@ export function padKeysLeft<const T, const U extends string = "">(
   obj: T,
   left: U,
 ): PadKeysLeft<T, U> {
-  // eslint-disable-next-line @susisu/safe-typescript/no-type-assertion, @typescript-eslint/no-unsafe-type-assertion
+  // eslint-disable-next-line @susisu/safe-typescript/no-type-assertion
   return transformKeys(obj, (key) => `${left}${key}`) as never;
 }
diff --git a/packages/plugins/eslint-plugin/src/utils/transform-keys.ts b/packages/plugins/eslint-plugin/src/utils/transform-keys.ts
@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/no-unsafe-type-assertion, @susisu/safe-typescript/no-type-assertion */
+/* eslint-disable @susisu/safe-typescript/no-type-assertion */
 // Copied from https://github.com/gustavoguichard/string-ts/blob/9dd444f03fdfa225f1643e6f1f8c18f9480224bb/src/utils/object-keys/transform-keys.ts#L12
 
 import { typeOf } from "@eslint-react/types";
diff --git a/packages/shared/src/settings.ts b/packages/shared/src/settings.ts
@@ -36,7 +36,7 @@ export const DEFAULT_ESLINT_REACT_SETTINGS = {
  */
 export function unsafeReadSettings(data: unknown): PartialDeep<ESLintReactSettings> {
   // @ts-expect-error - skip type checking for unsafe cast
-  // eslint-disable-next-line @susisu/safe-typescript/no-type-assertion, @typescript-eslint/no-unsafe-type-assertion
+  // eslint-disable-next-line @susisu/safe-typescript/no-type-assertion
   return (data?.["react-x"] ?? {}) as PartialDeep<ESLintReactSettings>;
 }
 
diff --git a/packages/types/src/helpers.ts b/packages/types/src/helpers.ts
@@ -181,7 +181,7 @@ export function fromEntries(...args: ReadonlyArray<any>): unknown {
   return Object.fromEntries(args);
 }
 
-/* eslint-disable @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-type-assertion */
+/* eslint-disable @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-return */
 type Reverse<T extends Record<any, any>> = { [U in keyof T as T[U]]: U };
 
 function reverse<T extends Record<any, any>>(record: T): Reverse<T> {
@@ -207,7 +207,7 @@ export class BiRecord<const T extends Record<any, any>> {
     return key in this.original || key in this.reversed;
   }
 }
-/* eslint-enable @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-type-assertion */
+/* eslint-enable @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-return */
 
 // #endregion
 
@@ -231,7 +231,6 @@ export function zip<T>(...arrs: Array<readonly T[]>): T[][] {
     const element: T[] = [];
 
     for (const arr of arrs) {
-      // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion
       element.push(arr[i] as T);
     }
 
diff --git a/packages/utilities/jsx/src/get-prop.ts b/packages/utilities/jsx/src/get-prop.ts
@@ -10,7 +10,6 @@ import type { TSESTree } from "@typescript-eslint/utils";
  * @param node The JSX attribute node
  * @returns string
  */
-// eslint-disable-next-line @typescript-eslint/consistent-return
 export function getPropName(node: TSESTree.JSXAttribute) {
   switch (node.name.type) {
     case AST_NODE_TYPES.JSXIdentifier:
diff --git a/packages/utilities/jsx/src/unescape-string-literal-text.ts b/packages/utilities/jsx/src/unescape-string-literal-text.ts
@@ -8,7 +8,6 @@ import { xhtmlEntities } from "./xhtml-entities";
 export function unescapeStringLiteralText(text: string): string {
   return text.replaceAll(/&(?:#\d+|#x[\da-fA-F]+|[0-9a-zA-Z]+);/g, entity => {
     const item = entity.slice(1, -1);
-    // eslint-disable-next-line @typescript-eslint/prefer-string-starts-ends-with
     if (item[0] === "#") {
       const codePoint = item[1] === "x"
         ? parseInt(item.slice(2), 16)
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,6 @@ export function padKeysLeft<const T, const U extends string = "">(`
`7`	`7`	`obj: T,`
`8`	`8`	`left: U,`
`9`	`9`	`): PadKeysLeft<T, U> {`
`10`		`- // eslint-disable-next-line @susisu/safe-typescript/no-type-assertion, @typescript-eslint/no-unsafe-type-assertion`
	`10`	`+ // eslint-disable-next-line @susisu/safe-typescript/no-type-assertion`
`11`	`11`	return transformKeys(obj, (key) => `${left}${key}`) as never;
`12`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-/* eslint-disable @typescript-eslint/no-unsafe-type-assertion, @susisu/safe-typescript/no-type-assertion */`
	`1`	`+/* eslint-disable @susisu/safe-typescript/no-type-assertion */`
`2`	`2`	`// Copied from https://github.com/gustavoguichard/string-ts/blob/9dd444f03fdfa225f1643e6f1f8c18f9480224bb/src/utils/object-keys/transform-keys.ts#L12`
`3`	`3`
`4`	`4`	`import { typeOf } from "@eslint-react/types";`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ export const DEFAULT_ESLINT_REACT_SETTINGS = {`
`36`	`36`	`*/`
`37`	`37`	`export function unsafeReadSettings(data: unknown): PartialDeep<ESLintReactSettings> {`
`38`	`38`	`// @ts-expect-error - skip type checking for unsafe cast`
`39`		`- // eslint-disable-next-line @susisu/safe-typescript/no-type-assertion, @typescript-eslint/no-unsafe-type-assertion`
	`39`	`+ // eslint-disable-next-line @susisu/safe-typescript/no-type-assertion`
`40`	`40`	`return (data?.["react-x"] ?? {}) as PartialDeep<ESLintReactSettings>;`
`41`	`41`	`}`
`42`	`42`