chore: update ESLint rules for stricter boolean expressions and adjust linting command

Author: Rel1cx

eslint.config.ts

@@ -76,7 +76,16 @@ const enableTypeCheckedRules = {
   "@susisu/safe-typescript/no-unsafe-object-property-check": "off",
   "@susisu/safe-typescript/no-unsafe-object-property-overwrite": "off",
   "@typescript-eslint/consistent-type-exports": "error",
-  "@typescript-eslint/strict-boolean-expressions": ["warn", { allowNullableBoolean: true, allowNullableString: true }],
+  "@typescript-eslint/strict-boolean-expressions": ["warn", {
+    allowAny: false,
+    allowNullableBoolean: true,
+    allowNullableEnum: false,
+    allowNullableNumber: false,
+    allowNullableObject: true,
+    allowNullableString: false,
+    allowNumber: false,
+    allowString: false,
+  }],
 } as const;
 
 const disableTypeCheckedRules = Object.fromEntries(Object.keys(enableTypeCheckedRules).map(x => [x, "off"]));

package.json

@@ -42,7 +42,7 @@
     "lint:examples": "pnpm -r -F \"./examples/*\" run --parallel lint",
     "lint:publish": "pnpm -r run --parallel lint:publish",
     "lint:spell": "cspell lint --relative --no-progress \"**\"",
-    "lint:ts": "eslint .",
+    "lint:ts": "eslint . --max-warnings 100",
     "lint:type": "pnpm -r run --parallel lint:type",
     "lint:website": "pnpm -F \"./website\" run lint",
     "prepare": "lefthook install && pnpm run build",

packages/core/src/component/component-collector.ts

@@ -78,20 +78,20 @@ export function useComponentCollector(
     functionEntries.push({ key, node, hookCalls: [], isComponent: false });
   };
   const onFunctionExit = () => {
-    const { key, node, isComponent } = functionEntries.at(-1) ?? {};
-    if (!key || !node || !isComponent) {
+    const entry = functionEntries.at(-1);
+    if (!entry?.isComponent) {
       return functionEntries.pop();
     }
-    const shouldDrop = AST.getNestedReturnStatements(node.body)
+    const shouldDrop = AST.getNestedReturnStatements(entry.node.body)
       .slice()
       .reverse()
       .some(r => {
-        return context.sourceCode.getScope(r).block === node
+        return context.sourceCode.getScope(r).block === entry.node
           && r.argument !== null
           && !JSX.isJSXValue(r.argument, jsxCtx, hint);
       });
     if (shouldDrop) {
-      components.delete(key);
+      components.delete(entry.key);
     }
     return functionEntries.pop();
   };