refactor: replace short-unique-id w/ uid (#894)

Co-authored-by: rEl1cx <[email protected]>

Author: SukkaW

packages/core/package.json

@@ -50,8 +50,8 @@
     "@typescript-eslint/type-utils": "^8.19.0",
     "@typescript-eslint/types": "^8.19.0",
     "@typescript-eslint/utils": "^8.19.0",
-    "short-unique-id": "^5.2.0",
-    "ts-pattern": "^5.6.0"
+    "ts-pattern": "^5.6.0",
+    "uid": "^2.0.2"
   },
   "devDependencies": {
     "@workspace/configs": "workspace:*",

packages/core/src/component/component-collector-legacy.ts

@@ -2,14 +2,12 @@ import * as AST from "@eslint-react/ast";
 import { O } from "@eslint-react/eff";
 import { AST_NODE_TYPES } from "@typescript-eslint/types";
 import type { ESLintUtils, TSESTree } from "@typescript-eslint/utils";
-import ShortUniqueId from "short-unique-id";
 import { match, P } from "ts-pattern";
+import { uid } from "uid";
 
 import type { ERClassComponent } from "./component";
 import { ERClassComponentFlag } from "./component-flag";
 
-const uid = new ShortUniqueId({ length: 10 });
-
 /**
  * Check if a node is a React class component
  * @param node The AST node to check
@@ -94,7 +92,7 @@ export function useComponentCollectorLegacy() {
   const collect = (node: AST.TSESTreeClass) => {
     if (!isClassComponent(node)) return;
     const id = AST.getClassIdentifier(node);
-    const key = uid.rnd();
+    const key = uid(10);
     const flag = isPureComponent(node)
       ? ERClassComponentFlag.PureComponent
       : ERClassComponentFlag.None;

packages/core/src/component/component-collector.ts

@@ -5,8 +5,8 @@ import type { RuleContext } from "@eslint-react/types";
 import type { TSESTree } from "@typescript-eslint/types";
 import { AST_NODE_TYPES } from "@typescript-eslint/types";
 import type { ESLintUtils } from "@typescript-eslint/utils";
-import ShortUniqueId from "short-unique-id";
 import { match } from "ts-pattern";
+import { uid } from "uid";
 
 import { isChildrenOfCreateElement } from "../element";
 import { isReactHookCall } from "../hook";
@@ -18,8 +18,6 @@ import { getComponentNameFromIdentifier } from "./component-name";
 import { isFunctionOfRenderMethod } from "./component-render-method";
 import { hasNoneOrValidComponentName } from "./misc";
 
-const uid = new ShortUniqueId({ length: 10 });
-
 function hasValidHierarchy(node: AST.TSESTreeFunction, context: RuleContext, hint: bigint) {
   if (isChildrenOfCreateElement(node, context) || isFunctionOfRenderMethod(node)) {
     return false;
@@ -75,7 +73,7 @@ export function useComponentCollector(
     hookCalls: TSESTree.CallExpression[],
   ][] = [];
   const getCurrentFunction = () => O.fromNullable(functionStack.at(-1));
-  const onFunctionEnter = (node: AST.TSESTreeFunction) => functionStack.push([uid.rnd(), node, false, []]);
+  const onFunctionEnter = (node: AST.TSESTreeFunction) => functionStack.push([uid(10), node, false, []]);
   const onFunctionExit = () => {
     const [key, fn, isComponent] = functionStack.at(-1) ?? [];
     if (!key || !fn || !isComponent) return functionStack.pop();
@@ -119,7 +117,7 @@ export function useComponentCollector(
       const initPath = AST.getFunctionInitPath(currentFn);
       const id = getFunctionComponentIdentifier(currentFn, context);
       const name = O.flatMapNullable(id, getComponentNameFromIdentifier);
-      const key = uid.rnd();
+      const key = uid(10);
       components.set(key, {
         _: key,
         id,

packages/core/src/hook/hook-collector.ts

@@ -1,22 +1,20 @@
 import * as AST from "@eslint-react/ast";
 import { F, O } from "@eslint-react/eff";
 import type { ESLintUtils, TSESTree } from "@typescript-eslint/utils";
-import ShortUniqueId from "short-unique-id";
+import { uid } from "uid";
 
 import type { ERHook } from "./hook";
 import { isReactHookName } from "./hook-name";
 import { isReactHookCall } from "./is";
 
-const uid = new ShortUniqueId({ length: 10 });
-
 export function useHookCollector() {
   const hooks = new Map<string, ERHook>();
   const fStack: [node: AST.TSESTreeFunction, id: O.Option<string>][] = [];
   const onFunctionEnter = (node: AST.TSESTreeFunction) => {
     const id = AST.getFunctionIdentifier(node);
     const name = O.flatMapNullable(id, (id) => id.name);
     if (O.isSome(id) && O.isSome(name) && isReactHookName(name.value)) {
-      const key = uid.rnd();
+      const key = uid(10);
       fStack.push([node, O.some(key)]);
       hooks.set(key, {
         _: key,