refactor(plugins/local): rename 'no-shadowing-underscore' rule to 'no-shadow-underscore'

Author: Rel1cx

eslint.config.ts

@@ -252,7 +252,7 @@ export default tseslint.config(
       "eslint-plugin/require-meta-docs-url": "off",
       // Part: local rules
       "local/avoid-multiline-template-expression": "warn",
-      "local/no-shadowing-underscore": "error",
+      "local/no-shadow-underscore": "error",
       "local/prefer-eqeq-nullish-comparison": "warn",
     },
     settings: {

packages/utilities/eff/src/lang.ts

@@ -6,12 +6,12 @@ import type { NarrowedTo } from "./type";
 /**
  * 1-byte version undefined, produces fewer bytes than `undefined` or `void 0` in the minified output dts.
  */
-export type _ = undefined; // eslint-disable-line local/no-shadowing-underscore
+export type _ = undefined; // eslint-disable-line local/no-shadow-underscore
 
 /**
  * 1-byte version undefined, produces fewer bytes than `undefined` or `void 0` in the minified output js.
  */
-export const _ = undefined; // eslint-disable-line local/no-shadowing-underscore
+export const _ = undefined; // eslint-disable-line local/no-shadow-underscore
 
 /**
  * Do nothing and return false

workspace/eslint-plugin-local/dist/index.d.ts

@@ -6,8 +6,8 @@ declare const _default: {
         readonly version: string;
     };
     readonly rules: {
-        readonly "no-shadowing-underscore": _typescript_eslint_utils_ts_eslint.RuleModule<"noShadowingUnderscore", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
         readonly "avoid-multiline-template-expression": _typescript_eslint_utils_ts_eslint.RuleModule<"avoidMultilineTemplateExpression", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
+        readonly "no-shadow-underscore": _typescript_eslint_utils_ts_eslint.RuleModule<"noShadowUnderscore", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
         readonly "prefer-eqeq-nullish-comparison": _typescript_eslint_utils_ts_eslint.RuleModule<"unexpectedComparison" | "useLooseComparisonSuggestion", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
     };
 };

workspace/eslint-plugin-local/dist/index.js

@@ -43,19 +43,19 @@ var avoid_multiline_template_expression_default = createRule({
   },
   defaultOptions: []
 });
-var RULE_NAME2 = "no-shadowing-underscore";
+var RULE_NAME2 = "no-shadow-underscore";
 var RULE_FEATURES2 = [
   "CHK"
 ];
-var no_shadowing_underscore_default = createRule({
+var no_shadow_underscore_default = createRule({
   meta: {
     type: "problem",
     docs: {
       description: "disallow multiline template expressions",
       [Symbol.for("rule_features")]: RULE_FEATURES2
     },
     messages: {
-      noShadowingUnderscore: "In this codebase, '_' is used to represent the undefined. Avoid shadowing it."
+      noShadowUnderscore: "In this codebase, '_' is used to represent the undefined. Avoid shadowing it."
     },
     schema: []
   },
@@ -67,7 +67,7 @@ var no_shadowing_underscore_default = createRule({
         const isFromImport = VAR.isInitializedFromSource("_", "@eslint-react/eff", initialScope);
         if (!isFromImport) {
           context.report({
-            messageId: "noShadowingUnderscore",
+            messageId: "noShadowUnderscore",
             node
           });
         }
@@ -153,8 +153,8 @@ var index_default = {
     version
   },
   rules: {
-    "no-shadowing-underscore": no_shadowing_underscore_default,
     "avoid-multiline-template-expression": avoid_multiline_template_expression_default,
+    "no-shadow-underscore": no_shadow_underscore_default,
     "prefer-eqeq-nullish-comparison": prefer_eqeq_nullish_comparison_default
   }
 };

workspace/eslint-plugin-local/src/index.ts

@@ -1,6 +1,6 @@
 import { name, version } from "../package.json";
 import avoidMultilineTemplateExpression from "./rules/avoid-multiline-template-expression";
-import noShadowingUnderscore from "./rules/no-shadowing-underscore";
+import noShadowingUnderscore from "./rules/no-shadow-underscore";
 import preferEqeqNullishComparison from "./rules/prefer-eqeq-nullish-comparison";
 
 export default {
@@ -10,7 +10,7 @@ export default {
   },
   rules: {
     "avoid-multiline-template-expression": avoidMultilineTemplateExpression,
-    "no-shadowing-underscore": noShadowingUnderscore,
+    "no-shadow-underscore": noShadowingUnderscore,
     "prefer-eqeq-nullish-comparison": preferEqeqNullishComparison,
   },
 } as const;

workspace/eslint-plugin-local/src/rules/no-shadowing-underscore.spec.ts renamed to workspace/eslint-plugin-local/src/rules/no-shadow-underscore.spec.ts

@@ -1,25 +1,25 @@
 import { ruleTester } from "../../../../test";
-import rule, { RULE_NAME } from "./no-shadowing-underscore";
+import rule, { RULE_NAME } from "./no-shadow-underscore";
 
 ruleTester.run(RULE_NAME, rule, {
   invalid: [
     {
       code: /* ts */ `
         const _ = 1;
       `,
-      errors: [{ messageId: "noShadowingUnderscore" }],
+      errors: [{ messageId: "noShadowUnderscore" }],
     },
     {
       code: /* ts */ `
         const [_, foo] = [1, 2];
       `,
-      errors: [{ messageId: "noShadowingUnderscore" }],
+      errors: [{ messageId: "noShadowUnderscore" }],
     },
     {
       code: /* ts */ `
         const { name: _, ...rest } = { name: "foo", age: 20 };
       `,
-      errors: [{ messageId: "noShadowingUnderscore" }],
+      errors: [{ messageId: "noShadowUnderscore" }],
     },
   ],
   valid: [

workspace/eslint-plugin-local/src/rules/no-shadowing-underscore.ts renamed to workspace/eslint-plugin-local/src/rules/no-shadow-underscore.ts

@@ -5,7 +5,7 @@ import type { CamelCase } from "string-ts";
 
 import { createRule } from "../utils";
 
-export const RULE_NAME = "no-shadowing-underscore";
+export const RULE_NAME = "no-shadow-underscore";
 
 export const RULE_FEATURES = [
   "CHK",
@@ -21,7 +21,7 @@ export default createRule<[], MessageID>({
       [Symbol.for("rule_features")]: RULE_FEATURES,
     },
     messages: {
-      noShadowingUnderscore: "In this codebase, '_' is used to represent the undefined. Avoid shadowing it.",
+      noShadowUnderscore: "In this codebase, '_' is used to represent the undefined. Avoid shadowing it.",
     },
     schema: [],
   },
@@ -33,7 +33,7 @@ export default createRule<[], MessageID>({
         const isFromImport = VAR.isInitializedFromSource("_", "@eslint-react/eff", initialScope);
         if (!isFromImport) {
           context.report({
-            messageId: "noShadowingUnderscore",
+            messageId: "noShadowUnderscore",
             node,
           });
         }