refactor(ast): restructure the module (#1075)

Author: Rel1cx

packages/core/src/utils/is-react-api.ts

@@ -18,7 +18,7 @@ export function isReactAPI(api: string): isReactAPI.ReturnType {
   {
     if (node == null) return false;
     const getText = (n: TSESTree.Node) => context.sourceCode.getText(n);
-    const name = AST.stringify(node, getText);
+    const name = AST.toString(node, getText);
     if (name === api) return true;
     if (name.substring(name.indexOf(".") + 1) === api) return true;
     return false;

packages/plugins/eslint-plugin-react-hooks-extra/src/hooks/use-no-direct-set-state-in-use-effect.ts

@@ -221,15 +221,15 @@ export function useNoDirectSetStateInUseEffect<Ctx extends RuleContext>(
         const setStateCalls = getSetStateCalls(name, context.sourceCode.getScope(callee));
         for (const setStateCall of setStateCalls) {
           onViolation(context, setStateCall, {
-            name: AST.stringify(setStateCall, (n) => context.sourceCode.getText(n)),
+            name: AST.toString(setStateCall, (n) => context.sourceCode.getText(n)),
           });
         }
       }
       for (const id of setupFunctionIdentifiers) {
         const setStateCalls = getSetStateCalls(id.name, context.sourceCode.getScope(id));
         for (const setStateCall of setStateCalls) {
           onViolation(context, setStateCall, {
-            name: AST.stringify(setStateCall, (n) => context.sourceCode.getText(n)),
+            name: AST.toString(setStateCall, (n) => context.sourceCode.getText(n)),
           });
         }
       }

packages/plugins/eslint-plugin-react-x/src/rules/no-duplicate-key.ts

@@ -74,7 +74,7 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
           if (!AST.isFunction(iter)) return;
           const arg0 = call?.arguments[0];
           if (call == null || arg0 == null) return;
-          if (AST.getEcmaExpression(arg0) !== iter) {
+          if (AST.getJSExpression(arg0) !== iter) {
             return;
           }
           keyedEntries.set(call, {

packages/utilities/ast/src/__tests__/get-class-identifier.test.ts

@@ -1,4 +1,4 @@
-import type { TSESTreeClass } from "../types";
+import type { TSESTreeClass } from "../ast-node";
 
 import path from "node:path";
 import { parseForESLint } from "@typescript-eslint/parser";
@@ -7,7 +7,7 @@ import { simpleTraverse } from "@typescript-eslint/typescript-estree";
 
 import { describe, expect, it } from "vitest";
 import { getFixturesRootDir } from "../../../../../test";
-import { getClassIdentifier } from "../get-class-identifier";
+import { getClassIdentifier } from "../ast-class-id";
 
 function parse(code: string) {
   return parseForESLint(code, {

packages/utilities/ast/src/__tests__/get-function-identifier.test.ts

@@ -1,4 +1,4 @@
-import type { TSESTreeFunction } from "../types";
+import type { TSESTreeFunction } from "../ast-node";
 
 import path from "node:path";
 import { parseForESLint } from "@typescript-eslint/parser";
@@ -7,8 +7,8 @@ import { simpleTraverse } from "@typescript-eslint/typescript-estree";
 
 import { describe, expect, it } from "vitest";
 import { getFixturesRootDir } from "../../../../../test";
-import { getFunctionIdentifier } from "../get-function-identifier";
-import { isFunction } from "../is";
+import { getFunctionIdentifier } from "../ast-function-id";
+import { isFunction } from "../ast-is";
 
 function parse(code: string) {
   return parseForESLint(code, {

packages/utilities/ast/src/__tests__/get-nested-return-statements.test.ts

@@ -1,4 +1,4 @@
-import type { TSESTreeFunction } from "../types";
+import type { TSESTreeFunction } from "../ast-node";
 
 import path from "node:path";
 import { parseForESLint } from "@typescript-eslint/parser";
@@ -8,8 +8,8 @@ import tsx from "dedent";
 
 import { describe, expect, it } from "vitest";
 import { getFixturesRootDir } from "../../../../../test";
-import { getNestedReturnStatements } from "../get-nested-return-statements";
-import { isFunction } from "../is";
+import { isFunction } from "../ast-is";
+import { getNestedReturnStatements } from "../ast-return-statement";
 
 function parse(code: string) {
   return parseForESLint(code, {

packages/utilities/ast/src/get-array-method-callback-index-param-position.ts renamed to packages/utilities/ast/src/ast-array-method-callback.ts

@@ -8,3 +8,11 @@ export function isArrayFromCall(node: TSESTree.Node, loose = true): node is TSES
   const name = node.callee.property.name;
   return name === "from" || (loose && name.startsWith("from"));
 }
+
+export function isArrayMapCall(node: TSESTree.Node, loose = true): node is TSESTree.CallExpression {
+  if (node.type !== T.CallExpression) return false;
+  if (node.callee.type !== T.MemberExpression) return false;
+  if (node.callee.property.type !== T.Identifier) return false;
+  const name = node.callee.property.name;
+  return name === "map" || (loose && name.endsWith("Map"));
+}

packages/utilities/ast/src/is-array-from-call.ts renamed to packages/utilities/ast/src/ast-array-method.ts

@@ -1,5 +1,5 @@
 import type { TSESTree } from "@typescript-eslint/types";
-import type { TSESTreeClass } from "./types";
+import type { TSESTreeClass } from "./ast-node";
 import { _ } from "@eslint-react/eff";
 
 import { AST_NODE_TYPES as T } from "@typescript-eslint/types";

packages/utilities/ast/src/get-class-identifier.ts renamed to packages/utilities/ast/src/ast-class-id.ts

@@ -1,6 +1,27 @@
 import type { TSESTree } from "@typescript-eslint/types";
-import { AST_NODE_TYPES as T } from "@typescript-eslint/typescript-estree";
-import { ASTUtils } from "@typescript-eslint/utils";
+import type { TSESTreeTypeExpression } from "./ast-node";
+
+import { AST_NODE_TYPES as T } from "@typescript-eslint/types";
+import { is, isTypeExpression } from "./ast-is";
+
+/**
+ * Recursively get the inner expression until it's not a TypeExpression
+ * @param node - The node to get the expression from
+ * @returns The inner expression
+ */
+export function getJSExpression(node: TSESTree.Node): Exclude<
+  TSESTree.Node,
+  TSESTreeTypeExpression
+> {
+  if (isTypeExpression(node)) {
+    return getJSExpression(node.expression);
+  }
+  return node;
+}
+
+export function isThisExpression(node: TSESTree.Expression) {
+  return getJSExpression(node).type === T.ThisExpression;
+}
 
 /**
  * Get all nested expressions of type T in an expression like node
@@ -10,7 +31,7 @@ import { ASTUtils } from "@typescript-eslint/utils";
  */
 // dprint-ignore
 export function getNestedExpressionsOfType<TNodeType extends T>(type: TNodeType): (node: TSESTree.Node) => Extract<TSESTree.Node, { type: TNodeType }>[] {
-  const isNodeOfType = ASTUtils.isNodeOfType(type);
+  const isNodeOfType = is(type);
   return function(node) {
     const boundGetNestedExpressionsOfType = getNestedExpressionsOfType(type);
     const expressions: Extract<TSESTree.Node, { type: TNodeType }>[] = [];