refactor: minor improvements

Author: Rel1cx

apps/website/package.json

@@ -20,7 +20,7 @@
     "fumadocs-twoslash": "3.1.1",
     "fumadocs-typescript": "4.0.3",
     "fumadocs-ui": "15.2.15",
-    "lucide-react": "^0.507.0",
+    "lucide-react": "^0.508.0",
     "next": "^15.3.2",
     "next-view-transitions": "^0.3.4",
     "react": "^19.1.0",
@@ -44,7 +44,7 @@
     "@tsconfig/strictest": "^2.0.5",
     "@types/hast": "^3.0.4",
     "@types/mdx": "^2.0.13",
-    "@types/node": "^22.15.14",
+    "@types/node": "^22.15.16",
     "@types/react": "^19.1.3",
     "@types/react-dom": "^19.1.3",
     "autoprefixer": "^10.4.21",

examples/next-app/package.json

@@ -22,7 +22,7 @@
     "@tsconfig/next": "^2.0.3",
     "@tsconfig/node22": "^22.0.1",
     "@tsconfig/strictest": "^2.0.5",
-    "@types/node": "^22.15.14",
+    "@types/node": "^22.15.16",
     "@types/react": "^19.1.3",
     "@types/react-dom": "^19.1.3",
     "eslint": "^9.26.0",

examples/vite-react-dom-js-app/package.json

@@ -24,7 +24,7 @@
     "eslint": "^9.26.0",
     "eslint-plugin-react-hooks": "^5.2.0",
     "eslint-plugin-react-refresh": "^0.4.20",
-    "globals": "^16.0.0",
+    "globals": "^16.1.0",
     "vite": "^6.3.5"
   },
   "engines": {

examples/vite-react-dom-js-with-babel-eslint-parser-app/package.json

@@ -34,7 +34,7 @@
     "eslint-plugin-react-refresh": "^0.4.20",
     "eslint-plugin-react-web-api": "workspace:*",
     "eslint-plugin-react-x": "workspace:*",
-    "globals": "^16.0.0",
+    "globals": "^16.1.0",
     "vite": "^6.3.5"
   },
   "engines": {

examples/vite-react-dom-with-ts-blank-eslint-parser-app/package.json

@@ -29,7 +29,7 @@
     "eslint": "^9.26.0",
     "eslint-plugin-react-hooks": "^5.2.0",
     "eslint-plugin-react-refresh": "^0.4.20",
-    "globals": "^16.0.0",
+    "globals": "^16.1.0",
     "ts-blank-eslint-parser": "^0.4.3",
     "typescript": "^5.8.3",
     "typescript-eslint": "^8.32.0",

package.json

@@ -58,14 +58,14 @@
     "@swc/core": "^1.11.24",
     "@tsconfig/node22": "^22.0.1",
     "@tsconfig/strictest": "^2.0.5",
-    "@types/node": "^22.15.14",
+    "@types/node": "^22.15.16",
     "@types/react": "^19.1.3",
     "@types/react-dom": "^19.1.3",
     "@typescript-eslint/parser": "^8.32.0",
     "@typescript-eslint/rule-tester": "^8.32.0",
     "@typescript-eslint/types": "^8.32.0",
     "ansis": "^3.17.0",
-    "cspell": "^9.0.0",
+    "cspell": "^9.0.1",
     "dedent": "^1.6.0",
     "dprint": "^0.49.1",
     "esbuild": "^0.25.4",
@@ -112,7 +112,7 @@
       "@types/react-dom": "^19.1.3",
       "cross-spawn": "^7.0.6",
       "esbuild": "^0.25.4",
-      "lucide-react": "^0.507.0",
+      "lucide-react": "^0.508.0",
       "next": "^15.3.2",
       "react": "^19.1.0",
       "react-dom": "^19.1.0",

packages/plugins/eslint-plugin-react-x/src/rules/jsx-key-before-spread.spec.ts

@@ -38,6 +38,33 @@ ruleTester.run(RULE_NAME, rule, {
         { messageId: "jsxKeyBeforeSpread" },
       ],
     },
+    {
+      code: tsx`
+
+        const App = (props) => {
+        return [
+                <div key="1" {...props} key="2" {...props}>1</div>,
+              ]
+          };
+      `,
+      errors: [
+        { messageId: "jsxKeyBeforeSpread" },
+      ],
+    },
+    {
+      code: tsx`
+
+        const App = (props) => {
+        return [
+                <div {...props} key="1" key="2" {...props}>1</div>,
+              ]
+          };
+      `,
+      errors: [
+        { messageId: "jsxKeyBeforeSpread" },
+        { messageId: "jsxKeyBeforeSpread" },
+      ],
+    },
   ],
   valid: [
     ...allValid,

packages/plugins/eslint-plugin-react-x/src/rules/jsx-key-before-spread.ts

@@ -39,7 +39,10 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
           firstSpreadAttributeIndex ??= index;
           continue;
         }
-        if (attr.name.name === "key" && firstSpreadAttributeIndex != null && index > firstSpreadAttributeIndex) {
+        if (firstSpreadAttributeIndex == null) {
+          continue;
+        }
+        if (attr.name.name === "key" && index > firstSpreadAttributeIndex) {
           context.report({
             messageId: "jsxKeyBeforeSpread",
             node: attr,

packages/plugins/eslint-plugin-react-x/src/rules/no-implicit-key.ts

@@ -34,6 +34,7 @@ export default createRule<[], MessageID>({
   defaultOptions: [],
 });
 
+// TODO: Rewrite the rule to use type checking
 export function create(context: RuleContext<MessageID, []>): RuleListener {
   return {
     JSXOpeningElement(node: TSESTree.JSXOpeningElement) {