fix: improve hook detection logic and vi.mock utilities (#1184)

Author: Rel1cx

packages/plugins/eslint-plugin-react-x/src/rules/no-unnecessary-use-prefix.ts

@@ -49,16 +49,15 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
     "Program:exit"(program) {
       const allHooks = ctx.getAllHooks(program);
       for (const { id, name, node, hookCalls } of allHooks.values()) {
-        // Skip well-known hooks
-        if (WELL_KNOWN_HOOKS.includes(name)) {
+        if (hookCalls.length > 0) {
           continue;
         }
         // Skip empty functions
         if (AST.isEmptyFunction(node)) {
           continue;
         }
-        // Skip useful hooks
-        if (hookCalls.length > 0) {
+        // Skip well-known hooks
+        if (WELL_KNOWN_HOOKS.includes(name)) {
           continue;
         }
         // Skip hooks with comments that contain calls to other hooks

packages/utilities/kit/src/ContextDetection.ts

@@ -43,20 +43,31 @@ export function isProcessEnvNodeEnvCompare(
   return false;
 }
 
+/**
+ * Checks if the given node is a `vi.mock`.
+ * @param node The node to check
+ * @returns `true` if the node is a `vi.mock`, otherwise `false`.
+ * @internal
+ */
+export function isViMock(node: TSESTree.Node | null | unit): node is TSESTree.MemberExpression {
+  return node != null
+    && node.type === T.MemberExpression
+    && node.object.type === T.Identifier
+    && node.object.name === "vi"
+    && node.property.type === T.Identifier
+    && node.property.name === "mock";
+}
+
 /**
  * Checks if the given node is a `vi.mock` callback.
  * @param node The node to check
  * @returns `true` if the node is a `vi.mock` callback, otherwise `false`.
  * @internal
  */
-export function isViMockCallback(node: TSESTree.Node | null | unit): node is TSESTree.FunctionExpression {
+export function isViMockCallback(node: TSESTree.Node | null | unit) {
   return node != null
-    && node.type === T.FunctionExpression
+    && AST.isFunction(node)
     && node.parent.type === T.CallExpression
-    && node.parent.callee.type === T.MemberExpression
-    && node.parent.callee.object.type === T.Identifier
-    && node.parent.callee.object.name === "vi"
-    && node.parent.callee.property.type === T.Identifier
-    && node.parent.callee.property.name === "mock"
+    && isViMock(node.parent.callee)
     && node.parent.arguments[1] === node;
 }