code cleanup

Author: possum-enjoyer

packages/plugins/eslint-plugin-react-x/src/rules/no-unnecessary-use-callback.spec.ts

@@ -600,7 +600,7 @@ ruleTester.run(RULE_NAME, rule, {
     `,
 
     tsx`
-          import { useCallback, useState, useEffect } from 'react';
+      import { useCallback, useState, useEffect } from 'react';
 
       function App({ items }) {
         const [test, setTest] = useState(items.length);
@@ -621,30 +621,30 @@ ruleTester.run(RULE_NAME, rule, {
       }
     `,
     tsx`
-              import { useCallback, useState, useEffect } from 'react';
+      import { useCallback, useState, useEffect } from 'react';
 
-          const Component = () => {
-        const [test, setTest] = useState(items.length);
+        const Component = () => {
+          const [test, setTest] = useState(items.length);
 
-        const updateTest = useCallback(() => { setTest(items.length + 1) }, [setTest, items]);
+          const updateTest = useCallback(() => { setTest(items.length + 1) }, [setTest, items]);
 
-        useEffect(() => {
-          // some condition
-          updateTest();
-        }, [updateTest]);
+          useEffect(() => {
+            // some condition
+            updateTest();
+          }, [updateTest]);
 
-        useEffect(() => {
-          // some condition
-          updateTest();
-        }, [updateTest]);
+          useEffect(() => {
+            // some condition
+            updateTest();
+          }, [updateTest]);
 
-        return <div />;
+          return <div />;
       };
     `,
     tsx`
-              import { useCallback, useState, useEffect } from 'react';
+      import { useCallback, useState, useEffect } from 'react';
 
-          const Component = () => {
+        const Component = () => {
         const [test, setTest] = useState(items.length);
 
         const updateTest = useCallback(() => { setTest(items.length + 1) }, [setTest, items]);
@@ -653,9 +653,9 @@ ruleTester.run(RULE_NAME, rule, {
       };
     `,
     tsx`
-              import { useCallback, useState, useEffect } from 'react';
+      import { useCallback, useState, useEffect } from 'react';
 
-          const Component = () => {
+        const Component = () => {
         const [test, setTest] = useState(items.length);
 
         const updateTest = useCallback(() => { setTest(items.length + 1) }, [setTest, items]);

packages/plugins/eslint-plugin-react-x/src/rules/no-unnecessary-use-callback.ts

@@ -121,19 +121,18 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
       const usages = references.filter((ref) => !(ref.init ?? false));
       const effectSet = new Set<TSESTree.Node>();
 
-      const isUsedOutSideOfEffect = usages.some((usage) => {
+      for (const usage of usages) {
         const effect = AST.findParentNode(usage.identifier, (node) => isUseEffectLikeCall(node));
+
         if (effect == null) {
-          return true;
+          return;
         }
-        effectSet.add(effect);
-        return false;
-      });
 
-      if (isUsedOutSideOfEffect || effectSet.size !== 1) {
-        return;
+        effectSet.add(effect);
+        if (effectSet.size > 1) {
+          return;
+        }
       }
-
       context.report({
         messageId: "noUnnecessaryUseCallbackInsideUseEffect",
         node,