release: 2.0.0-next.33

Rel1cx · Rel1cx · commit bacd6ca27930 · 2025-06-03T10:55:45.000+08:00
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-2.0.0-next.32
+2.0.0-next.33
diff --git a/apps/website/content/docs/rules/meta.json b/apps/website/content/docs/rules/meta.json
@@ -47,6 +47,7 @@
     "no-set-state-in-component-will-update",
     "no-string-refs",
     "no-unnecessary-use-callback",
+    "no-unnecessary-use-effect",
     "no-unnecessary-use-memo",
     "no-unnecessary-use-prefix",
     "no-unsafe-component-will-mount",
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/monorepo",
-  "version": "2.0.0-next.32",
+  "version": "2.0.0-next.33",
   "private": true,
   "description": "Monorepo for eslint-plugin-react-[x, dom, web-api, naming-convention].",
   "keywords": [
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/core",
-  "version": "2.0.0-next.32",
+  "version": "2.0.0-next.33",
   "description": "ESLint React's ESLint utility module for static analysis of React core APIs and patterns.",
   "homepage": "https://github.com/Rel1cx/eslint-react",
   "bugs": {
diff --git a/packages/plugins/eslint-plugin-react-debug/package.json b/packages/plugins/eslint-plugin-react-debug/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-debug",
-  "version": "2.0.0-next.32",
+  "version": "2.0.0-next.33",
   "description": "ESLint React's ESLint plugin for debugging related rules.",
   "keywords": [
     "react",
diff --git a/packages/plugins/eslint-plugin-react-dom/package.json b/packages/plugins/eslint-plugin-react-dom/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-dom",
-  "version": "2.0.0-next.32",
+  "version": "2.0.0-next.33",
   "description": "ESLint React's ESLint plugin for React DOM related rules.",
   "keywords": [
     "react",
diff --git a/packages/plugins/eslint-plugin-react-hooks-extra/package.json b/packages/plugins/eslint-plugin-react-hooks-extra/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-hooks-extra",
-  "version": "2.0.0-next.32",
+  "version": "2.0.0-next.33",
   "description": "ESLint React's ESLint plugin for React Hooks related rules.",
   "keywords": [
     "react",
diff --git a/packages/plugins/eslint-plugin-react-naming-convention/package.json b/packages/plugins/eslint-plugin-react-naming-convention/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-naming-convention",
-  "version": "2.0.0-next.32",
+  "version": "2.0.0-next.33",
   "description": "ESLint React's ESLint plugin for naming convention related rules.",
   "keywords": [
     "react",
diff --git a/packages/plugins/eslint-plugin-react-web-api/package.json b/packages/plugins/eslint-plugin-react-web-api/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-web-api",
-  "version": "2.0.0-next.32",
+  "version": "2.0.0-next.33",
   "description": "ESLint React's ESLint plugin for interacting with Web APIs",
   "keywords": [
     "react",
diff --git a/packages/plugins/eslint-plugin-react-x/package.json b/packages/plugins/eslint-plugin-react-x/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "2.0.0-next.32",
+  "version": "2.0.0-next.33",
   "description": "A set of composable ESLint rules for for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
diff --git a/packages/plugins/eslint-plugin-react-x/src/rules/no-unnecessary-use-effect.md b/packages/plugins/eslint-plugin-react-x/src/rules/no-unnecessary-use-effect.md
@@ -28,266 +28,7 @@ react-x/no-unnecessary-use-effect
 
 Disallow unnecessary usage of `useEffect`.
 
-### What counts as a violation?
-
-This is **not allowed**:
-
-```tsx
-useEffect(() => {
-  setFullName(firstName + " " + lastName);
-}, [firstName, lastName]);
-```
-
-Instead, compute the value during render:
-
-```tsx
-const fullName = firstName + " " + lastName;
-```
-
-### What is allowed?
-
-The rule **does not flag** indirect calls, such as:
-
-- Inside event handlers.
-- Inside `async` functions.
-- Inside `setTimeout`, `setInterval`, `Promise.then`, etc.
-
-### Known limitations
-
-- It doesn’t check `set` calls in `useEffect` cleanup functions.
-
-  ```tsx {2}
-  useEffect(() => {
-    return () => {
-      setFullName(firstName + " " + lastName); // ❌ Direct call
-    };
-  }, [firstName, lastName]);
-  ```
-
-- It doesn’t detect `set` calls in `async` functions are being called before or after the `await` statement.
-
-  ```tsx {2}
-  useEffect(() => {
-    const fetchData = async () => {
-      setFullName(data.name); // ❌ Direct call
-    };
-    fetchData();
-  }, []);
-  ```
-
-## Examples
-
-The first three cases are common valid use cases because they are not called the `set` function directly in `useEffect`:
-
-### Passing
-
-```tsx
-import { useState, useEffect } from "react";
-
-export default function Counter() {
-  const [count, setCount] = useState(0);
-
-  useEffect(() => {
-    const handler = () => setCount((c) => c + 1);
-    window.addEventListener("click", handler);
-    return () => window.removeEventListener("click", handler);
-  }, []);
-
-  return <h1>{count}</h1>;
-}
-```
-
-### Passing
-
-```tsx
-import { useState, useEffect } from "react";
-
-export default function Counter() {
-  const [count, setCount] = useState(0);
-
-  useEffect(() => {
-    const intervalId = setInterval(() => {
-      setCount((c) => c + 1);
-    }, 1000);
-    return () => clearInterval(intervalId);
-  }, []);
-
-  return <h1>{count}</h1>;
-}
-```
-
-### Passing
-
-```tsx
-import { useState, useEffect } from "react";
-
-export default function RemoteContent() {
-  const [content, setContent] = useState("");
-
-  useEffect(() => {
-    let discarded = false;
-    fetch("https://eslint-react.xyz/content")
-      .then((resp) => resp.text())
-      .then((text) => {
-        if (discarded) return;
-        setContent(text);
-      });
-    return () => {
-      discarded = true;
-    };
-  }, []);
-
-  return <h1>{count}</h1>;
-}
-```
-
-The following examples are derived from the [React documentation](https://react.dev/learn/you-might-not-need-an-effect):
-
-### Failing
-
-```tsx
-import { useEffect, useState } from "react";
-
-function Form() {
-  const [firstName, setFirstName] = useState("Taylor");
-  const [lastName, setLastName] = useState("Swift");
-
-  // 🔴 Avoid: redundant state and unnecessary Effect
-  const [fullName, setFullName] = useState("");
-  useEffect(() => {
-    setFullName(firstName + " " + lastName);
-  }, [firstName, lastName]);
-  // ...
-}
-```
-
-### Passing
-
-```tsx
-import { useState } from "react";
-
-function Form() {
-  const [firstName, setFirstName] = useState("Taylor");
-  const [lastName, setLastName] = useState("Swift");
-  // ✅ Good: calculated during rendering
-  const fullName = firstName + " " + lastName;
-  // ...
-}
-```
-
-### Failing
-
-```tsx
-import { useEffect, useState } from "react";
-
-function TodoList({ todos, filter }) {
-  const [newTodo, setNewTodo] = useState("");
-
-  // 🔴 Avoid: redundant state and unnecessary Effect
-  const [visibleTodos, setVisibleTodos] = useState([]);
-  useEffect(() => {
-    setVisibleTodos(getFilteredTodos(todos, filter));
-  }, [todos, filter]);
-
-  // ...
-}
-```
-
-### Passing
-
-```tsx
-import { useMemo, useState } from "react";
-
-function TodoList({ todos, filter }) {
-  const [newTodo, setNewTodo] = useState("");
-  // ✅ Does not re-run getFilteredTodos() unless todos or filter change
-  const visibleTodos = useMemo(
-    () => getFilteredTodos(todos, filter),
-    [todos, filter],
-  );
-  // ...
-}
-```
-
-### Failing
-
-```tsx
-import { useEffect, useState } from "react";
-
-export default function ProfilePage({ userId }) {
-  const [comment, setComment] = useState("");
-
-  // 🔴 Avoid: Resetting state on prop change in an Effect
-  useEffect(() => {
-    setComment("");
-  }, [userId]);
-  // ...
-}
-```
-
-### Passing
-
-```tsx
-import { useState } from "react";
-
-export default function ProfilePage({ userId }) {
-  return <Profile userId={userId} key={userId} />;
-}
-
-function Profile({ userId }) {
-  // ✅ This and any other state below will reset on key change automatically
-  const [comment, setComment] = useState("");
-  // ...
-}
-```
-
-### Failing
-
-```tsx
-import { useEffect, useState } from "react";
-
-function List({ items }) {
-  const [isReverse, setIsReverse] = useState(false);
-  const [selection, setSelection] = useState(null);
-
-  // 🔴 Avoid: Adjusting state on prop change in an Effect
-  useEffect(() => {
-    setSelection(null);
-  }, [items]);
-  // ...
-}
-```
-
-### Passing
-
-```tsx
-import { useState } from "react";
-
-function List({ items }) {
-  const [isReverse, setIsReverse] = useState(false);
-  const [selection, setSelection] = useState(null);
-
-  // Better: Adjust the state while rendering
-  const [prevItems, setPrevItems] = useState(items);
-  if (items !== prevItems) {
-    setPrevItems(items);
-    setSelection(null);
-  }
-  // ...
-}
-```
-
-```tsx
-import { useState } from "react";
-
-function List({ items }) {
-  const [isReverse, setIsReverse] = useState(false);
-  const [selectedId, setSelectedId] = useState(null);
-  // ✅ Best: Calculate everything during rendering
-  const selection = items.find((item) => item.id === selectedId) ?? null;
-  // ...
-}
-```
+TODO
 
 ## Implementation
 
@@ -304,5 +45,4 @@ function List({ items }) {
 
 ## See Also
 
-- [`no-direct-set-state-in-use-layout-effect`](./no-direct-set-state-in-use-layout-effect)\
-  Disallow **direct** calls to the [`set` function](https://react.dev/reference/react/useState#setstate) of `useState` in `useLayoutEffect`.
+TODO
diff --git a/packages/plugins/eslint-plugin/package.json b/packages/plugins/eslint-plugin/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/eslint-plugin",
-  "version": "2.0.0-next.32",
+  "version": "2.0.0-next.33",
   "description": "A unified plugin that combines all individual plugins from the eslint-react monorepo into one.",
   "keywords": [
     "react",
diff --git a/packages/shared/package.json b/packages/shared/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/shared",
-  "version": "2.0.0-next.32",
+  "version": "2.0.0-next.33",
   "description": "ESLint React's Shared constants and functions.",
   "homepage": "https://github.com/Rel1cx/eslint-react",
   "bugs": {
diff --git a/packages/utilities/ast/package.json b/packages/utilities/ast/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/ast",
-  "version": "2.0.0-next.32",
+  "version": "2.0.0-next.33",
   "description": "ESLint React's TSESTree AST utility module.",
   "homepage": "https://github.com/Rel1cx/eslint-react",
   "bugs": {
diff --git a/packages/utilities/eff/package.json b/packages/utilities/eff/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/eff",
-  "version": "2.0.0-next.32",
+  "version": "2.0.0-next.33",
   "description": "JavaScript and TypeScript utilities (previously some re-exports of the effect library).",
   "homepage": "https://github.com/Rel1cx/eslint-react",
   "bugs": {
diff --git a/packages/utilities/kit/package.json b/packages/utilities/kit/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/kit",
-  "version": "2.0.0-next.32",
+  "version": "2.0.0-next.33",
   "description": "ESLint React's plugin kit for building plugins and rules.",
   "homepage": "https://github.com/Rel1cx/eslint-react",
   "bugs": {
diff --git a/packages/utilities/var/package.json b/packages/utilities/var/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/var",
-  "version": "2.0.0-next.32",
+  "version": "2.0.0-next.33",
   "description": "ESLint React's TSESTree AST utility module for static analysis of variables.",
   "homepage": "https://github.com/Rel1cx/eslint-react",
   "bugs": {

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@eslint-react/monorepo",`
`3`		`- "version": "2.0.0-next.32",`
	`3`	`+ "version": "2.0.0-next.33",`
`4`	`4`	`"private": true,`
`5`	`5`	`"description": "Monorepo for eslint-plugin-react-[x, dom, web-api, naming-convention].",`
`6`	`6`	`"keywords": [`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@eslint-react/core",`
`3`		`- "version": "2.0.0-next.32",`
	`3`	`+ "version": "2.0.0-next.33",`
`4`	`4`	`"description": "ESLint React's ESLint utility module for static analysis of React core APIs and patterns.",`
`5`	`5`	`"homepage": "https://github.com/Rel1cx/eslint-react",`
`6`	`6`	`"bugs": {`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "eslint-plugin-react-debug",`
`3`		`- "version": "2.0.0-next.32",`
	`3`	`+ "version": "2.0.0-next.33",`
`4`	`4`	`"description": "ESLint React's ESLint plugin for debugging related rules.",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"react",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "eslint-plugin-react-dom",`
`3`		`- "version": "2.0.0-next.32",`
	`3`	`+ "version": "2.0.0-next.33",`
`4`	`4`	`"description": "ESLint React's ESLint plugin for React DOM related rules.",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"react",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "eslint-plugin-react-hooks-extra",`
`3`		`- "version": "2.0.0-next.32",`
	`3`	`+ "version": "2.0.0-next.33",`
`4`	`4`	`"description": "ESLint React's ESLint plugin for React Hooks related rules.",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"react",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "eslint-plugin-react-naming-convention",`
`3`		`- "version": "2.0.0-next.32",`
	`3`	`+ "version": "2.0.0-next.33",`
`4`	`4`	`"description": "ESLint React's ESLint plugin for naming convention related rules.",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"react",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "eslint-plugin-react-web-api",`
`3`		`- "version": "2.0.0-next.32",`
	`3`	`+ "version": "2.0.0-next.33",`
`4`	`4`	`"description": "ESLint React's ESLint plugin for interacting with Web APIs",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"react",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "eslint-plugin-react-x",`
`3`		`- "version": "2.0.0-next.32",`
	`3`	`+ "version": "2.0.0-next.33",`
`4`	`4`	`"description": "A set of composable ESLint rules for for libraries and frameworks that use React as a UI runtime.",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"react",`