fix: false positive in 'react-x/no-context-provider' on components named 'Provider', closes #991

Rel1cx · Rel1cx · commit c2b20b38a097 · 2025-03-15T14:16:10.000+08:00
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-1.34.0
+1.34.1-next.0
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/monorepo",
-  "version": "1.34.0",
+  "version": "1.34.1-next.0",
   "private": true,
   "description": "Monorepo for eslint-plugin-react-[x, dom, web-api, hooks-extra, naming-convention].",
   "keywords": [
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/core",
-  "version": "1.34.0",
+  "version": "1.34.1-next.0",
   "description": "ESLint React's ESLint utility module for static analysis of React core APIs and patterns.",
   "homepage": "https://github.com/Rel1cx/eslint-react",
   "bugs": {
diff --git a/packages/plugins/eslint-plugin-react-debug/package.json b/packages/plugins/eslint-plugin-react-debug/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-debug",
-  "version": "1.34.0",
+  "version": "1.34.1-next.0",
   "description": "ESLint React's ESLint plugin for debugging related rules.",
   "keywords": [
     "react",
diff --git a/packages/plugins/eslint-plugin-react-dom/package.json b/packages/plugins/eslint-plugin-react-dom/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-dom",
-  "version": "1.34.0",
+  "version": "1.34.1-next.0",
   "description": "ESLint React's ESLint plugin for React DOM related rules.",
   "keywords": [
     "react",
diff --git a/packages/plugins/eslint-plugin-react-hooks-extra/package.json b/packages/plugins/eslint-plugin-react-hooks-extra/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-hooks-extra",
-  "version": "1.34.0",
+  "version": "1.34.1-next.0",
   "description": "ESLint React's ESLint plugin for React Hooks related rules.",
   "keywords": [
     "react",
diff --git a/packages/plugins/eslint-plugin-react-naming-convention/package.json b/packages/plugins/eslint-plugin-react-naming-convention/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-naming-convention",
-  "version": "1.34.0",
+  "version": "1.34.1-next.0",
   "description": "ESLint React's ESLint plugin for naming convention related rules.",
   "keywords": [
     "react",
diff --git a/packages/plugins/eslint-plugin-react-web-api/package.json b/packages/plugins/eslint-plugin-react-web-api/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-web-api",
-  "version": "1.34.0",
+  "version": "1.34.1-next.0",
   "description": "ESLint React's ESLint plugin for interacting with Web APIs",
   "keywords": [
     "react",
diff --git a/packages/plugins/eslint-plugin-react-x/package.json b/packages/plugins/eslint-plugin-react-x/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "1.34.0",
+  "version": "1.34.1-next.0",
   "description": "A set of composable linting rules for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
diff --git a/packages/plugins/eslint-plugin-react-x/src/rules/no-context-provider.spec.ts b/packages/plugins/eslint-plugin-react-x/src/rules/no-context-provider.spec.ts
@@ -6,7 +6,7 @@ import rule, { RULE_NAME } from "./no-context-provider";
 ruleTester.run(RULE_NAME, rule, {
   invalid: [
     {
-      code: tsx`<Provider />`,
+      code: tsx`<context.Provider />`,
       errors: [
         {
           messageId: "noContextProvider",
@@ -101,6 +101,27 @@ ruleTester.run(RULE_NAME, rule, {
         },
       },
     },
+    // TODO: Evaluate the necessity of supporting this kind of usage
+    // {
+    //   code: tsx`
+    //     const Context = createContext("");
+    //     const Provider = Context.Provider;
+
+    //     function Component() {
+    //       return <Provider>hello world</Provider>;
+    //     }
+    //   `,
+    //   errors: [
+    //     {
+    //       messageId: "noContextProvider",
+    //     },
+    //   ],
+    //   settings: {
+    //     "react-x": {
+    //       version: "19.0.0",
+    //     },
+    //   },
+    // },
   ],
   valid: [
     {
@@ -151,5 +172,19 @@ ruleTester.run(RULE_NAME, rule, {
         },
       },
     },
+    {
+      code: tsx`
+        import { Provider } from "jotai";
+
+        function Component() {
+          return <Provider>hello world</Provider>;
+        }
+      `,
+      settings: {
+        "react-x": {
+          version: "19.0.0",
+        },
+      },
+    },
   ],
 });
diff --git a/packages/plugins/eslint-plugin-react-x/src/rules/no-context-provider.ts b/packages/plugins/eslint-plugin-react-x/src/rules/no-context-provider.ts
@@ -47,11 +47,11 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
       const contextFullName = parts.join(".");
       const contextSelfName = parts.pop();
       if (selfName !== "Provider") return;
+      if (contextSelfName == null) return;
       context.report({
         messageId: "noContextProvider",
         node,
         fix(fixer) {
-          if (contextSelfName == null) return null;
           if (!isComponentNameLoose(contextSelfName)) return null;
           const openingElement = node.openingElement;
           const closingElement = node.closingElement;
diff --git a/packages/plugins/eslint-plugin/package.json b/packages/plugins/eslint-plugin/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/eslint-plugin",
-  "version": "1.34.0",
+  "version": "1.34.1-next.0",
   "description": "More than 80 high-quality linting rules for writing better React code.",
   "keywords": [
     "react",
diff --git a/packages/shared/package.json b/packages/shared/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/shared",
-  "version": "1.34.0",
+  "version": "1.34.1-next.0",
   "description": "ESLint React's Shared constants and functions.",
   "homepage": "https://github.com/Rel1cx/eslint-react",
   "bugs": {
diff --git a/packages/utilities/ast/package.json b/packages/utilities/ast/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/ast",
-  "version": "1.34.0",
+  "version": "1.34.1-next.0",
   "description": "ESLint React's TSESTree AST utility module.",
   "homepage": "https://github.com/Rel1cx/eslint-react",
   "bugs": {
diff --git a/packages/utilities/eff/package.json b/packages/utilities/eff/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/eff",
-  "version": "1.34.0",
+  "version": "1.34.1-next.0",
   "description": "JavaScript and TypeScript utilities (previously some re-exports of the effect library).",
   "homepage": "https://github.com/Rel1cx/eslint-react",
   "bugs": {
diff --git a/packages/utilities/jsx/package.json b/packages/utilities/jsx/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/jsx",
-  "version": "1.34.0",
+  "version": "1.34.1-next.0",
   "description": "ESLint React's TSESTree AST utility module for static analysis of JSX.",
   "homepage": "https://github.com/Rel1cx/eslint-react",
   "bugs": {
diff --git a/packages/utilities/var/package.json b/packages/utilities/var/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/var",
-  "version": "1.34.0",
+  "version": "1.34.1-next.0",
   "description": "ESLint React's TSESTree AST utility module for static analysis of variables.",
   "homepage": "https://github.com/Rel1cx/eslint-react",
   "bugs": {

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@eslint-react/monorepo",`
`3`		`- "version": "1.34.0",`
	`3`	`+ "version": "1.34.1-next.0",`
`4`	`4`	`"private": true,`
`5`	`5`	`"description": "Monorepo for eslint-plugin-react-[x, dom, web-api, hooks-extra, naming-convention].",`
`6`	`6`	`"keywords": [`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@eslint-react/core",`
`3`		`- "version": "1.34.0",`
	`3`	`+ "version": "1.34.1-next.0",`
`4`	`4`	`"description": "ESLint React's ESLint utility module for static analysis of React core APIs and patterns.",`
`5`	`5`	`"homepage": "https://github.com/Rel1cx/eslint-react",`
`6`	`6`	`"bugs": {`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "eslint-plugin-react-debug",`
`3`		`- "version": "1.34.0",`
	`3`	`+ "version": "1.34.1-next.0",`
`4`	`4`	`"description": "ESLint React's ESLint plugin for debugging related rules.",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"react",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "eslint-plugin-react-dom",`
`3`		`- "version": "1.34.0",`
	`3`	`+ "version": "1.34.1-next.0",`
`4`	`4`	`"description": "ESLint React's ESLint plugin for React DOM related rules.",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"react",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "eslint-plugin-react-hooks-extra",`
`3`		`- "version": "1.34.0",`
	`3`	`+ "version": "1.34.1-next.0",`
`4`	`4`	`"description": "ESLint React's ESLint plugin for React Hooks related rules.",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"react",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "eslint-plugin-react-naming-convention",`
`3`		`- "version": "1.34.0",`
	`3`	`+ "version": "1.34.1-next.0",`
`4`	`4`	`"description": "ESLint React's ESLint plugin for naming convention related rules.",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"react",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "eslint-plugin-react-web-api",`
`3`		`- "version": "1.34.0",`
	`3`	`+ "version": "1.34.1-next.0",`
`4`	`4`	`"description": "ESLint React's ESLint plugin for interacting with Web APIs",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"react",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "eslint-plugin-react-x",`
`3`		`- "version": "1.34.0",`
	`3`	`+ "version": "1.34.1-next.0",`
`4`	`4`	`"description": "A set of composable linting rules for libraries and frameworks that use React as a UI runtime.",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"react",`