refactor: improve getCallName function and update test cases for noDirectSetStateInUseEffect rule

Author: Rel1cx

packages/plugins/eslint-plugin-react-hooks-extra/src/hooks/use-no-direct-set-state-in-use-effect.ts

@@ -47,6 +47,7 @@ export function useNoDirectSetStateInUseEffect<Ctx extends RuleContext>(
   const { onViolation, useEffectKind } = options;
   const settings = getSettingsFromContext(context);
   const additionalHooks = settings.additionalHooks;
+  const getText = (n: TSESTree.Node) => context.sourceCode.getText(n);
   const isUseEffectLikeCall = ER.isReactHookCallWithNameAlias(context, useEffectKind, additionalHooks[useEffectKind]);
   const isUseStateCall = ER.isReactHookCallWithNameAlias(context, "useState", additionalHooks.useState);
   const isUseMemoCall = ER.isReactHookCallWithNameAlias(context, "useMemo", additionalHooks.useMemo);
@@ -80,6 +81,13 @@ export function useNoDirectSetStateInUseEffect<Ctx extends RuleContext>(
       && isUseEffectLikeCall(node.parent);
   }
 
+  function getCallName(node: TSESTree.Node) {
+    if (node.type === T.CallExpression) {
+      return AST.toString(node.callee, getText);
+    }
+    return AST.toString(node, getText);
+  }
+
   function getCallKind(node: TSESTree.CallExpression) {
     return match<TSESTree.CallExpression, CallKind>(node)
       .when(isUseStateCall, () => "useState")
@@ -221,15 +229,15 @@ export function useNoDirectSetStateInUseEffect<Ctx extends RuleContext>(
         const setStateCalls = getSetStateCalls(name, context.sourceCode.getScope(callee));
         for (const setStateCall of setStateCalls) {
           onViolation(context, setStateCall, {
-            name: AST.toString(setStateCall, (n) => context.sourceCode.getText(n)),
+            name: getCallName(setStateCall),
           });
         }
       }
       for (const id of setupFunctionIdentifiers) {
         const setStateCalls = getSetStateCalls(id.name, context.sourceCode.getScope(id));
         for (const setStateCall of setStateCalls) {
           onViolation(context, setStateCall, {
-            name: AST.toString(setStateCall, (n) => context.sourceCode.getText(n)),
+            name: getCallName(setStateCall),
           });
         }
       }