refactor(var): restructure the module (#1076)

Author: Rel1cx

.vscode/settings.json

@@ -31,7 +31,10 @@
     }
   ],
   "eslint.rules.customizations": [
-    { "rule": "@eslint-react/debug/*", "severity": "info" }
+    {
+      "rule": "@eslint-react/debug/*",
+      "severity": "info"
+    }
   ],
   "files.exclude": {
     "**/.zed": true,
@@ -40,5 +43,5 @@
   "mdx.server.enable": true,
   "npm.packageManager": "pnpm",
   "typescript.preferences.importModuleSpecifier": "non-relative",
-  "typescript.tsdk": "node_modules/typescript/lib"
-}
+  "typescript.tsdk": "node_modules/typescript/lib",
+}

packages/plugins/eslint-plugin-react-x/src/rules/no-unstable-context-value.ts

@@ -62,7 +62,7 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
       if (value?.type !== T.JSXExpressionContainer) return;
       const valueExpression = value.expression;
       const initialScope = context.sourceCode.getScope(valueExpression);
-      const construction = VAR.getConstructionDetectionResult(valueExpression, initialScope);
+      const construction = VAR.getConstruction(valueExpression, initialScope);
       if (construction == null) return;
       if (ER.isReactHookCall(construction.node)) {
         return;

packages/plugins/eslint-plugin-react-x/src/rules/no-unstable-default-props.ts

@@ -67,7 +67,7 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
           const { value } = prop;
           const { right } = value;
           const initialScope = context.sourceCode.getScope(value);
-          const construction = VAR.getConstructionDetectionResult(
+          const construction = VAR.getConstruction(
             value,
             initialScope,
             VAR.ConstructionDetectionHint.StrictCallExpression,

packages/utilities/var/src/construction/construction-detection-hint.ts

@@ -1,9 +1,7 @@
-export * from "./construction";
-export * from "./find-property-in-properties";
-export * from "./find-variable";
-export * from "./get-child-scopes";
-export * from "./get-variable-declarator-id";
-export * from "./get-variable-init-node";
-export * from "./get-variables";
-export * from "./is-node-value-equal";
-export * from "./lazy-value";
+export * from "./var-collect";
+export * from "./var-construction";
+export * from "./var-declarator-id";
+export * from "./var-init-node";
+export * from "./var-scope";
+export * from "./var-value";
+export * from "./var-value-equal";

packages/utilities/var/src/construction/construction.ts

@@ -1,10 +1,33 @@
-import type { _ } from "@eslint-react/eff";
-import type { Scope } from "@typescript-eslint/scope-manager";
+import type { Scope, Variable } from "@typescript-eslint/scope-manager";
 import type { TSESTree } from "@typescript-eslint/types";
+import { _, dual } from "@eslint-react/eff";
+import { ScopeType } from "@typescript-eslint/scope-manager";
 import { AST_NODE_TYPES as T } from "@typescript-eslint/types";
+import * as ASTUtils from "@typescript-eslint/utils/ast-utils";
+import { getVariableInitNode } from "./var-init-node";
 
-import { findVariable } from "./find-variable";
-import { getVariableInitNode } from "./get-variable-init-node";
+/**
+ * Get all variables from the given scope up to the global scope
+ * @param initialScope The scope to start from
+ * @returns All variables from the given scope up to the global scope
+ */
+export function getVariables(initialScope: Scope): Variable[] {
+  let scope = initialScope;
+  const variables = [...scope.variables];
+  while (scope.type !== ScopeType.global) {
+    scope = scope.upper;
+    variables.push(...scope.variables);
+  }
+  return variables.reverse();
+}
+
+export const findVariable: {
+  (initialScope: Scope): (nameOrNode: string | TSESTree.Identifier | _) => Variable | _;
+  (nameOrNode: string | TSESTree.Identifier | _, initialScope: Scope): Variable | _;
+} = dual(2, (nameOrNode: string | TSESTree.Identifier | _, initialScope: Scope) => {
+  if (nameOrNode == null) return _;
+  return ASTUtils.findVariable(initialScope, nameOrNode) ?? _;
+});
 
 export function findPropertyInProperties(
   name: string,