minor refactoring for better readability

Author: possum-enjoyer

packages/plugins/eslint-plugin-react-x/src/rules/no-unnecessary-use-callback.spec.ts

@@ -475,7 +475,7 @@ ruleTester.run(RULE_NAME, rule, {
         },
       },
     },
-        {
+    {
       code: tsx`
         const { useCallback, useEffect } = require("@pika/react");
 
@@ -598,6 +598,7 @@ ruleTester.run(RULE_NAME, rule, {
               const refItem = useCallback(cb, deps)
       };
     `,
+
     tsx`
           import { useCallback, useState, useEffect } from 'react';
 
@@ -629,13 +630,13 @@ ruleTester.run(RULE_NAME, rule, {
 
         useEffect(() => {
           // some condition
-          doSomeTask();
-        }, [doSomeTask]);
+          updateTest();
+        }, [updateTest]);
 
         useEffect(() => {
           // some condition
-          doSomeTask();
-        }, [doSomeTask]);
+          updateTest();
+        }, [updateTest]);
 
         return <div />;
       };
@@ -648,7 +649,7 @@ ruleTester.run(RULE_NAME, rule, {
 
         const updateTest = useCallback(() => { setTest(items.length + 1) }, [setTest, items]);
 
-        return <div ref={() => doSomeTask()} />;
+        return <div ref={() => updateTest()} />;
       };
     `,
     tsx`
@@ -659,7 +660,7 @@ ruleTester.run(RULE_NAME, rule, {
 
         const updateTest = useCallback(() => { setTest(items.length + 1) }, [setTest, items]);
 
-        return <div onClick={doSomeTask} />;
+        return <div onClick={updateTest} />;
       };
     `,
   ],

packages/plugins/eslint-plugin-react-x/src/rules/no-unnecessary-use-callback.ts

@@ -108,28 +108,32 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
         return;
       }
 
-      if (isIdentifier(node.id)) {
-        const references = context.sourceCode.getDeclaredVariables(node)[0]?.references ?? [];
-        const usages = references.filter((ref) => !(ref.init ?? false));
-
-        const size = usages.reduce((set, usage) => {
-          const effect = AST.findParentNode(usage.identifier, (node) => {
-            return isUseEffectLikeCall(node);
-          });
-          set.add(effect ?? node.parent);
-          return set;
-        }, new Set()).size;
-
-        if (size !== 1) {
-          return;
-        }
+      if (!isUseCallbackCall(node.init ?? undefined)) {
+        return;
+      }
 
-        context.report({
-          messageId: "noUnnecessaryUseCallbackInsideUseEffect",
-          node,
-          data: { name: node.id.name },
-        });
+      if (!isIdentifier(node.id)) {
+        return;
       }
+
+      const references = context.sourceCode.getDeclaredVariables(node)[0]?.references ?? [];
+      const usages = references.filter((ref) => !(ref.init ?? false));
+
+      const filteredUsageAmount = usages.reduce((set, usage) => {
+        const effect = AST.findParentNode(usage.identifier, (node) => isUseEffectLikeCall(node));
+        // TODO Better check for outside of useEffect usage 
+        return set.add(effect ?? 'outside');
+      }, new Set());
+
+      if (filteredUsageAmount.size !== 1 || filteredUsageAmount.has('outside')) {
+        return;
+      }
+
+      context.report({
+        messageId: "noUnnecessaryUseCallbackInsideUseEffect",
+        node,
+        data: { name: node.id.name },
+      });
     },
   };
 }