fix: fix scope check in no-unnecessary-key rule

Author: Rel1cx

packages/plugins/eslint-plugin-react-x/src/rules/no-unnecessary-key.spec.ts

@@ -79,5 +79,13 @@ ruleTester.run(RULE_NAME, rule, {
     tsx`
       <div><p key='static-child-key' /></div>
     `,
+    // Valid: not a list rendering context
+    tsx`
+      things.map(thing => {
+        function NestedComponent() {
+          return <span key='foo'><span key='bar' /></span>;
+        }
+      })
+    `,
   ],
 });

packages/plugins/eslint-plugin-react-x/src/rules/no-unnecessary-key.ts

@@ -35,16 +35,14 @@ export default createRule<[], MessageID>({
 });
 
 export function create(context: RuleContext<MessageID, []>): RuleListener {
-  if (!context.sourceCode.getText().includes("key=")) {
-    return {};
-  }
-
+  if (!context.sourceCode.text.includes("key=")) return {};
   return {
     JSXAttribute(node: TSESTree.JSXAttribute) {
       if (node.name.name !== "key") return;
       const jsxElement = node.parent.parent;
+      const initialScope = context.sourceCode.getScope(jsxElement);
       const pMapCallback = AST.findParentNode(jsxElement, isMapCallback);
-      if (pMapCallback == null) return;
+      if (pMapCallback == null || context.sourceCode.getScope(pMapCallback) !== initialScope) return;
       const pKeyedElementOrElse = AST.findParentNode(
         jsxElement,
         (n) => {