Skip to content

Commit e56aa4c

Browse files
authored
fix: use smaller error marker range in hooks-extra/no-unnecessary-use-prefix to reduce visual noise (#1063)
1 parent c10b309 commit e56aa4c

File tree

8 files changed

+36
-3
lines changed

8 files changed

+36
-3
lines changed

.vscode/settings.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@
3030
"mode": "auto"
3131
}
3232
],
33+
"eslint.rules.customizations": [
34+
{ "rule": "@eslint-react/debug/*", "severity": "info" },
35+
{ "rule": "@eslint-react/hooks-extra/no-unnecessary-use-prefix", "severity": "info" }
36+
],
3337
"files.exclude": {
3438
"**/.zed": true,
3539
"*.bundled_*.mjs": true
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"eslint.rules.customizations": [
3+
{ "rule": "@eslint-react/debug/*", "severity": "info" },
4+
{ "rule": "@eslint-react/hooks-extra/no-unnecessary-use-prefix", "severity": "info" }
5+
]
6+
}
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"eslint.rules.customizations": [
3+
{ "rule": "@eslint-react/debug/*", "severity": "info" },
4+
{ "rule": "@eslint-react/hooks-extra/no-unnecessary-use-prefix", "severity": "info" }
5+
]
6+
}

examples/vite-react-dom-app/eslint.config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ export default tseslint.config(
5858
},
5959
rules: {
6060
...eslintPluginReactHooks.configs.recommended.rules,
61-
"@eslint-react/debug/jsx": "warn",
6261
},
6362
},
6463
);
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"eslint.rules.customizations": [
3+
{ "rule": "@eslint-react/debug/*", "severity": "info" },
4+
{ "rule": "@eslint-react/hooks-extra/no-unnecessary-use-prefix", "severity": "info" }
5+
]
6+
}
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"eslint.rules.customizations": [
3+
{ "rule": "@eslint-react/debug/*", "severity": "info" },
4+
{ "rule": "@eslint-react/hooks-extra/no-unnecessary-use-prefix", "severity": "info" }
5+
]
6+
}
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"eslint.rules.customizations": [
3+
{ "rule": "@eslint-react/debug/*", "severity": "info" },
4+
{ "rule": "@eslint-react/hooks-extra/no-unnecessary-use-prefix", "severity": "info" }
5+
]
6+
}

packages/plugins/eslint-plugin-react-hooks-extra/src/rules/no-unnecessary-use-prefix.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
4646
...listeners,
4747
"Program:exit"(program) {
4848
const allHooks = ctx.getAllHooks(program);
49-
for (const { name, node, hookCalls } of allHooks.values()) {
49+
for (const { id, name, node, hookCalls } of allHooks.values()) {
5050
// Skip empty functions
5151
if (AST.isEmptyFunction(node)) {
5252
continue;
@@ -61,7 +61,7 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
6161
}
6262
context.report({
6363
messageId: "noUnnecessaryUsePrefix",
64-
node,
64+
node: id ?? node,
6565
data: {
6666
name,
6767
},

0 commit comments

Comments
 (0)