perf: make 'no-create-ref' smaller and faster

Author: Rel1cx

packages/plugins/eslint-plugin-react-x/src/rules/no-create-ref.spec.ts

@@ -123,32 +123,6 @@ ruleTester.run(RULE_NAME, rule, {
     /* tsx */ `
       import { createRef } from 'react';
 
-      const ref = createRef();
-    `,
-    /* tsx */ `
-      import { createRef } from 'react';
-
-      function notComponent() {
-        const ref = createRef();
-      }
-    `,
-    /* tsx */ `
-      import { createRef } from 'react';
-
-      function NotComponent() {
-        const ref = createRef();
-      }
-    `,
-    /* tsx */ `
-      import { createRef } from 'react';
-
-      function NotComponent() {
-        return () => createRef();
-      }
-    `,
-    /* tsx */ `
-      import { createRef } from 'react';
-
       function Component() {
         const ref = useRef();
 

packages/plugins/eslint-plugin-react-x/src/rules/no-create-ref.ts

@@ -1,7 +1,6 @@
-import type { TSESTreeFunction } from "@eslint-react/ast";
-import { isCreateRefCall, useComponentCollector } from "@eslint-react/core";
+import { traverseUp } from "@eslint-react/ast";
+import { isClassComponent, isCreateRefCall } from "@eslint-react/core";
 import { O } from "@eslint-react/tools";
-import type { TSESTree } from "@typescript-eslint/types";
 import type { ESLintUtils } from "@typescript-eslint/utils";
 import type { ConstantCase } from "string-ts";
 
@@ -18,37 +17,17 @@ export default createRule<[], MessageID>({
       description: "disallow 'createRef' in function components",
     },
     messages: {
-      NO_CREATE_REF: "A 'createRef' is not allowed in function components. Use 'useRef' instead.",
+      NO_CREATE_REF: "[Deprecated] Use 'useRef' instead.",
     },
     schema: [],
   },
   name: RULE_NAME,
   create(context) {
-    const { ctx, listeners } = useComponentCollector(context);
-    const possibleCreateRefCalls = new WeakMap<TSESTreeFunction, TSESTree.CallExpression[]>();
-
     return {
-      ...listeners,
       CallExpression(node) {
         if (!isCreateRefCall(node, context)) return;
-        O.map(
-          ctx.getCurrentFunction(),
-          ([_, currentFn]) =>
-            possibleCreateRefCalls.set(currentFn, [...possibleCreateRefCalls.get(currentFn) ?? [], node]),
-        );
-      },
-      "Program:exit"(node) {
-        const components = ctx.getAllComponents(node).values();
-        for (const { node: component } of components) {
-          const createRefCalls = possibleCreateRefCalls.get(component);
-          if (!createRefCalls) continue;
-          for (const createRefCall of createRefCalls) {
-            context.report({
-              messageId: "NO_CREATE_REF",
-              node: createRefCall,
-            });
-          }
-        }
+        if (O.isSome(traverseUp(node, isClassComponent))) return;
+        context.report({ messageId: "NO_CREATE_REF", node });
       },
     };
   },

website/pages/docs/rules/no-create-ref.mdx

@@ -22,7 +22,7 @@ import React, { createRef } from "react";
 function Example() {
   const ref = React.createRef<HTMLDivElement>();
   //          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-  //          - 'createRef' is not allowed in function components. Use 'useRef' instead.
+  //          - [Deprecated] Use 'useRef' instead.
 
   return <div ref={ref} />;
 }