fix: inspectConstruction false negatives when using LogicalExpression and ConditionalExpression

Author: Rel1cx

CHANGELOG.md

@@ -1,3 +1,9 @@
+## v0.10.6-beta.0 (Mon Jan 8 2024)
+
+### 🐞 Fixes
+
+- Fix an issue where `react/no-constructed-context-value` and `react/no-unstable-default-props` would report false negatives when using LogicalExpression and ConditionalExpression.
+
 ## v0.10.5 (Mon Jan 8 2024)
 
 ### ✨ New

packages/utilities/ast/src/construction/inspect-construction.ts

@@ -81,7 +81,7 @@ export function inspectConstruction<T extends RuleContext>(
       .when(is(NodeType.LogicalExpression), (node) => {
         if (!("left" in node && "right" in node)) return None;
         const left = detect(node.left);
-        if (left._tag === "None") return None;
+        if (left._tag !== "None") return left;
 
         return detect(node.right);
       })
@@ -90,7 +90,7 @@ export function inspectConstruction<T extends RuleContext>(
           return None;
         }
         const consequent = detect(node.consequent);
-        if (consequent._tag === "None") return None;
+        if (consequent._tag !== "None") return None;
 
         return detect(node.alternate);
       })