Skip to content

Conversation

@Rel1cx
Copy link
Owner

@Rel1cx Rel1cx commented Oct 31, 2025

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Test
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • I have added a convincing reason for adding this feature, if necessary

Other information

@Rel1cx Rel1cx requested a review from Copilot October 31, 2025 05:47
@vercel
Copy link

vercel bot commented Oct 31, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
eslint-react Ready Ready Preview Comment Oct 31, 2025 5:51am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds recommendations to enable TypeScript's strictNullChecks compiler option across documentation to improve type inference for ESLint React rules.

  • Added strictNullChecks: true to TypeScript and JavaScript configuration examples
  • Added a warning callout explaining that certain rules (like react-x/no-leaked-conditional-rendering) work better with strictNullChecks enabled

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
apps/website/content/docs/getting-started/typescript.mdx Added strictNullChecks option to the tsconfig.json example
apps/website/content/docs/getting-started/javascript.mdx Added strictNullChecks option to the jsconfig.json example
apps/website/content/docs/configuration/configure-project-config.mdx Added warning callout with explanation and example for enabling strictNullChecks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Rel1cx Rel1cx merged commit 9f488b4 into main Oct 31, 2025
10 of 11 checks passed
@Rel1cx Rel1cx deleted the strict-null-checks branch October 31, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants